From: Yang Xu <xuyang2018.jy@fujitsu.com> To: <linux-fsdevel@vger.kernel.org> Cc: <ceph-devel@vger.kernel.org>, <linux-nfs@vger.kernel.org>, <linux-xfs@vger.kernel.org>, <viro@zeniv.linux.org.uk>, <david@fromorbit.com>, <djwong@kernel.org>, <brauner@kernel.org>, <jlayton@kernel.org>, <ntfs3@lists.linux.dev>, <chao@kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>, Yang Xu <xuyang2018.jy@fujitsu.com> Subject: [PATCH v4 2/8] fs: Add missing umask strip in vfs_tmpfile Date: Tue, 19 Apr 2022 19:47:08 +0800 [thread overview] Message-ID: <1650368834-2420-2-git-send-email-xuyang2018.jy@fujitsu.com> (raw) In-Reply-To: <1650368834-2420-1-git-send-email-xuyang2018.jy@fujitsu.com> All creation paths except for O_TMPFILE handle umask in the vfs directly if the filesystem doesn't support or enable POSIX ACLs. If the filesystem does then umask handling is deferred until posix_acl_create(). Because, O_TMPFILE misses umask handling in the vfs it will not honor umask settings. Fix this by adding the missing umask handling. Reported-by: Christian Brauner (Microsoft) <brauner@kernel.org> Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 509657fdf4f5..73646e28fae0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3521,6 +3521,8 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns, child = d_alloc(dentry, &slash_name); if (unlikely(!child)) goto out_err; + if (!IS_POSIXACL(dir)) + mode &= ~current_umask(); error = dir->i_op->tmpfile(mnt_userns, dir, child, mode); if (error) goto out_err; -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Yang Xu <xuyang2018.jy@fujitsu.com> To: <linux-fsdevel@vger.kernel.org> Cc: linux-nfs@vger.kernel.org, Yang Xu <xuyang2018.jy@fujitsu.com>, djwong@kernel.org, david@fromorbit.com, brauner@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, viro@zeniv.linux.org.uk, jlayton@kernel.org, ceph-devel@vger.kernel.org, ntfs3@lists.linux.dev Subject: [f2fs-dev] [PATCH v4 2/8] fs: Add missing umask strip in vfs_tmpfile Date: Tue, 19 Apr 2022 19:47:08 +0800 [thread overview] Message-ID: <1650368834-2420-2-git-send-email-xuyang2018.jy@fujitsu.com> (raw) In-Reply-To: <1650368834-2420-1-git-send-email-xuyang2018.jy@fujitsu.com> All creation paths except for O_TMPFILE handle umask in the vfs directly if the filesystem doesn't support or enable POSIX ACLs. If the filesystem does then umask handling is deferred until posix_acl_create(). Because, O_TMPFILE misses umask handling in the vfs it will not honor umask settings. Fix this by adding the missing umask handling. Reported-by: Christian Brauner (Microsoft) <brauner@kernel.org> Acked-by: Christian Brauner (Microsoft) <brauner@kernel.org> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com> --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 509657fdf4f5..73646e28fae0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3521,6 +3521,8 @@ struct dentry *vfs_tmpfile(struct user_namespace *mnt_userns, child = d_alloc(dentry, &slash_name); if (unlikely(!child)) goto out_err; + if (!IS_POSIXACL(dir)) + mode &= ~current_umask(); error = dir->i_op->tmpfile(mnt_userns, dir, child, mode); if (error) goto out_err; -- 2.27.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-04-19 10:46 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-19 11:47 [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 11:47 ` Yang Xu [this message] 2022-04-19 11:47 ` [f2fs-dev] [PATCH v4 2/8] fs: Add missing umask strip in vfs_tmpfile Yang Xu 2022-04-19 11:47 ` [PATCH v4 3/8] xfs: only call posix_acl_create under CONFIG_XFS_POSIX_ACL Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 13:53 ` Christian Brauner 2022-04-19 13:53 ` [f2fs-dev] " Christian Brauner 2022-04-20 1:12 ` xuyang2018.jy 2022-04-20 1:12 ` [f2fs-dev] " xuyang2018.jy 2022-04-20 4:49 ` Christoph Hellwig 2022-04-20 4:49 ` [f2fs-dev] " Christoph Hellwig 2022-04-19 11:47 ` [PATCH v4 4/8] NFSv3: only do posix_acl_create under CONFIG_NFS_V3_ACL Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 13:59 ` Christian Brauner 2022-04-19 13:59 ` [f2fs-dev] " Christian Brauner 2022-04-19 14:11 ` Trond Myklebust 2022-04-19 14:11 ` [f2fs-dev] " Trond Myklebust 2022-04-20 1:12 ` xuyang2018.jy 2022-04-20 1:12 ` [f2fs-dev] " xuyang2018.jy 2022-04-19 11:47 ` [PATCH v4 5/8] f2fs: Remove useless NULL assign value for acl and default_acl Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 14:02 ` Christian Brauner 2022-04-19 14:02 ` [f2fs-dev] " Christian Brauner 2022-04-20 1:14 ` xuyang2018.jy 2022-04-20 1:14 ` [f2fs-dev] " xuyang2018.jy 2022-04-19 11:47 ` [PATCH v4 6/8] ntfs3: Use the same order for acl pointer check in ntfs_init_acl Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 14:03 ` Christian Brauner 2022-04-19 14:03 ` [f2fs-dev] " Christian Brauner 2022-04-20 1:15 ` xuyang2018.jy 2022-04-20 1:15 ` [f2fs-dev] " xuyang2018.jy 2022-04-19 11:47 ` [PATCH v4 7/8] fs: strip file's S_ISGID mode on vfs instead of on underlying filesystem Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 14:09 ` Christian Brauner 2022-04-19 14:09 ` [f2fs-dev] " Christian Brauner 2022-04-20 1:16 ` xuyang2018.jy 2022-04-20 1:16 ` [f2fs-dev] " xuyang2018.jy 2022-04-19 11:47 ` [PATCH v4 8/8] ceph: Remove S_ISGID clear code in ceph_finish_async_create Yang Xu 2022-04-19 11:47 ` [f2fs-dev] " Yang Xu 2022-04-19 14:05 ` [PATCH v4 1/8] fs: move sgid strip operation from inode_init_owner into inode_sgid_strip Christian Brauner 2022-04-19 14:05 ` [f2fs-dev] " Christian Brauner 2022-04-20 1:27 ` xuyang2018.jy 2022-04-20 1:27 ` [f2fs-dev] " xuyang2018.jy 2022-04-20 21:52 ` Dave Chinner 2022-04-20 21:52 ` [f2fs-dev] " Dave Chinner 2022-04-21 1:11 ` xuyang2018.jy 2022-04-21 1:11 ` [f2fs-dev] " xuyang2018.jy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1650368834-2420-2-git-send-email-xuyang2018.jy@fujitsu.com \ --to=xuyang2018.jy@fujitsu.com \ --cc=brauner@kernel.org \ --cc=ceph-devel@vger.kernel.org \ --cc=chao@kernel.org \ --cc=david@fromorbit.com \ --cc=djwong@kernel.org \ --cc=jlayton@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=ntfs3@lists.linux.dev \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.