All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Kevin Hao <haokexin@gmail.com>
Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	mcoquelin.stm32@gmail.com, zhengdejin5@gmail.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state
Date: Wed, 20 Apr 2022 10:20:10 +0000	[thread overview]
Message-ID: <165045001089.14273.9231245992154971496.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220419084226.38340-1-haokexin@gmail.com>

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 19 Apr 2022 16:42:26 +0800 you wrote:
> The init_systime() may be invoked in atomic state. We have observed the
> following call trace when running "phc_ctl /dev/ptp0 set" on a Intel
> Agilex board.
>   BUG: sleeping function called from invalid context at drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:74
>   in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 381, name: phc_ctl
>   preempt_count: 1, expected: 0
>   RCU nest depth: 0, expected: 0
>   Preemption disabled at:
>   [<ffff80000892ef78>] stmmac_set_time+0x34/0x8c
>   CPU: 2 PID: 381 Comm: phc_ctl Not tainted 5.18.0-rc2-next-20220414-yocto-standard+ #567
>   Hardware name: SoCFPGA Agilex SoCDK (DT)
>   Call trace:
>    dump_backtrace.part.0+0xc4/0xd0
>    show_stack+0x24/0x40
>    dump_stack_lvl+0x7c/0xa0
>    dump_stack+0x18/0x34
>    __might_resched+0x154/0x1c0
>    __might_sleep+0x58/0x90
>    init_systime+0x78/0x120
>    stmmac_set_time+0x64/0x8c
>    ptp_clock_settime+0x60/0x9c
>    pc_clock_settime+0x6c/0xc0
>    __arm64_sys_clock_settime+0x88/0xf0
>    invoke_syscall+0x5c/0x130
>    el0_svc_common.constprop.0+0x4c/0x100
>    do_el0_svc+0x7c/0xa0
>    el0_svc+0x58/0xcc
>    el0t_64_sync_handler+0xa4/0x130
>    el0t_64_sync+0x18c/0x190
> 
> [...]

Here is the summary with links:
  - [v2,net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state
    https://git.kernel.org/netdev/net/c/234901de2bc6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Kevin Hao <haokexin@gmail.com>
Cc: netdev@vger.kernel.org, peppe.cavallaro@st.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	mcoquelin.stm32@gmail.com, zhengdejin5@gmail.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state
Date: Wed, 20 Apr 2022 10:20:10 +0000	[thread overview]
Message-ID: <165045001089.14273.9231245992154971496.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220419084226.38340-1-haokexin@gmail.com>

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 19 Apr 2022 16:42:26 +0800 you wrote:
> The init_systime() may be invoked in atomic state. We have observed the
> following call trace when running "phc_ctl /dev/ptp0 set" on a Intel
> Agilex board.
>   BUG: sleeping function called from invalid context at drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:74
>   in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 381, name: phc_ctl
>   preempt_count: 1, expected: 0
>   RCU nest depth: 0, expected: 0
>   Preemption disabled at:
>   [<ffff80000892ef78>] stmmac_set_time+0x34/0x8c
>   CPU: 2 PID: 381 Comm: phc_ctl Not tainted 5.18.0-rc2-next-20220414-yocto-standard+ #567
>   Hardware name: SoCFPGA Agilex SoCDK (DT)
>   Call trace:
>    dump_backtrace.part.0+0xc4/0xd0
>    show_stack+0x24/0x40
>    dump_stack_lvl+0x7c/0xa0
>    dump_stack+0x18/0x34
>    __might_resched+0x154/0x1c0
>    __might_sleep+0x58/0x90
>    init_systime+0x78/0x120
>    stmmac_set_time+0x64/0x8c
>    ptp_clock_settime+0x60/0x9c
>    pc_clock_settime+0x6c/0xc0
>    __arm64_sys_clock_settime+0x88/0xf0
>    invoke_syscall+0x5c/0x130
>    el0_svc_common.constprop.0+0x4c/0x100
>    do_el0_svc+0x7c/0xa0
>    el0_svc+0x58/0xcc
>    el0t_64_sync_handler+0xa4/0x130
>    el0t_64_sync+0x18c/0x190
> 
> [...]

Here is the summary with links:
  - [v2,net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state
    https://git.kernel.org/netdev/net/c/234901de2bc6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-20 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-19  8:42 [PATCH v2 net] net: stmmac: Use readl_poll_timeout_atomic() in atomic state Kevin Hao
2022-04-19  8:42 ` Kevin Hao
2022-04-20 10:20 ` patchwork-bot+netdevbpf [this message]
2022-04-20 10:20   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165045001089.14273.9231245992154971496.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=haokexin@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=zhengdejin5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.