All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: chanho61.park@samsung.com, krzysztof.kozlowski@linaro.org,
	andi@etezian.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	adithya.kv@samsung.com
Subject: Re: [PATCH] spi: s3c64xx: move dma_release_channel to unprepare
Date: Tue, 28 Jun 2022 11:31:30 +0100	[thread overview]
Message-ID: <165641229004.254742.10031368402707043673.b4-ty@kernel.org> (raw)
In-Reply-To: <20220627013845.138350-1-chanho61.park@samsung.com>

On Mon, 27 Jun 2022 10:38:45 +0900, Chanho Park wrote:
> This fixes the sequence of dma_release_channel.
> Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only
> during data transfer"),
> dma_release_channel has been located in the s3c64xx_spi_transfer_one
> but this makes invalid return of can_dma callback.
> __spi_unmap_msg will check whether the request is requested by dma or
> not via can_dma callback. When it is calling to check it, the channels
> will be already released at the end of s3c64xx_spi_transfer_one so the
> callback function will return always "false". So, they can't be unmapped
> from __spi_unmap_msg call. To fix this, we need to add
> unprepare_transfer_hardware callback and move the dma_release_channel
> from s3c64xx_spi_transfer_one to there.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: s3c64xx: move dma_release_channel to unprepare
      commit: 82295bc0d192d7e35e0568b18ca66da2c3058fd5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: chanho61.park@samsung.com, krzysztof.kozlowski@linaro.org,
	andi@etezian.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org,
	adithya.kv@samsung.com
Subject: Re: [PATCH] spi: s3c64xx: move dma_release_channel to unprepare
Date: Tue, 28 Jun 2022 11:31:30 +0100	[thread overview]
Message-ID: <165641229004.254742.10031368402707043673.b4-ty@kernel.org> (raw)
In-Reply-To: <20220627013845.138350-1-chanho61.park@samsung.com>

On Mon, 27 Jun 2022 10:38:45 +0900, Chanho Park wrote:
> This fixes the sequence of dma_release_channel.
> Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only
> during data transfer"),
> dma_release_channel has been located in the s3c64xx_spi_transfer_one
> but this makes invalid return of can_dma callback.
> __spi_unmap_msg will check whether the request is requested by dma or
> not via can_dma callback. When it is calling to check it, the channels
> will be already released at the end of s3c64xx_spi_transfer_one so the
> callback function will return always "false". So, they can't be unmapped
> from __spi_unmap_msg call. To fix this, we need to add
> unprepare_transfer_hardware callback and move the dma_release_channel
> from s3c64xx_spi_transfer_one to there.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: s3c64xx: move dma_release_channel to unprepare
      commit: 82295bc0d192d7e35e0568b18ca66da2c3058fd5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-28 10:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220627014049epcas2p1fd6b4dddf5b40cd334708043a08ac2f9@epcas2p1.samsung.com>
2022-06-27  1:38 ` [PATCH] spi: s3c64xx: move dma_release_channel to unprepare Chanho Park
2022-06-27  1:38   ` Chanho Park
2022-06-28 10:31   ` Mark Brown [this message]
2022-06-28 10:31     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165641229004.254742.10031368402707043673.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=adithya.kv@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andi@etezian.org \
    --cc=chanho61.park@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.