[Intel-wired-lan] [PATCH net v1 0/3] ice: Fixes for double vlan promiscuous mode

[Intel-wired-lan] [PATCH net v1 0/3] ice: Fixes for double vlan promiscuous mode

[Grzegorz Siwik]

This series fixes known issues related to double vlan promiscuous mode.
When at least two interfaces are bonded and a bridge is enabled on the
bond, an error can occur when the bridge is removed and re-added. The
reason for the error is because promiscuous mode was not fully cleared from
the VLAN VSI in the hardware.
Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
This fix is needed because the driver could set promiscuous mode
when it still has not cleared properly.
Avoid enabling or disabling vlan 0 when trying to set promiscuous
vlan mode if double vlan mode is enabled. This fix is needed
because the driver tries to add the vlan 0 filter twice (once for
inner and once for outer) when double VLAN mode is enabled.

Grzegorz Siwik (3):
  ice: Fix double VLAN error when entering promisc mode
  ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode
  ice: Fix clearing of promisc mode with bridge over bond

 drivers/net/ethernet/intel/ice/ice_lib.c    |  8 +++++++-
 drivers/net/ethernet/intel/ice/ice_main.c   | 13 ++++++++++++-
 drivers/net/ethernet/intel/ice/ice_switch.c |  9 ++++++++-
 3 files changed, 27 insertions(+), 3 deletions(-)

-- 
1.8.3.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode

[Grzegorz Siwik]

Avoid enabling or disabling vlan 0 when trying to set promiscuous
vlan mode if double vlan mode is enabled. This fix is needed
because the driver tries to add the vlan 0 filter twice (once for
inner and once for outer) when double VLAN mode is enabled. The
filter program is rejected by the firmware when double vlan is
enabled, because the promiscuous filter only needs to be set once.

This issue was missed in the initial implementation of double vlan
mode.

Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
Tested-by: Igor Raits <igor@gooddata.com>
Link:
https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
---
 drivers/net/ethernet/intel/ice/ice_switch.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 8d8f3ee..8a60052 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4414,6 +4414,13 @@ static u8 ice_determine_promisc_mask(struct ice_fltr_info *fi)
 		goto free_fltr_list;
 
 	list_for_each_entry(list_itr, &vsi_list_head, list_entry) {
+		/* Avoid enabling or disabling vlan zero twice when in double
+		 * vlan mode
+		 */
+		if (ice_is_dvm_ena(hw) &&
+		    list_itr->fltr_info.l_data.vlan.tpid == 0)
+			continue;
+
 		vlan_id = list_itr->fltr_info.l_data.vlan.vlan_id;
 		if (rm_vlan_promisc)
 			status = ice_clear_vsi_promisc(hw, vsi_handle,
-- 
1.8.3.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[Intel-wired-lan] [PATCH net v1 2/3] ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode

[Grzegorz Siwik]

Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
This fix is needed because the driver could set promiscuous mode
when it still has not cleared properly.
Promiscuous mode could be set only once, so setting it second
time will be rejected.

Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
Tested-by: Igor Raits <igor@gooddata.com>
Link:
https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
---
 drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 8a60052..0aa4871 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -4428,7 +4428,7 @@ static u8 ice_determine_promisc_mask(struct ice_fltr_info *fi)
 		else
 			status = ice_set_vsi_promisc(hw, vsi_handle,
 						     promisc_mask, vlan_id);
-		if (status)
+		if (status && status != -EEXIST)
 			break;
 	}
 
-- 
1.8.3.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

[Intel-wired-lan] [PATCH net v1 3/3] ice: Fix clearing of promisc mode with bridge over bond

[Grzegorz Siwik]

When at least two interfaces are bonded and a bridge is enabled on the
bond, an error can occur when the bridge is removed and re-added. The
reason for the error is because promiscuous mode was not fully cleared from
the VLAN VSI in the hardware. With this change, promiscuous mode is
properly removed when the bridge disconnects from bonding.

[ 1033.676359] bond1: link status definitely down for interface enp95s0f0, disabling it
[ 1033.676366] bond1: making interface enp175s0f0 the new active one
[ 1033.676369] device enp95s0f0 left promiscuous mode
[ 1033.676522] device enp175s0f0 entered promiscuous mode
[ 1033.676901] ice 0000:af:00.0 enp175s0f0: Error setting Multicast promiscuous mode on VSI 6
[ 1041.795662] ice 0000:af:00.0 enp175s0f0: Error setting Multicast promiscuous mode on VSI 6
[ 1041.944826] bond1: link status definitely down for interface enp175s0f0, disabling it
[ 1041.944874] device enp175s0f0 left promiscuous mode
[ 1041.944918] bond1: now running without any active interface!

Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops implementations")
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
Co-developed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
Tested-by: Igor Raits <igor@gooddata.com>
Link:
https://lore.kernel.org/all/CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
---
 drivers/net/ethernet/intel/ice/ice_lib.c  |  8 +++++++-
 drivers/net/ethernet/intel/ice/ice_main.c | 13 ++++++++++++-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index f7f9c97..251012d 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -4078,7 +4078,13 @@ int ice_vsi_del_vlan_zero(struct ice_vsi *vsi)
 	if (err && err != -EEXIST)
 		return err;
 
-	return 0;
+	/* when deleting the last VLAN filter, make sure to disable the VLAN
+	 * promisc mode so the filter isn't left by accident
+	 */
+	err = ice_clear_vsi_promisc(&vsi->back->hw, vsi->idx,
+				    ICE_MCAST_VLAN_PROMISC_BITS, 0);
+
+	return err;
 }
 
 /**
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index c1ac2f7..c4f89c1 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -267,8 +267,10 @@ static int ice_set_promisc(struct ice_vsi *vsi, u8 promisc_m)
 		status = ice_fltr_set_vsi_promisc(&vsi->back->hw, vsi->idx,
 						  promisc_m, 0);
 	}
+	if (status && status != -EEXIST)
+		return status;
 
-	return status;
+	return 0;
 }
 
 /**
@@ -3572,6 +3574,15 @@ struct ice_vsi *
 	while (test_and_set_bit(ICE_CFG_BUSY, vsi->state))
 		usleep_range(1000, 2000);
 
+	ret = ice_clear_vsi_promisc(&vsi->back->hw, vsi->idx,
+				    ICE_MCAST_VLAN_PROMISC_BITS, vid);
+
+	if (ret) {
+		netdev_err(netdev, "Error clearing multicast promiscuous mode on VSI %i\n",
+			   vsi->vsi_num);
+		vsi->current_netdev_flags |= IFF_ALLMULTI;
+	}
+
 	vlan_ops = ice_get_compat_vsi_vlan_ops(vsi);
 
 	/* Make sure VLAN delete is successful before updating VLAN
-- 
1.8.3.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 0/3] ice: Fixes for double vlan promiscuous mode

[Petr Oros]

Grzegorz Siwik píše v Čt 07. 07. 2022 v 15:15 +0200:
> This series fixes known issues related to double vlan promiscuous
> mode.
> When at least two interfaces are bonded and a bridge is enabled on
> the
> bond, an error can occur when the bridge is removed and re-added. The
> reason for the error is because promiscuous mode was not fully
> cleared from
> the VLAN VSI in the hardware.
> Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
> This fix is needed because the driver could set promiscuous mode
> when it still has not cleared properly.
> Avoid enabling or disabling vlan 0 when trying to set promiscuous
> vlan mode if double vlan mode is enabled. This fix is needed
> because the driver tries to add the vlan 0 filter twice (once for
> inner and once for outer) when double VLAN mode is enabled.
> 
> Grzegorz Siwik (3):
>   ice: Fix double VLAN error when entering promisc mode
>   ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode
>   ice: Fix clearing of promisc mode with bridge over bond
> 
>  drivers/net/ethernet/intel/ice/ice_lib.c    |  8 +++++++-
>  drivers/net/ethernet/intel/ice/ice_main.c   | 13 ++++++++++++-
>  drivers/net/ethernet/intel/ice/ice_switch.c |  9 ++++++++-
>  3 files changed, 27 insertions(+), 3 deletions(-)
> 

Tested-by: Petr Oros <poros@redhat.com>

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 3/3] ice: Fix clearing of promisc mode with bridge over bond

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Grzegorz Siwik
> Sent: Thursday, July 7, 2022 6:46 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Siwik, Grzegorz
> <grzegorz.siwik@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1 3/3] ice: Fix clearing of promisc
> mode with bridge over bond
> 
> When at least two interfaces are bonded and a bridge is enabled on the
> bond, an error can occur when the bridge is removed and re-added. The
> reason for the error is because promiscuous mode was not fully cleared from
> the VLAN VSI in the hardware. With this change, promiscuous mode is
> properly removed when the bridge disconnects from bonding.
> 
> [ 1033.676359] bond1: link status definitely down for interface enp95s0f0,
> disabling it [ 1033.676366] bond1: making interface enp175s0f0 the new
> active one [ 1033.676369] device enp95s0f0 left promiscuous mode [
> 1033.676522] device enp175s0f0 entered promiscuous mode [ 1033.676901]
> ice 0000:af:00.0 enp175s0f0: Error setting Multicast promiscuous mode on VSI
> 6 [ 1041.795662] ice 0000:af:00.0 enp175s0f0: Error setting Multicast
> promiscuous mode on VSI 6 [ 1041.944826] bond1: link status definitely down
> for interface enp175s0f0, disabling it [ 1041.944874] device enp175s0f0 left
> promiscuous mode [ 1041.944918] bond1: now running without any active
> interface!
> 
> Fixes: c31af68a1b94 ("ice: Add outer_vlan_ops and VSI specific VLAN ops
> implementations")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> Co-developed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> Tested-by: Igor Raits <igor@gooddata.com>
> Link:
> https://lore.kernel.org/all/CAK8fFZ7m-
> KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c  |  8 +++++++-
> drivers/net/ethernet/intel/ice/ice_main.c | 13 ++++++++++++-
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 2/3] ice: Ignore ERR_ALREADY_EXISTS when setting promisc mode

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Grzegorz Siwik
> Sent: Thursday, July 7, 2022 6:46 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Siwik, Grzegorz <grzegorz.siwik@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1 2/3] ice: Ignore
> ERR_ALREADY_EXISTS when setting promisc mode
> 
> Ignore ERR_ALREADY_EXISTS error when setting promiscuous mode.
> This fix is needed because the driver could set promiscuous mode when it
> still has not cleared properly.
> Promiscuous mode could be set only once, so setting it second time will be
> rejected.
> 
> Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> Tested-by: Igor Raits <igor@gooddata.com>
> Link:
> https://lore.kernel.org/all/CAK8fFZ7m-
> KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> ---
>  drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Grzegorz Siwik
> Sent: Thursday, July 7, 2022 6:46 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: Siwik, Grzegorz <grzegorz.siwik@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error
> when entering promisc mode
> 
> Avoid enabling or disabling vlan 0 when trying to set promiscuous vlan mode
> if double vlan mode is enabled. This fix is needed because the driver tries to
> add the vlan 0 filter twice (once for inner and once for outer) when double
> VLAN mode is enabled. The filter program is rejected by the firmware when
> double vlan is enabled, because the promiscuous filter only needs to be set
> once.
> 
> This issue was missed in the initial implementation of double vlan mode.
> 
> Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> Tested-by: Igor Raits <igor@gooddata.com>
> Link:
> https://lore.kernel.org/all/CAK8fFZ7m-
> KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> ---
>  drivers/net/ethernet/intel/ice/ice_switch.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

I could still observe the issue when the ice driver has been removed from the system once after executing
creating bridge over bond and then double vlan
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode

[Petr Oros]

G, GurucharanX píše v Út 26. 07. 2022 v 05:33 +0000:
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On
> > Behalf Of
> > Grzegorz Siwik
> > Sent: Thursday, July 7, 2022 6:46 PM
> > To: intel-wired-lan@lists.osuosl.org
> > Cc: Siwik, Grzegorz <grzegorz.siwik@intel.com>
> > Subject: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN
> > error
> > when entering promisc mode
> > 
> > Avoid enabling or disabling vlan 0 when trying to set promiscuous
> > vlan mode
> > if double vlan mode is enabled. This fix is needed because the
> > driver tries to
> > add the vlan 0 filter twice (once for inner and once for outer)
> > when double
> > VLAN mode is enabled. The filter program is rejected by the
> > firmware when
> > double vlan is enabled, because the promiscuous filter only needs
> > to be set
> > once.
> > 
> > This issue was missed in the initial implementation of double vlan
> > mode.
> > 
> > Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> > Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> > Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> > Tested-by: Igor Raits <igor@gooddata.com>
> > Link:
> > https://lore.kernel.org/all/CAK8fFZ7m-
> > KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> > ---
> >  drivers/net/ethernet/intel/ice/ice_switch.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> 
> I could still observe the issue when the ice driver has been removed
> from the system once after executing
> creating bridge over bond and then double vlan

Hi,

Is it regression introduced by this patch or this fix is partial and
mentioned issue is unfixed regression from past. I asking because
promisc mode issues is very pain for us and in second case will be
(maybe) good to move this forward and mentioned issue will fix in next
patch.

Many thanks,
Petr

> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> 

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode

[Siwik, Grzegorz]

> G, GurucharanX píše v Út 26. 07. 2022 v 05:33 +0000:
> > 
> > 
> > > -----Original Message-----
> > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf 
> > > Of Grzegorz Siwik
> > > Sent: Thursday, July 7, 2022 6:46 PM
> > > To: intel-wired-lan@lists.osuosl.org
> > > Cc: Siwik, Grzegorz <grzegorz.siwik@intel.com>
> > > Subject: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN 
> > > error when entering promisc mode
> > > 
> > > Avoid enabling or disabling vlan 0 when trying to set promiscuous 
> > > vlan mode if double vlan mode is enabled. This fix is needed because 
> > > the driver tries to add the vlan 0 filter twice (once for inner and 
> > > once for outer) when double VLAN mode is enabled. The filter program 
> > > is rejected by the firmware when double vlan is enabled, because the 
> > > promiscuous filter only needs to be set once.
> > > 
> > > This issue was missed in the initial implementation of double vlan 
> > > mode.
> > > 
> > > Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous mode")
> > > Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> > > Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> > > Tested-by: Igor Raits <igor@gooddata.com>
> > > Link:
> > > https://lore.kernel.org/all/CAK8fFZ7m-
> > > KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> > > ---
> > >  drivers/net/ethernet/intel/ice/ice_switch.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > 
> > I could still observe the issue when the ice driver has been removed 
> > from the system once after executing creating bridge over bond and 
> > then double vlan
> 
> Hi,
> 
> Is it regression introduced by this patch or this fix is partial and mentioned issue is unfixed regression from past. I asking because promisc mode issues is very pain for us and in second case will be
> (maybe) good to move this forward and mentioned issue will fix in next patch.
> 
> Many thanks,
> Petr
Hi,
We are currently investigating what is wrong with that - it is possible that i have something missed in upstreaming one of these patches. 
We let know when we find what is wrong.

Best Regards,
Grzegorz

> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan@osuosl.org
> > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan 

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Re: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN error when entering promisc mode

[Siwik, Grzegorz]

> > G, GurucharanX píše v Út 26. 07. 2022 v 05:33 +0000:
> > > 
> > > 
> > > > -----Original Message-----
> > > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On 
> > > > Behalf Of Grzegorz Siwik
> > > > Sent: Thursday, July 7, 2022 6:46 PM
> > > > To: intel-wired-lan@lists.osuosl.org
> > > > Cc: Siwik, Grzegorz <grzegorz.siwik@intel.com>
> > > > Subject: [Intel-wired-lan] [PATCH net v1 1/3] ice: Fix double VLAN 
> > > > error when entering promisc mode
> > > > 
> > > > Avoid enabling or disabling vlan 0 when trying to set promiscuous 
> > > > vlan mode if double vlan mode is enabled. This fix is needed 
> > > > because the driver tries to add the vlan 0 filter twice (once for 
> > > > inner and once for outer) when double VLAN mode is enabled. The 
> > > > filter program is rejected by the firmware when double vlan is 
> > > > enabled, because the promiscuous filter only needs to be set once.
> > > > 
> > > > This issue was missed in the initial implementation of double vlan 
> > > > mode.
> > > > 
> > > > Fixes: 5eda8afd6bcc ("ice: Add support for PF/VF promiscuous 
> > > > mode")
> > > > Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> > > > Tested-by: Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>
> > > > Tested-by: Igor Raits <igor@gooddata.com>
> > > > Link:
> > > > https://lore.kernel.org/all/CAK8fFZ7m-
> > > > KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com/
> > > > ---
> > > >  drivers/net/ethernet/intel/ice/ice_switch.c | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > 
> > > I could still observe the issue when the ice driver has been removed 
> > > from the system once after executing creating bridge over bond and 
> > > then double vlan
> > 
> > Hi,
> > 
> > Is it regression introduced by this patch or this fix is partial and 
> > mentioned issue is unfixed regression from past. I asking because 
> > promisc mode issues is very pain for us and in second case will be
> > (maybe) good to move this forward and mentioned issue will fix in next patch.
> > 
> > Many thanks,
> > Petr
> Hi,
> We are currently investigating what is wrong with that - it is possible that i have something missed in upstreaming one of these patches. 
> We let know when we find what is wrong.
> 
> Best Regards,
> Grzegorz
Hi Guys,

We found what is wrong - we have not backported one of the patch from RedHat - so i didn't know that this problem could exist.
Soon we will send fix for reported issues.

Best Regards,
Grzegorz
> > > _______________________________________________
> > > Intel-wired-lan mailing list
> > > Intel-wired-lan@osuosl.org
> > > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan