All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support
@ 2022-07-13 10:06 Wolfram Sang
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Wolfram Sang @ 2022-07-13 10:06 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, devicetree, Geert Uytterhoeven, Laurent Pinchart,
	linux-kernel

These three patches update the bindings and the CMT driver for Renesas
R-Car Gen4 and the r8a779f0 SoC.

Wolfram Sang (3):
  dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT
    support
  dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  clocksource/drivers/sh_cmt: Add R-Car Gen4 support

 .../devicetree/bindings/timer/renesas,cmt.yaml     | 14 ++++++++++++--
 drivers/clocksource/sh_cmt.c                       |  8 ++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)

-- 
2.35.1


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-13 10:06 [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support Wolfram Sang
@ 2022-07-13 10:06 ` Wolfram Sang
  2022-07-15 22:35   ` Daniel Lezcano
                     ` (3 more replies)
  2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
  2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
  2 siblings, 4 replies; 15+ messages in thread
From: Wolfram Sang @ 2022-07-13 10:06 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Geert Uytterhoeven, Laurent Pinchart,
	linux-kernel, devicetree

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 53dd6d9f518f..7cc1ec4b4e38 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -83,6 +83,11 @@ properties:
               - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
           - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
 
+      - items:
+          - enum:
+              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
+
       - items:
           - enum:
               - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
@@ -100,6 +105,11 @@ properties:
               - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
+      - items:
+          - enum:
+              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
+
   reg:
     maxItems: 1
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  2022-07-13 10:06 [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support Wolfram Sang
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
@ 2022-07-13 10:06 ` Wolfram Sang
  2022-07-18 20:51   ` Rob Herring
                     ` (2 more replies)
  2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
  2 siblings, 3 replies; 15+ messages in thread
From: Wolfram Sang @ 2022-07-13 10:06 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Geert Uytterhoeven, Laurent Pinchart,
	linux-kernel, devicetree

Despite the name, R-Car V3U is the first member of the R-Car Gen4
family. Hence move its compatible value to the R-Car Gen4 section.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 7cc1ec4b4e38..433ddb49620c 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -80,11 +80,11 @@ properties:
               - renesas,r8a77980-cmt0     # 32-bit CMT0 on R-Car V3H
               - renesas,r8a77990-cmt0     # 32-bit CMT0 on R-Car E3
               - renesas,r8a77995-cmt0     # 32-bit CMT0 on R-Car D3
-              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
           - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
               - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
           - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
 
@@ -102,11 +102,11 @@ properties:
               - renesas,r8a77980-cmt1     # 48-bit CMT on R-Car V3H
               - renesas,r8a77990-cmt1     # 48-bit CMT on R-Car E3
               - renesas,r8a77995-cmt1     # 48-bit CMT on R-Car D3
-              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
               - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
           - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support
  2022-07-13 10:06 [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support Wolfram Sang
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
  2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
@ 2022-07-13 10:06 ` Wolfram Sang
  2022-07-19  8:04   ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  2 siblings, 2 replies; 15+ messages in thread
From: Wolfram Sang @ 2022-07-13 10:06 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Daniel Lezcano, Thomas Gleixner, linux-kernel

Add support for the R-Car Gen4 CMT types 0/1 which are the same as in
the previous two generations.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/clocksource/sh_cmt.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index dd0956ad969c..64dcb082d4cf 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -981,6 +981,14 @@ static const struct of_device_id sh_cmt_of_table[] __maybe_unused = {
 		.compatible = "renesas,rcar-gen3-cmt1",
 		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
 	},
+	{
+		.compatible = "renesas,rcar-gen4-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen4-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
@ 2022-07-15 22:35   ` Daniel Lezcano
  2022-07-19  8:51     ` Krzysztof Kozlowski
  2022-07-18 20:50   ` Rob Herring
                     ` (2 subsequent siblings)
  3 siblings, 1 reply; 15+ messages in thread
From: Daniel Lezcano @ 2022-07-15 22:35 UTC (permalink / raw)
  To: Wolfram Sang, linux-renesas-soc
  Cc: Thomas Gleixner, Rob Herring, Krzysztof Kozlowski,
	Geert Uytterhoeven, Laurent Pinchart, linux-kernel, devicetree

On 13/07/2022 12:06, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Krzysztof ?

> ---
>   .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> index 53dd6d9f518f..7cc1ec4b4e38 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> @@ -83,6 +83,11 @@ properties:
>                 - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
>             - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
>   
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> +
>         - items:
>             - enum:
>                 - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> @@ -100,6 +105,11 @@ properties:
>                 - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
>             - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
>   
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> +
>     reg:
>       maxItems: 1
>   


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
  2022-07-15 22:35   ` Daniel Lezcano
@ 2022-07-18 20:50   ` Rob Herring
  2022-07-19  7:57   ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  3 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-07-18 20:50 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Laurent Pinchart, linux-renesas-soc, Rob Herring,
	Krzysztof Kozlowski, Thomas Gleixner, Daniel Lezcano,
	Geert Uytterhoeven, linux-kernel, devicetree

On Wed, 13 Jul 2022 12:06:01 +0200, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  .../devicetree/bindings/timer/renesas,cmt.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
@ 2022-07-18 20:51   ` Rob Herring
  2022-07-19  7:58   ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  2 siblings, 0 replies; 15+ messages in thread
From: Rob Herring @ 2022-07-18 20:51 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Geert Uytterhoeven, Laurent Pinchart, Thomas Gleixner,
	linux-kernel, Daniel Lezcano, devicetree, Krzysztof Kozlowski,
	linux-renesas-soc, Rob Herring

On Wed, 13 Jul 2022 12:06:02 +0200, Wolfram Sang wrote:
> Despite the name, R-Car V3U is the first member of the R-Car Gen4
> family. Hence move its compatible value to the R-Car Gen4 section.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
  2022-07-15 22:35   ` Daniel Lezcano
  2022-07-18 20:50   ` Rob Herring
@ 2022-07-19  7:57   ` Geert Uytterhoeven
  2022-07-19 12:19     ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  3 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2022-07-19  7:57 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Geert Uytterhoeven, Laurent Pinchart,
	Linux Kernel Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Hi Wolfram,

On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> @@ -83,6 +83,11 @@ properties:
>                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
>            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
>
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> +
>        - items:
>            - enum:
>                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> @@ -100,6 +105,11 @@ properties:
>                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
>            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
>
> +      - items:
> +          - enum:
> +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> +
>    reg:
>      maxItems: 1

The above is correct, but you forgot to update the conditional sections
specifying the number of interrupts.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
  2022-07-18 20:51   ` Rob Herring
@ 2022-07-19  7:58   ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  2 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2022-07-19  7:58 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Geert Uytterhoeven, Laurent Pinchart,
	Linux Kernel Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Despite the name, R-Car V3U is the first member of the R-Car Gen4
> family. Hence move its compatible value to the R-Car Gen4 section.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support
  2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
@ 2022-07-19  8:04   ` Geert Uytterhoeven
  2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
  1 sibling, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2022-07-19  8:04 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Daniel Lezcano, Thomas Gleixner,
	Linux Kernel Mailing List

On Wed, Jul 13, 2022 at 12:07 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Add support for the R-Car Gen4 CMT types 0/1 which are the same as in
> the previous two generations.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-15 22:35   ` Daniel Lezcano
@ 2022-07-19  8:51     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-19  8:51 UTC (permalink / raw)
  To: Daniel Lezcano, Wolfram Sang, linux-renesas-soc
  Cc: Thomas Gleixner, Rob Herring, Krzysztof Kozlowski,
	Geert Uytterhoeven, Laurent Pinchart, linux-kernel, devicetree

On 16/07/2022 00:35, Daniel Lezcano wrote:
> On 13/07/2022 12:06, Wolfram Sang wrote:
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Krzysztof ?

You got now Rob's. :)


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-19  7:57   ` Geert Uytterhoeven
@ 2022-07-19 12:19     ` Geert Uytterhoeven
  0 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2022-07-19 12:19 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: Linux-Renesas, Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Geert Uytterhoeven, Laurent Pinchart,
	Linux Kernel Mailing List,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Hi Wolfram,

On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > @@ -83,6 +83,11 @@ properties:
> >                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> > +
> >        - items:
> >            - enum:
> >                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> > @@ -100,6 +105,11 @@ properties:
> >                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> > +
> >    reg:
> >      maxItems: 1
>
> The above is correct, but you forgot to update the conditional sections
> specifying the number of interrupts.

However, it would have been nice to adhere to the existing sort order
in the file... I will prepare a patch for both issues...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [tip: timers/core] clocksource/drivers/sh_cmt: Add R-Car Gen4 support
  2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
  2022-07-19  8:04   ` Geert Uytterhoeven
@ 2022-07-28 10:44   ` tip-bot2 for Wolfram Sang
  1 sibling, 0 replies; 15+ messages in thread
From: tip-bot2 for Wolfram Sang @ 2022-07-28 10:44 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Wolfram Sang, Daniel Lezcano, x86, linux-kernel

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     aa84506ea644d0952a75136dee7386cc54b234b0
Gitweb:        https://git.kernel.org/tip/aa84506ea644d0952a75136dee7386cc54b234b0
Author:        Wolfram Sang <wsa+renesas@sang-engineering.com>
AuthorDate:    Wed, 13 Jul 2022 12:06:03 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jul 2022 22:55:14 +02:00

clocksource/drivers/sh_cmt: Add R-Car Gen4 support

Add support for the R-Car Gen4 CMT types 0/1 which are the same as in
the previous two generations.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220713100603.3391-4-wsa+renesas@sang-engineering.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/sh_cmt.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index dd0956a..64dcb08 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -981,6 +981,14 @@ static const struct of_device_id sh_cmt_of_table[] __maybe_unused = {
 		.compatible = "renesas,rcar-gen3-cmt1",
 		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
 	},
+	{
+		.compatible = "renesas,rcar-gen4-cmt0",
+		.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2]
+	},
+	{
+		.compatible = "renesas,rcar-gen4-cmt1",
+		.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2]
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sh_cmt_of_table);

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [tip: timers/core] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4
  2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
  2022-07-18 20:51   ` Rob Herring
  2022-07-19  7:58   ` Geert Uytterhoeven
@ 2022-07-28 10:44   ` tip-bot2 for Wolfram Sang
  2 siblings, 0 replies; 15+ messages in thread
From: tip-bot2 for Wolfram Sang @ 2022-07-28 10:44 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Wolfram Sang, Rob Herring, Daniel Lezcano, x86, linux-kernel

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     bd0ed737d5fda2ec55f915ed2c4f586363f71129
Gitweb:        https://git.kernel.org/tip/bd0ed737d5fda2ec55f915ed2c4f586363f71129
Author:        Wolfram Sang <wsa+renesas@sang-engineering.com>
AuthorDate:    Wed, 13 Jul 2022 12:06:02 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jul 2022 22:55:14 +02:00

dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4

Despite the name, R-Car V3U is the first member of the R-Car Gen4
family. Hence move its compatible value to the R-Car Gen4 section.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220713100603.3391-3-wsa+renesas@sang-engineering.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 7cc1ec4..433ddb4 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -80,11 +80,11 @@ properties:
               - renesas,r8a77980-cmt0     # 32-bit CMT0 on R-Car V3H
               - renesas,r8a77990-cmt0     # 32-bit CMT0 on R-Car E3
               - renesas,r8a77995-cmt0     # 32-bit CMT0 on R-Car D3
-              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
           - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
               - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
           - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
 
@@ -102,11 +102,11 @@ properties:
               - renesas,r8a77980-cmt1     # 48-bit CMT on R-Car V3H
               - renesas,r8a77990-cmt1     # 48-bit CMT on R-Car E3
               - renesas,r8a77995-cmt1     # 48-bit CMT on R-Car D3
-              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
       - items:
           - enum:
+              - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
               - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
           - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
 

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [tip: timers/core] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support
  2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
                     ` (2 preceding siblings ...)
  2022-07-19  7:57   ` Geert Uytterhoeven
@ 2022-07-28 10:44   ` tip-bot2 for Wolfram Sang
  3 siblings, 0 replies; 15+ messages in thread
From: tip-bot2 for Wolfram Sang @ 2022-07-28 10:44 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Wolfram Sang, Rob Herring, Daniel Lezcano, x86, linux-kernel

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     525b296185b4b0abab0d35a7143fc5a99c385230
Gitweb:        https://git.kernel.org/tip/525b296185b4b0abab0d35a7143fc5a99c385230
Author:        Wolfram Sang <wsa+renesas@sang-engineering.com>
AuthorDate:    Wed, 13 Jul 2022 12:06:01 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jul 2022 22:55:14 +02:00

dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220713100603.3391-2-wsa+renesas@sang-engineering.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 Documentation/devicetree/bindings/timer/renesas,cmt.yaml | 10 +++++++-
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
index 53dd6d9..7cc1ec4 100644
--- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
@@ -85,6 +85,11 @@ properties:
 
       - items:
           - enum:
+              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
+
+      - items:
+          - enum:
               - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
               - renesas,r8a774b1-cmt1     # 48-bit CMT on RZ/G2N
               - renesas,r8a774c0-cmt1     # 48-bit CMT on RZ/G2E
@@ -100,6 +105,11 @@ properties:
               - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
           - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
 
+      - items:
+          - enum:
+              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
+          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
+
   reg:
     maxItems: 1
 

^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-07-28 10:44 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 10:06 [PATCH 0/3] clocksource: sh_cmt: add Gen4 and r8a779f0 support Wolfram Sang
2022-07-13 10:06 ` [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support Wolfram Sang
2022-07-15 22:35   ` Daniel Lezcano
2022-07-19  8:51     ` Krzysztof Kozlowski
2022-07-18 20:50   ` Rob Herring
2022-07-19  7:57   ` Geert Uytterhoeven
2022-07-19 12:19     ` Geert Uytterhoeven
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
2022-07-13 10:06 ` [PATCH 2/3] dt-bindings: timer: renesas,cmt: R-Car V3U is R-Car Gen4 Wolfram Sang
2022-07-18 20:51   ` Rob Herring
2022-07-19  7:58   ` Geert Uytterhoeven
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang
2022-07-13 10:06 ` [PATCH 3/3] clocksource/drivers/sh_cmt: Add R-Car Gen4 support Wolfram Sang
2022-07-19  8:04   ` Geert Uytterhoeven
2022-07-28 10:44   ` [tip: timers/core] " tip-bot2 for Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.