Re: [PATCH v9 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

From: Rob Herring <robh@kernel.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: dmitry.baryshkov@linaro.org, daniel@ffwll.ch,
	linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org,
	krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com,
	airlied@linux.ie, quic_sbillaka@quicinc.com,
	andersson@kernel.org, agross@kernel.org, sean@poorly.run,
	robh+dt@kernel.org, vkoul@kernel.org,
	konrad.dybcio@somainline.org, airlied@gmail.com,
	quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org,
	swboyd@chromium.org, devicetree@vger.kernel.org,
	dianders@chromium.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v9 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property
Date: Tue, 06 Dec 2022 06:47:26 -0600	[thread overview]
Message-ID: <167033052405.165993.699264089064134340.robh@kernel.org> (raw)
In-Reply-To: <1670281694-13281-3-git-send-email-quic_khsieh@quicinc.com>

On Mon, 05 Dec 2022 15:08:11 -0800, Kuogee Hsieh wrote:
> Add both data-lanes and link-frequencies property into endpoint
> 
> Changes in v7:
> -- split yaml out of dtsi patch
> -- link-frequencies from link rate to symbol rate
> -- deprecation of old data-lanes property
> 
> Changes in v8:
> -- correct Bjorn mail address to kernel.org
> 
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>`
> ---
>  Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/display/msm/dp-controller.example.dts'
Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: mapping values are not allowed here
make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/msm/dp-controller.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/display/msm/dp-controller.yaml:108:21: mapping values are not allowed here
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/msm/dp-controller.yaml: ignoring, error parsing file
make: *** [Makefile:1492: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1670281694-13281-3-git-send-email-quic_khsieh@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.