* [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h @ 2023-01-05 20:38 Nirmoy Das 2023-01-05 20:46 ` Dixit, Ashutosh ` (3 more replies) 0 siblings, 4 replies; 7+ messages in thread From: Nirmoy Das @ 2023-01-05 20:38 UTC (permalink / raw) To: intel-gfx; +Cc: Nirmoy Das, andrzej.hajda, chris.p.wilson Fix docs for __intel_wakeref_put() and intel_wakeref_get() to reflect current behaviour. Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> --- drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h index 4f4c2e15e736..71b8a63f6f10 100644 --- a/drivers/gpu/drm/i915/intel_wakeref.h +++ b/drivers/gpu/drm/i915/intel_wakeref.h @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); * @wf: the wakeref * * Acquire a hold on the wakeref. The first user to do so, will acquire - * the runtime pm wakeref and then call the @fn underneath the wakeref - * mutex. + * the runtime pm wakeref and then call the intel_wakeref_ops->get() + * underneath the wakeref mutex. * - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref - * will be released and the acquisition unwound, and an error reported. + * Note that intel_wakeref_ops->get() is allowed to fail, in which case + * the runtime-pm wakeref will be released and the acquisition unwound, + * and an error reported. * * Returns: 0 if the wakeref was acquired successfully, or a negative error * code otherwise. @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) } /** - * intel_wakeref_put_flags: Release the wakeref + * __intel_wakeref_put: Release the wakeref * @wf: the wakeref * @flags: control flags * * Release our hold on the wakeref. When there are no more users, - * the runtime pm wakeref will be released after the @fn callback is called - * underneath the wakeref mutex. + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() + * callback is called underneath the wakeref mutex. * - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref - * is retained and an error reported. + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the + * runtime-pm wakeref is retained. * - * Returns: 0 if the wakeref was released successfully, or a negative error - * code otherwise. */ static inline void __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) -- 2.38.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h 2023-01-05 20:38 [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h Nirmoy Das @ 2023-01-05 20:46 ` Dixit, Ashutosh 2023-01-06 13:06 ` Rodrigo Vivi 2023-01-05 22:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 3 siblings, 1 reply; 7+ messages in thread From: Dixit, Ashutosh @ 2023-01-05 20:46 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx, andrzej.hajda, chris.p.wilson On Thu, 05 Jan 2023 12:38:43 -0800, Nirmoy Das wrote: > > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > reflect current behaviour. Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > index 4f4c2e15e736..71b8a63f6f10 100644 > --- a/drivers/gpu/drm/i915/intel_wakeref.h > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); > * @wf: the wakeref > * > * Acquire a hold on the wakeref. The first user to do so, will acquire > - * the runtime pm wakeref and then call the @fn underneath the wakeref > - * mutex. > + * the runtime pm wakeref and then call the intel_wakeref_ops->get() > + * underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * will be released and the acquisition unwound, and an error reported. > + * Note that intel_wakeref_ops->get() is allowed to fail, in which case > + * the runtime-pm wakeref will be released and the acquisition unwound, > + * and an error reported. > * > * Returns: 0 if the wakeref was acquired successfully, or a negative error > * code otherwise. > @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > } > > /** > - * intel_wakeref_put_flags: Release the wakeref > + * __intel_wakeref_put: Release the wakeref > * @wf: the wakeref > * @flags: control flags > * > * Release our hold on the wakeref. When there are no more users, > - * the runtime pm wakeref will be released after the @fn callback is called > - * underneath the wakeref mutex. > + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() > + * callback is called underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * is retained and an error reported. > + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the > + * runtime-pm wakeref is retained. > * > - * Returns: 0 if the wakeref was released successfully, or a negative error > - * code otherwise. > */ > static inline void > __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) > -- > 2.38.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h 2023-01-05 20:46 ` Dixit, Ashutosh @ 2023-01-06 13:06 ` Rodrigo Vivi 0 siblings, 0 replies; 7+ messages in thread From: Rodrigo Vivi @ 2023-01-06 13:06 UTC (permalink / raw) To: Dixit, Ashutosh; +Cc: intel-gfx, chris.p.wilson, andrzej.hajda, Nirmoy Das On Thu, Jan 05, 2023 at 12:46:17PM -0800, Dixit, Ashutosh wrote: 11;rgb:0000/0000/0000> On Thu, 05 Jan 2023 12:38:43 -0800, Nirmoy Das wrote: > > > > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > > reflect current behaviour. > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> pushed, thanks for the patch and review > > > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > > --- > > drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- > > 1 file changed, 10 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > > index 4f4c2e15e736..71b8a63f6f10 100644 > > --- a/drivers/gpu/drm/i915/intel_wakeref.h > > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > > @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); > > * @wf: the wakeref > > * > > * Acquire a hold on the wakeref. The first user to do so, will acquire > > - * the runtime pm wakeref and then call the @fn underneath the wakeref > > - * mutex. > > + * the runtime pm wakeref and then call the intel_wakeref_ops->get() > > + * underneath the wakeref mutex. > > * > > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > > - * will be released and the acquisition unwound, and an error reported. > > + * Note that intel_wakeref_ops->get() is allowed to fail, in which case > > + * the runtime-pm wakeref will be released and the acquisition unwound, > > + * and an error reported. > > * > > * Returns: 0 if the wakeref was acquired successfully, or a negative error > > * code otherwise. > > @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > > } > > > > /** > > - * intel_wakeref_put_flags: Release the wakeref > > + * __intel_wakeref_put: Release the wakeref > > * @wf: the wakeref > > * @flags: control flags > > * > > * Release our hold on the wakeref. When there are no more users, > > - * the runtime pm wakeref will be released after the @fn callback is called > > - * underneath the wakeref mutex. > > + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() > > + * callback is called underneath the wakeref mutex. > > * > > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > > - * is retained and an error reported. > > + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the > > + * runtime-pm wakeref is retained. > > * > > - * Returns: 0 if the wakeref was released successfully, or a negative error > > - * code otherwise. > > */ > > static inline void > > __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) > > -- > > 2.38.0 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Update docs in intel_wakeref.h 2023-01-05 20:38 [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h Nirmoy Das 2023-01-05 20:46 ` Dixit, Ashutosh @ 2023-01-05 22:33 ` Patchwork 2023-01-06 12:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-01-09 13:57 ` [Intel-gfx] [PATCH] " Andi Shyti 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-01-05 22:33 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5378 bytes --] == Series Details == Series: drm/i915: Update docs in intel_wakeref.h URL : https://patchwork.freedesktop.org/series/112454/ State : success == Summary == CI Bug Log - changes from CI_DRM_12550 -> Patchwork_112454v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/index.html Participating hosts (43 -> 43) ------------------------------ Additional (2): fi-kbl-soraka fi-bsw-kefka Missing (2): fi-rkl-11600 fi-snb-2520m Known issues ------------ Here are the changes found in Patchwork_112454v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_gttfill@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +7 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html * igt@gem_huc_copy@huc-copy: - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#5334]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@late_gt_pm: - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][6] ([i915#7640]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@i915_selftest@live@late_gt_pm.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-bsw-kefka: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-bsw-kefka/igt@kms_chamelium@hdmi-hpd-fast.html - fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +7 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html * igt@prime_vgem@basic-fence-flip: - fi-bsw-kefka: NOTRUN -> [SKIP][9] ([fdo#109271]) +17 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/fi-bsw-kefka/igt@prime_vgem@basic-fence-flip.html #### Possible fixes #### * igt@i915_pm_rpm@basic-rte: - {bat-adln-1}: [DMESG-WARN][10] ([i915#7077]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/bat-adln-1/igt@i915_pm_rpm@basic-rte.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/bat-adln-1/igt@i915_pm_rpm@basic-rte.html * igt@i915_selftest@live@workarounds: - {bat-rpls-1}: [INCOMPLETE][12] -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/bat-rpls-1/igt@i915_selftest@live@workarounds.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/bat-rpls-1/igt@i915_selftest@live@workarounds.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997 [i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077 [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359 [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640 Build changes ------------- * Linux: CI_DRM_12550 -> Patchwork_112454v1 CI-20190529: 20190529 CI_DRM_12550: f604441f326ba242fc0b0f86dc2468863d204c97 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7110: db10a19b94d1d7ae5ba62eb48d52c47ccb27766f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_112454v1: f604441f326ba242fc0b0f86dc2468863d204c97 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits aa09995a1b0a drm/i915: Update docs in intel_wakeref.h == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/index.html [-- Attachment #2: Type: text/html, Size: 6050 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update docs in intel_wakeref.h 2023-01-05 20:38 [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h Nirmoy Das 2023-01-05 20:46 ` Dixit, Ashutosh 2023-01-05 22:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-01-06 12:02 ` Patchwork 2023-01-09 13:57 ` [Intel-gfx] [PATCH] " Andi Shyti 3 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-01-06 12:02 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 22604 bytes --] == Series Details == Series: drm/i915: Update docs in intel_wakeref.h URL : https://patchwork.freedesktop.org/series/112454/ State : success == Summary == CI Bug Log - changes from CI_DRM_12550_full -> Patchwork_112454v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/index.html Participating hosts (13 -> 10) ------------------------------ Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005 Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_112454v1_full: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_pm_rpm@drm-resources-equal: - {shard-tglu-9}: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-tglu-9/igt@i915_pm_rpm@drm-resources-equal.html Known issues ------------ Here are the changes found in Patchwork_112454v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-none@rcs0: - shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-glk6/igt@gem_exec_fair@basic-none@rcs0.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2: - shard-glk: [PASS][4] -> [FAIL][5] ([i915#79]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html #### Possible fixes #### * igt@core_auth@many-magics: - {shard-rkl}: [SKIP][6] ([i915#2575]) -> [PASS][7] +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@core_auth@many-magics.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@core_auth@many-magics.html * igt@device_reset@unbind-reset-rebind: - {shard-rkl}: [FAIL][8] ([i915#4778]) -> [PASS][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@device_reset@unbind-reset-rebind.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@device_reset@unbind-reset-rebind.html * igt@drm_fdinfo@virtual-idle: - {shard-rkl}: [FAIL][10] ([i915#7742]) -> [PASS][11] +1 similar issue [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-2/igt@drm_fdinfo@virtual-idle.html * igt@fbdev@unaligned-read: - {shard-rkl}: [SKIP][12] ([i915#2582]) -> [PASS][13] +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-2/igt@fbdev@unaligned-read.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@fbdev@unaligned-read.html * igt@gem_ctx_persistence@engines-hang@bcs0: - {shard-rkl}: [SKIP][14] ([i915#6252]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@gem_ctx_persistence@engines-hang@bcs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-1/igt@gem_ctx_persistence@engines-hang@bcs0.html * igt@gem_eio@suspend: - {shard-rkl}: [FAIL][16] ([i915#7052]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-4/igt@gem_eio@suspend.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-2/igt@gem_eio@suspend.html * igt@gem_exec_balancer@hog: - {shard-rkl}: [SKIP][18] ([fdo#109315]) -> [PASS][19] +6 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@gem_exec_balancer@hog.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@gem_exec_balancer@hog.html * igt@gem_exec_fair@basic-pace-share@rcs0: - {shard-rkl}: [FAIL][20] ([i915#2842]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-3/igt@gem_exec_fair@basic-pace-share@rcs0.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-glk1/igt@gem_exec_fair@basic-pace-solo@rcs0.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_reloc@basic-write-gtt: - {shard-rkl}: [SKIP][24] ([i915#3281]) -> [PASS][25] +7 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-3/igt@gem_exec_reloc@basic-write-gtt.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-5/igt@gem_exec_reloc@basic-write-gtt.html * igt@gem_set_tiling_vs_pwrite: - {shard-rkl}: [SKIP][26] ([i915#3282]) -> [PASS][27] +5 similar issues [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-3/igt@gem_set_tiling_vs_pwrite.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-5/igt@gem_set_tiling_vs_pwrite.html * igt@gen9_exec_parse@basic-rejected-ctx-param: - {shard-rkl}: [SKIP][28] ([i915#2527]) -> [PASS][29] +1 similar issue [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-6/igt@gen9_exec_parse@basic-rejected-ctx-param.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-5/igt@gen9_exec_parse@basic-rejected-ctx-param.html * igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a: - {shard-dg1}: [SKIP][30] ([i915#1937]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-dg1-17/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-dg1-14/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html * igt@i915_pm_rc6_residency@rc6-idle@rcs0: - {shard-dg1}: [FAIL][32] ([i915#3591]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-dg1-19/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-dg1-19/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html * igt@i915_pm_rpm@dpms-mode-unset-non-lpsp: - {shard-dg1}: [SKIP][34] ([i915#1397]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-dg1-14/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-dg1-15/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html * igt@i915_pm_rpm@modeset-lpsp: - {shard-rkl}: [SKIP][36] ([i915#1397]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_suspend@basic-s3-without-i915: - {shard-rkl}: [INCOMPLETE][38] ([i915#4817]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@i915_suspend@basic-s3-without-i915.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_big_fb@y-tiled-16bpp-rotate-0: - {shard-tglu}: [SKIP][40] ([i915#7651]) -> [PASS][41] +6 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-tglu-6/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-tglu-3/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs: - {shard-tglu}: [SKIP][42] ([i915#1845] / [i915#7651]) -> [PASS][43] +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-tglu-6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-tglu-3/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs.html * igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size: - shard-glk: [FAIL][44] ([i915#2346]) -> [PASS][45] +1 similar issue [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt: - {shard-rkl}: [SKIP][46] ([i915#1849] / [i915#4098]) -> [PASS][47] +15 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - {shard-tglu}: [SKIP][48] ([i915#1849]) -> [PASS][49] +3 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-tglu-3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_properties@plane-properties-legacy: - {shard-rkl}: [SKIP][50] ([i915#1849]) -> [PASS][51] +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-2/igt@kms_properties@plane-properties-legacy.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@kms_properties@plane-properties-legacy.html * igt@kms_psr@dpms: - {shard-rkl}: [SKIP][52] ([i915#1072]) -> [PASS][53] +1 similar issue [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-4/igt@kms_psr@dpms.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@kms_psr@dpms.html * igt@kms_universal_plane@cursor-fb-leak-pipe-d: - {shard-tglu}: [SKIP][54] ([fdo#109274]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-tglu-6/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-tglu-3/igt@kms_universal_plane@cursor-fb-leak-pipe-d.html * igt@kms_universal_plane@universal-plane-pipe-b-sanity: - {shard-rkl}: [SKIP][56] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-b-sanity.html * igt@kms_vblank@pipe-b-accuracy-idle: - {shard-dg1}: [DMESG-WARN][58] -> [PASS][59] +2 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-dg1-17/igt@kms_vblank@pipe-b-accuracy-idle.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-dg1-16/igt@kms_vblank@pipe-b-accuracy-idle.html * igt@kms_vblank@pipe-b-query-idle: - {shard-rkl}: [SKIP][60] ([i915#1845] / [i915#4098]) -> [PASS][61] +21 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-2/igt@kms_vblank@pipe-b-query-idle.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-6/igt@kms_vblank@pipe-b-query-idle.html * igt@perf@invalid-oa-exponent: - {shard-rkl}: [SKIP][62] ([i915#5608]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-rkl-5/igt@perf@invalid-oa-exponent.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-rkl-4/igt@perf@invalid-oa-exponent.html * igt@perf_pmu@module-unload: - {shard-dg1}: [DMESG-WARN][64] ([i915#4391]) -> [PASS][65] +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12550/shard-dg1-17/igt@perf_pmu@module-unload.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/shard-dg1-16/igt@perf_pmu@module-unload.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850 [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825 [i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281 [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334 [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037 [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 [i915#7678]: https://gitlab.freedesktop.org/drm/intel/issues/7678 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_12550 -> Patchwork_112454v1 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_12550: f604441f326ba242fc0b0f86dc2468863d204c97 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7110: db10a19b94d1d7ae5ba62eb48d52c47ccb27766f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_112454v1: f604441f326ba242fc0b0f86dc2468863d204c97 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112454v1/index.html [-- Attachment #2: Type: text/html, Size: 17654 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h 2023-01-05 20:38 [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h Nirmoy Das ` (2 preceding siblings ...) 2023-01-06 12:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2023-01-09 13:57 ` Andi Shyti 2023-01-10 10:10 ` Das, Nirmoy 3 siblings, 1 reply; 7+ messages in thread From: Andi Shyti @ 2023-01-09 13:57 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx, andrzej.hajda, chris.p.wilson Hi Nirmoy, On Thu, Jan 05, 2023 at 09:38:43PM +0100, Nirmoy Das wrote: > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > reflect current behaviour. > > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Thanks for adding also the change suggested by Ashutosh! Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi > --- > drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > index 4f4c2e15e736..71b8a63f6f10 100644 > --- a/drivers/gpu/drm/i915/intel_wakeref.h > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); > * @wf: the wakeref > * > * Acquire a hold on the wakeref. The first user to do so, will acquire > - * the runtime pm wakeref and then call the @fn underneath the wakeref > - * mutex. > + * the runtime pm wakeref and then call the intel_wakeref_ops->get() > + * underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * will be released and the acquisition unwound, and an error reported. > + * Note that intel_wakeref_ops->get() is allowed to fail, in which case > + * the runtime-pm wakeref will be released and the acquisition unwound, > + * and an error reported. > * > * Returns: 0 if the wakeref was acquired successfully, or a negative error > * code otherwise. > @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > } > > /** > - * intel_wakeref_put_flags: Release the wakeref > + * __intel_wakeref_put: Release the wakeref > * @wf: the wakeref > * @flags: control flags > * > * Release our hold on the wakeref. When there are no more users, > - * the runtime pm wakeref will be released after the @fn callback is called > - * underneath the wakeref mutex. > + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() > + * callback is called underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * is retained and an error reported. > + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the > + * runtime-pm wakeref is retained. > * > - * Returns: 0 if the wakeref was released successfully, or a negative error > - * code otherwise. > */ > static inline void > __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) > -- > 2.38.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h 2023-01-09 13:57 ` [Intel-gfx] [PATCH] " Andi Shyti @ 2023-01-10 10:10 ` Das, Nirmoy 0 siblings, 0 replies; 7+ messages in thread From: Das, Nirmoy @ 2023-01-10 10:10 UTC (permalink / raw) To: Andi Shyti; +Cc: intel-gfx, Nirmoy Das On 1/9/2023 2:57 PM, Andi Shyti wrote: > Hi Nirmoy, > > On Thu, Jan 05, 2023 at 09:38:43PM +0100, Nirmoy Das wrote: >> Fix docs for __intel_wakeref_put() and intel_wakeref_get() to >> reflect current behaviour. >> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > Thanks for adding also the change suggested by Ashutosh! > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks for reviewing it, Andi! Nirmoy > > Andi > >> --- >> drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- >> 1 file changed, 10 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h >> index 4f4c2e15e736..71b8a63f6f10 100644 >> --- a/drivers/gpu/drm/i915/intel_wakeref.h >> +++ b/drivers/gpu/drm/i915/intel_wakeref.h >> @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); >> * @wf: the wakeref >> * >> * Acquire a hold on the wakeref. The first user to do so, will acquire >> - * the runtime pm wakeref and then call the @fn underneath the wakeref >> - * mutex. >> + * the runtime pm wakeref and then call the intel_wakeref_ops->get() >> + * underneath the wakeref mutex. >> * >> - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref >> - * will be released and the acquisition unwound, and an error reported. >> + * Note that intel_wakeref_ops->get() is allowed to fail, in which case >> + * the runtime-pm wakeref will be released and the acquisition unwound, >> + * and an error reported. >> * >> * Returns: 0 if the wakeref was acquired successfully, or a negative error >> * code otherwise. >> @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) >> } >> >> /** >> - * intel_wakeref_put_flags: Release the wakeref >> + * __intel_wakeref_put: Release the wakeref >> * @wf: the wakeref >> * @flags: control flags >> * >> * Release our hold on the wakeref. When there are no more users, >> - * the runtime pm wakeref will be released after the @fn callback is called >> - * underneath the wakeref mutex. >> + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() >> + * callback is called underneath the wakeref mutex. >> * >> - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref >> - * is retained and an error reported. >> + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the >> + * runtime-pm wakeref is retained. >> * >> - * Returns: 0 if the wakeref was released successfully, or a negative error >> - * code otherwise. >> */ >> static inline void >> __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) >> -- >> 2.38.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-01-10 10:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-01-05 20:38 [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h Nirmoy Das 2023-01-05 20:46 ` Dixit, Ashutosh 2023-01-06 13:06 ` Rodrigo Vivi 2023-01-05 22:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-01-06 12:02 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-01-09 13:57 ` [Intel-gfx] [PATCH] " Andi Shyti 2023-01-10 10:10 ` Das, Nirmoy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.