* [PATCH] seccomp: fix kernel-doc function name warning
@ 2023-01-08 2:12 Randy Dunlap
2023-01-14 1:01 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-01-08 2:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Kees Cook, Andy Lutomirski, Will Drewry
Move the ACTION_ONLY() macro so that it is not between the kernel-doc
notation and the function definition for seccomp_run_filters(),
eliminating a kernel-doc warning:
kernel/seccomp.c:400: warning: expecting prototype for seccomp_run_filters(). Prototype was for ACTION_ONLY() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Will Drewry <wad@chromium.org>
---
kernel/seccomp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -- a/kernel/seccomp.c b/kernel/seccomp.c
--- a/kernel/seccomp.c
+++ b/kernel/seccomp.c
@@ -388,6 +388,7 @@ static inline bool seccomp_cache_check_a
}
#endif /* SECCOMP_ARCH_NATIVE */
+#define ACTION_ONLY(ret) ((s32)((ret) & (SECCOMP_RET_ACTION_FULL)))
/**
* seccomp_run_filters - evaluates all seccomp filters against @sd
* @sd: optional seccomp data to be passed to filters
@@ -397,7 +398,6 @@ static inline bool seccomp_cache_check_a
*
* Returns valid seccomp BPF response codes.
*/
-#define ACTION_ONLY(ret) ((s32)((ret) & (SECCOMP_RET_ACTION_FULL)))
static u32 seccomp_run_filters(const struct seccomp_data *sd,
struct seccomp_filter **match)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] seccomp: fix kernel-doc function name warning
2023-01-08 2:12 [PATCH] seccomp: fix kernel-doc function name warning Randy Dunlap
@ 2023-01-14 1:01 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2023-01-14 1:01 UTC (permalink / raw)
To: linux-kernel, rdunlap; +Cc: Kees Cook, luto, wad
On Sat, 7 Jan 2023 18:12:28 -0800, Randy Dunlap wrote:
> Move the ACTION_ONLY() macro so that it is not between the kernel-doc
> notation and the function definition for seccomp_run_filters(),
> eliminating a kernel-doc warning:
>
> kernel/seccomp.c:400: warning: expecting prototype for seccomp_run_filters(). Prototype was for ACTION_ONLY() instead
>
>
> [...]
Applied to for-next/seccomp, thanks!
[1/1] seccomp: fix kernel-doc function name warning
https://git.kernel.org/kees/c/0fb0624b15d2
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-14 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-08 2:12 [PATCH] seccomp: fix kernel-doc function name warning Randy Dunlap
2023-01-14 1:01 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.