All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: rockosov@gmail.com, mturquette@baylibre.com,
	martin.blumenstingl@googlemail.com, linux-clk@vger.kernel.org,
	linux-amlogic@lists.infradead.org, jbrunet@baylibre.com,
	kernel@sberdevices.ru, khilman@baylibre.com, sboyd@kernel.org,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	neil.armstrong@linaro.org, linux-kernel@vger.kernel.org,
	jian.hu@amlogic.com
Subject: Re: [PATCH v9 3/5] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 01 Mar 2023 13:47:42 -0600	[thread overview]
Message-ID: <167769997208.7087.5344356236212731922.robh@kernel.org> (raw)
In-Reply-To: <20230301183759.16163-4-ddrokosov@sberdevices.ru>


On Wed, 01 Mar 2023 21:37:57 +0300, Dmitry Rokosov wrote:
> Add the documentation for Amlogic A1 PLL clock driver, and A1 PLL
> clock controller bindings.
> Also include new A1 clock controller dt bindings to MAINTAINERS.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  .../bindings/clock/amlogic,a1-pll-clkc.yaml   | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  include/dt-bindings/clock/a1-pll-clkc.h       | 20 +++++++
>  3 files changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>  create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dts:18:18: fatal error: dt-bindings/clock/a1-clkc.h: No such file or directory
   18 |         #include <dt-bindings/clock/a1-clkc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230301183759.16163-4-ddrokosov@sberdevices.ru

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: rockosov@gmail.com, mturquette@baylibre.com,
	martin.blumenstingl@googlemail.com, linux-clk@vger.kernel.org,
	linux-amlogic@lists.infradead.org, jbrunet@baylibre.com,
	kernel@sberdevices.ru, khilman@baylibre.com, sboyd@kernel.org,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	neil.armstrong@linaro.org, linux-kernel@vger.kernel.org,
	jian.hu@amlogic.com
Subject: Re: [PATCH v9 3/5] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 01 Mar 2023 13:47:42 -0600	[thread overview]
Message-ID: <167769997208.7087.5344356236212731922.robh@kernel.org> (raw)
In-Reply-To: <20230301183759.16163-4-ddrokosov@sberdevices.ru>


On Wed, 01 Mar 2023 21:37:57 +0300, Dmitry Rokosov wrote:
> Add the documentation for Amlogic A1 PLL clock driver, and A1 PLL
> clock controller bindings.
> Also include new A1 clock controller dt bindings to MAINTAINERS.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  .../bindings/clock/amlogic,a1-pll-clkc.yaml   | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  include/dt-bindings/clock/a1-pll-clkc.h       | 20 +++++++
>  3 files changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>  create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dts:18:18: fatal error: dt-bindings/clock/a1-clkc.h: No such file or directory
   18 |         #include <dt-bindings/clock/a1-clkc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230301183759.16163-4-ddrokosov@sberdevices.ru

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: rockosov@gmail.com, mturquette@baylibre.com,
	martin.blumenstingl@googlemail.com, linux-clk@vger.kernel.org,
	linux-amlogic@lists.infradead.org, jbrunet@baylibre.com,
	kernel@sberdevices.ru, khilman@baylibre.com, sboyd@kernel.org,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	neil.armstrong@linaro.org, linux-kernel@vger.kernel.org,
	jian.hu@amlogic.com
Subject: Re: [PATCH v9 3/5] dt-bindings: clock: meson: add A1 PLL clock controller bindings
Date: Wed, 01 Mar 2023 13:47:42 -0600	[thread overview]
Message-ID: <167769997208.7087.5344356236212731922.robh@kernel.org> (raw)
In-Reply-To: <20230301183759.16163-4-ddrokosov@sberdevices.ru>


On Wed, 01 Mar 2023 21:37:57 +0300, Dmitry Rokosov wrote:
> Add the documentation for Amlogic A1 PLL clock driver, and A1 PLL
> clock controller bindings.
> Also include new A1 clock controller dt bindings to MAINTAINERS.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
>  .../bindings/clock/amlogic,a1-pll-clkc.yaml   | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  include/dt-bindings/clock/a1-pll-clkc.h       | 20 +++++++
>  3 files changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
>  create mode 100644 include/dt-bindings/clock/a1-pll-clkc.h
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dts:18:18: fatal error: dt-bindings/clock/a1-clkc.h: No such file or directory
   18 |         #include <dt-bindings/clock/a1-clkc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1508: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230301183759.16163-4-ddrokosov@sberdevices.ru

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-01 19:47 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 18:37 [PATCH v9 0/5] add Amlogic A1 clock controller drivers Dmitry Rokosov
2023-03-01 18:37 ` Dmitry Rokosov
2023-03-01 18:37 ` Dmitry Rokosov
2023-03-01 18:37 ` [PATCH v9 1/5] clk: meson: add support for A1 PLL clock ops Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-06 11:09   ` Jerome Brunet
2023-03-06 11:09     ` Jerome Brunet
2023-03-06 11:09     ` Jerome Brunet
2023-03-06 20:12     ` Dmitry Rokosov
2023-03-06 20:12       ` Dmitry Rokosov
2023-03-06 20:12       ` Dmitry Rokosov
2023-03-01 18:37 ` [PATCH v9 2/5] clk: meson: a1: add Amlogic A1 PLL clock controller driver Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-02 10:02   ` kernel test robot
2023-03-02 10:02     ` kernel test robot
2023-03-02 10:02     ` kernel test robot
2023-03-06 11:17   ` Jerome Brunet
2023-03-06 11:17     ` Jerome Brunet
2023-03-06 11:17     ` Jerome Brunet
2023-03-06 20:05     ` Dmitry Rokosov
2023-03-06 20:05       ` Dmitry Rokosov
2023-03-06 20:05       ` Dmitry Rokosov
2023-03-09 14:20       ` Jerome Brunet
2023-03-09 14:20         ` Jerome Brunet
2023-03-09 14:20         ` Jerome Brunet
2023-03-09 18:28         ` Dmitry Rokosov
2023-03-09 18:28           ` Dmitry Rokosov
2023-03-09 18:28           ` Dmitry Rokosov
2023-03-13  9:18           ` Jerome Brunet
2023-03-13  9:18             ` Jerome Brunet
2023-03-13  9:18             ` Jerome Brunet
2023-03-13 10:25             ` Dmitry Rokosov
2023-03-13 10:25               ` Dmitry Rokosov
2023-03-13 10:25               ` Dmitry Rokosov
2023-03-01 18:37 ` [PATCH v9 3/5] dt-bindings: clock: meson: add A1 PLL clock controller bindings Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 19:47   ` Rob Herring [this message]
2023-03-01 19:47     ` Rob Herring
2023-03-01 19:47     ` Rob Herring
2023-03-03  8:28   ` Krzysztof Kozlowski
2023-03-03  8:28     ` Krzysztof Kozlowski
2023-03-03  8:28     ` Krzysztof Kozlowski
2023-03-03  9:11     ` Dmitry Rokosov
2023-03-03  9:11       ` Dmitry Rokosov
2023-03-03  9:11       ` Dmitry Rokosov
2023-03-06 11:33   ` Jerome Brunet
2023-03-06 11:33     ` Jerome Brunet
2023-03-06 11:33     ` Jerome Brunet
2023-03-06 19:07     ` Dmitry Rokosov
2023-03-06 19:07       ` Dmitry Rokosov
2023-03-06 19:07       ` Dmitry Rokosov
2023-03-01 18:37 ` [PATCH v9 4/5] clk: meson: a1: add Amlogic A1 Peripherals clock controller driver Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-06 11:38   ` Jerome Brunet
2023-03-06 11:38     ` Jerome Brunet
2023-03-06 11:38     ` Jerome Brunet
2023-03-06 19:05     ` Dmitry Rokosov
2023-03-06 19:05       ` Dmitry Rokosov
2023-03-06 19:05       ` Dmitry Rokosov
2023-03-09 14:22       ` Jerome Brunet
2023-03-09 14:22         ` Jerome Brunet
2023-03-09 14:22         ` Jerome Brunet
2023-03-09 18:58         ` Dmitry Rokosov
2023-03-09 18:58           ` Dmitry Rokosov
2023-03-09 18:58           ` Dmitry Rokosov
2023-03-01 18:37 ` [PATCH v9 5/5] dt-bindings: clock: meson: add A1 Peripherals clock controller bindings Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 18:37   ` Dmitry Rokosov
2023-03-01 19:47   ` Rob Herring
2023-03-01 19:47     ` Rob Herring
2023-03-01 19:47     ` Rob Herring
2023-03-03  8:29   ` Krzysztof Kozlowski
2023-03-03  8:29     ` Krzysztof Kozlowski
2023-03-03  8:29     ` Krzysztof Kozlowski
2023-03-03  9:14     ` Dmitry Rokosov
2023-03-03  9:14       ` Dmitry Rokosov
2023-03-03  9:14       ` Dmitry Rokosov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167769997208.7087.5344356236212731922.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=ddrokosov@sberdevices.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jian.hu@amlogic.com \
    --cc=kernel@sberdevices.ru \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.