All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: How to create IRQ mappings in a GPIO driver that doesn't control its IRQ domain ?
Date: Thu, 25 Jul 2013 15:22:29 +0200	[thread overview]
Message-ID: <1681089.qGWOhLKTTo@avalon> (raw)
In-Reply-To: <20130725131556.GD9858@sirena.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

Hi Mark,

On Thursday 25 July 2013 14:15:56 Mark Brown wrote:
> On Thu, Jul 25, 2013 at 11:45:33AM +0200, Laurent Pinchart wrote:
> > The two devices are independent, so there's no real parent/child
> > relationship. However, as Grant proposed, I could list all the interrupts
> > associated with GPIOs in the GPIO controller DT node. I would then just
> > call irq_of_parse_and_map() in the .to_irq() handler to magically
> > translate the GPIO number to a mapped IRQ number.
> > 
> > The number of interrupts can be pretty high (up to 58 in the worst case so
> > far), so an alternative would be to specify the interrupt-parent only, and
> > call irq_create_of_mapping() directly. What solution would you prefer ?
> 
> Are the interrupts in a contiguous block in the controller so you can just
> pass around the controller and a base number?

In two of the three SoCs I need to fix they are. I've just realized that in 
the last one the interrupts are in two contiguous blocks in two different 
parents. I will thus need at least a list of <parent-phandle base count>. Our 
standard interrupt bindings don't seem to support multiple parents, is that 
something that we want to fix or should I go for custom bindings ?

-- 
Regards,

Laurent Pinchart

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: How to create IRQ mappings in a GPIO driver that doesn't control its IRQ domain ?
Date: Thu, 25 Jul 2013 15:22:29 +0200	[thread overview]
Message-ID: <1681089.qGWOhLKTTo@avalon> (raw)
In-Reply-To: <20130725131556.GD9858@sirena.org.uk>

Hi Mark,

On Thursday 25 July 2013 14:15:56 Mark Brown wrote:
> On Thu, Jul 25, 2013 at 11:45:33AM +0200, Laurent Pinchart wrote:
> > The two devices are independent, so there's no real parent/child
> > relationship. However, as Grant proposed, I could list all the interrupts
> > associated with GPIOs in the GPIO controller DT node. I would then just
> > call irq_of_parse_and_map() in the .to_irq() handler to magically
> > translate the GPIO number to a mapped IRQ number.
> > 
> > The number of interrupts can be pretty high (up to 58 in the worst case so
> > far), so an alternative would be to specify the interrupt-parent only, and
> > call irq_create_of_mapping() directly. What solution would you prefer ?
> 
> Are the interrupts in a contiguous block in the controller so you can just
> pass around the controller and a base number?

In two of the three SoCs I need to fix they are. I've just realized that in 
the last one the interrupts are in two contiguous blocks in two different 
parents. I will thus need at least a list of <parent-phandle base count>. Our 
standard interrupt bindings don't seem to support multiple parents, is that 
something that we want to fix or should I go for custom bindings ?

-- 
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130725/be41a24f/attachment.sig>

  parent reply	other threads:[~2013-07-25 13:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-23 23:21 How to create IRQ mappings in a GPIO driver that doesn't control its IRQ domain ? Laurent Pinchart
2013-07-23 23:21 ` Laurent Pinchart
2013-07-24 20:24 ` Grant Likely
2013-07-24 20:24   ` Grant Likely
2013-07-25  9:42   ` Laurent Pinchart
2013-07-25  9:42     ` Laurent Pinchart
2013-07-25  9:20 ` Linus Walleij
2013-07-25  9:20   ` Linus Walleij
2013-07-25  9:45   ` Laurent Pinchart
2013-07-25  9:45     ` Laurent Pinchart
2013-07-25 13:15     ` Mark Brown
2013-07-25 13:15       ` Mark Brown
2013-07-25 13:21       ` Linus Walleij
2013-07-25 13:21         ` Linus Walleij
2013-07-25 13:53         ` Mark Brown
2013-07-25 13:53           ` Mark Brown
2013-07-25 13:22       ` Laurent Pinchart [this message]
2013-07-25 13:22         ` Laurent Pinchart
2013-07-25 13:55         ` Mark Brown
2013-07-25 13:55           ` Mark Brown
2013-07-28  5:00         ` Grant Likely
2013-07-28  5:00           ` Grant Likely
2013-07-31 11:14           ` Laurent Pinchart
2013-07-31 11:14             ` Laurent Pinchart
2013-07-25 13:19     ` Linus Walleij
2013-07-25 13:19       ` Linus Walleij
2013-07-28 10:07 ` Tomasz Figa
2013-07-28 10:07   ` Tomasz Figa
2013-07-31 11:11   ` Laurent Pinchart
2013-07-31 11:11     ` Laurent Pinchart
2013-07-31 11:29     ` Tomasz Figa
2013-07-31 11:29       ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1681089.qGWOhLKTTo@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=benh@kernel.crashing.org \
    --cc=broonie@kernel.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=grant.likely@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.