All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Tony Dinh <mibodhi@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Date: Wed, 12 Apr 2023 07:36:56 -0500	[thread overview]
Message-ID: <168130276446.1439316.3427548118074442016.robh@kernel.org> (raw)
In-Reply-To: <20230412025737.20280-2-mibodhi@gmail.com>


On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote:
> Add device tree binding for Marvell Armada 38x.
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> ---
> 
> Changes in v2:
> - Add marvell,38x.yaml. For now, add this binding to the Marvell
> directory to keep it consistent with other Marvell yaml files.
> At a later date and a separate patch, consolidate the Marvell
> yaml files into  marvell.yaml.
> 
>  .../bindings/arm/marvell/armada-38x.yaml      | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tony Dinh <mibodhi@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x
Date: Wed, 12 Apr 2023 07:36:56 -0500	[thread overview]
Message-ID: <168130276446.1439316.3427548118074442016.robh@kernel.org> (raw)
In-Reply-To: <20230412025737.20280-2-mibodhi@gmail.com>


On Tue, 11 Apr 2023 19:57:35 -0700, Tony Dinh wrote:
> Add device tree binding for Marvell Armada 38x.
> 
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> ---
> 
> Changes in v2:
> - Add marvell,38x.yaml. For now, add this binding to the Marvell
> directory to keep it consistent with other Marvell yaml files.
> At a later date and a separate patch, consolidate the Marvell
> yaml files into  marvell.yaml.
> 
>  .../bindings/arm/marvell/armada-38x.yaml      | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412025737.20280-2-mibodhi@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-04-12 12:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  2:57 [PATCH v2 0/2] Add support for Thecus N2350 board Tony Dinh
2023-04-12  2:57 ` Tony Dinh
2023-04-12  2:57 ` [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x Tony Dinh
2023-04-12  2:57   ` Tony Dinh
2023-04-12  7:13   ` Krzysztof Kozlowski
2023-04-12  7:13     ` Krzysztof Kozlowski
2023-04-12 12:36   ` Rob Herring [this message]
2023-04-12 12:36     ` Rob Herring
2023-04-12 19:05     ` Tony Dinh
2023-04-12 19:05       ` Tony Dinh
2023-04-13  7:51       ` Krzysztof Kozlowski
2023-04-13  7:51         ` Krzysztof Kozlowski
2023-04-13 19:12         ` Tony Dinh
2023-04-13 19:12           ` Tony Dinh
2023-05-01 22:46     ` Tony Dinh
2023-05-01 22:46       ` Tony Dinh
2023-05-02  6:54       ` Krzysztof Kozlowski
2023-05-02  6:54         ` Krzysztof Kozlowski
2023-04-12  2:57 ` [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS Tony Dinh
2023-04-12  2:57   ` Tony Dinh
2023-04-12 12:24   ` Andrew Lunn
2023-04-12 12:24     ` Andrew Lunn
2023-04-12 18:50     ` Tony Dinh
2023-04-12 18:50       ` Tony Dinh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168130276446.1439316.3427548118074442016.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mibodhi@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.