All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Tony Dinh <mibodhi@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	linux-kernel@vger.kernel.org, soc@kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
Date: Wed, 12 Apr 2023 14:24:37 +0200	[thread overview]
Message-ID: <eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch> (raw)
In-Reply-To: <20230412025737.20280-3-mibodhi@gmail.com>

> +
> +/ {
> +	model = "Thecus N2350";
> +	compatible = "marvell,armada385";

If you look at all the other armarda-385 .dts files, they all have a
board compatible. It might not be needed now, but it could be useful
in the future and allow backwards compatibility.

> +&mdio {
> +	phy0: ethernet-phy@0 {
> +		reg = <1>;
> +	};
> +};

Since you have ref = <1>, this should be ethernet-phy@1.


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Tony Dinh <mibodhi@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	linux-kernel@vger.kernel.org, soc@kernel.org
Subject: Re: [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS
Date: Wed, 12 Apr 2023 14:24:37 +0200	[thread overview]
Message-ID: <eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch> (raw)
In-Reply-To: <20230412025737.20280-3-mibodhi@gmail.com>

> +
> +/ {
> +	model = "Thecus N2350";
> +	compatible = "marvell,armada385";

If you look at all the other armarda-385 .dts files, they all have a
board compatible. It might not be needed now, but it could be useful
in the future and allow backwards compatibility.

> +&mdio {
> +	phy0: ethernet-phy@0 {
> +		reg = <1>;
> +	};
> +};

Since you have ref = <1>, this should be ethernet-phy@1.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-04-12 12:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  2:57 [PATCH v2 0/2] Add support for Thecus N2350 board Tony Dinh
2023-04-12  2:57 ` Tony Dinh
2023-04-12  2:57 ` [PATCH v2 1/2] ARM: dts: mvebu: Add device tree binding for Marvell Armada 38x Tony Dinh
2023-04-12  2:57   ` Tony Dinh
2023-04-12  7:13   ` Krzysztof Kozlowski
2023-04-12  7:13     ` Krzysztof Kozlowski
2023-04-12 12:36   ` Rob Herring
2023-04-12 12:36     ` Rob Herring
2023-04-12 19:05     ` Tony Dinh
2023-04-12 19:05       ` Tony Dinh
2023-04-13  7:51       ` Krzysztof Kozlowski
2023-04-13  7:51         ` Krzysztof Kozlowski
2023-04-13 19:12         ` Tony Dinh
2023-04-13 19:12           ` Tony Dinh
2023-05-01 22:46     ` Tony Dinh
2023-05-01 22:46       ` Tony Dinh
2023-05-02  6:54       ` Krzysztof Kozlowski
2023-05-02  6:54         ` Krzysztof Kozlowski
2023-04-12  2:57 ` [PATCH v2 2/2] ARM: dts: mvebu: add Thecus N2350 board DTS Tony Dinh
2023-04-12  2:57   ` Tony Dinh
2023-04-12 12:24   ` Andrew Lunn [this message]
2023-04-12 12:24     ` Andrew Lunn
2023-04-12 18:50     ` Tony Dinh
2023-04-12 18:50       ` Tony Dinh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eddb141e-6a8a-4473-b5e4-2e043d6f5197@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mibodhi@gmail.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.