[PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn

[PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn

[Shannon Nelson]

From: Nitya Sunkad <nitya.sunkad@amd.com>

Remove unnecessary early code development check and the WARN_ON
that it uses.  The irq alloc and free paths have long been
cleaned up and this check shouldn't have stuck around so long.

Fixes: 77ceb68e29cc ("ionic: Add notifyq support")
Signed-off-by: Nitya Sunkad <nitya.sunkad@amd.com>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
v2:
- Remove unnecessary n_qcq->flags & IONIC_QCQ_F_INTR check from early
  development

 drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
index 7c20a44e549b..612b0015dc43 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
@@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)
 static void ionic_link_qcq_interrupts(struct ionic_qcq *src_qcq,
 				      struct ionic_qcq *n_qcq)
 {
-	if (WARN_ON(n_qcq->flags & IONIC_QCQ_F_INTR)) {
-		ionic_intr_free(n_qcq->cq.lif->ionic, n_qcq->intr.index);
-		n_qcq->flags &= ~IONIC_QCQ_F_INTR;
-	}
-
 	n_qcq->intr.vector = src_qcq->intr.vector;
 	n_qcq->intr.index = src_qcq->intr.index;
 	n_qcq->napi_qcq = src_qcq->napi_qcq;
-- 
2.17.1

Re: [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn

[Jacob Keller]

On 7/6/2023 11:20 AM, Shannon Nelson wrote:
> From: Nitya Sunkad <nitya.sunkad@amd.com>
> 
> Remove unnecessary early code development check and the WARN_ON
> that it uses.  The irq alloc and free paths have long been
> cleaned up and this check shouldn't have stuck around so long.
> 
> Fixes: 77ceb68e29cc ("ionic: Add notifyq support")
> Signed-off-by: Nitya Sunkad <nitya.sunkad@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
> v2:
> - Remove unnecessary n_qcq->flags & IONIC_QCQ_F_INTR check from early
>   development
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

>  drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 7c20a44e549b..612b0015dc43 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)
>  static void ionic_link_qcq_interrupts(struct ionic_qcq *src_qcq,
>  				      struct ionic_qcq *n_qcq)
>  {
> -	if (WARN_ON(n_qcq->flags & IONIC_QCQ_F_INTR)) {
> -		ionic_intr_free(n_qcq->cq.lif->ionic, n_qcq->intr.index);
> -		n_qcq->flags &= ~IONIC_QCQ_F_INTR;
> -	}
> -
>  	n_qcq->intr.vector = src_qcq->intr.vector;
>  	n_qcq->intr.index = src_qcq->intr.index;
>  	n_qcq->napi_qcq = src_qcq->napi_qcq;

Re: [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 6 Jul 2023 11:20:06 -0700 you wrote:
> From: Nitya Sunkad <nitya.sunkad@amd.com>
> 
> Remove unnecessary early code development check and the WARN_ON
> that it uses.  The irq alloc and free paths have long been
> cleaned up and this check shouldn't have stuck around so long.
> 
> Fixes: 77ceb68e29cc ("ionic: Add notifyq support")
> Signed-off-by: Nitya Sunkad <nitya.sunkad@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> 
> [...]

Here is the summary with links:
  - [v2,net] ionic: remove WARN_ON to prevent panic_on_warn
    https://git.kernel.org/netdev/net/c/abfb2a58a537

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html