All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Tomislav Novak <tnovak@meta.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Samuel Gosselin <sgosselin@google.com>
Subject: Re: [PATCH v2] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
Date: Fri, 18 Aug 2023 19:04:10 +0100	[thread overview]
Message-ID: <169237465034.1400900.4830514571452045431.b4-ty@kernel.org> (raw)
In-Reply-To: <20230605191923.1219974-1-tnovak@meta.com>

On Mon, 5 Jun 2023 12:19:23 -0700, Tomislav Novak wrote:
> Arm platforms use is_default_overflow_handler() to determine if the
> hw_breakpoint code should single-step over the breakpoint trigger or
> let the custom handler deal with it.
> 
> Since bpf_overflow_handler() currently isn't recognized as a default
> handler, attaching a BPF program to a PERF_TYPE_BREAKPOINT event causes
> it to keep firing (the instruction triggering the data abort exception
> is never skipped). For example:
> 
> [...]

Applied to will (for-next/perf), thanks!

[1/1] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
      https://git.kernel.org/will/c/d11a69873d9a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Tomislav Novak <tnovak@meta.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Samuel Gosselin <sgosselin@google.com>
Subject: Re: [PATCH v2] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
Date: Fri, 18 Aug 2023 19:04:10 +0100	[thread overview]
Message-ID: <169237465034.1400900.4830514571452045431.b4-ty@kernel.org> (raw)
In-Reply-To: <20230605191923.1219974-1-tnovak@meta.com>

On Mon, 5 Jun 2023 12:19:23 -0700, Tomislav Novak wrote:
> Arm platforms use is_default_overflow_handler() to determine if the
> hw_breakpoint code should single-step over the breakpoint trigger or
> let the custom handler deal with it.
> 
> Since bpf_overflow_handler() currently isn't recognized as a default
> handler, attaching a BPF program to a PERF_TYPE_BREAKPOINT event causes
> it to keep firing (the instruction triggering the data abort exception
> is never skipped). For example:
> 
> [...]

Applied to will (for-next/perf), thanks!

[1/1] hw_breakpoint: fix single-stepping when using bpf_overflow_handler
      https://git.kernel.org/will/c/d11a69873d9a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-08-18 18:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 20:36 [PATCH] hw_breakpoint: fix single-stepping when using bpf_overflow_handler Tomislav Novak
2022-09-23 20:36 ` Tomislav Novak
2022-10-12 15:40 ` Tomislav Novak
2022-10-12 15:40   ` Tomislav Novak
2022-11-15 15:09 ` Catalin Marinas
2022-11-15 15:09   ` Catalin Marinas
2022-11-28 11:59   ` Tomislav Novak
2022-11-28 11:59     ` Tomislav Novak
2022-11-30 10:51     ` Catalin Marinas
2022-11-30 10:51       ` Catalin Marinas
2022-11-30 12:08       ` Tomislav Novak
2022-11-30 12:08         ` Tomislav Novak
2023-06-05 19:16       ` Tomislav Novak
2023-06-05 19:16         ` Tomislav Novak
2023-06-05 19:19         ` [PATCH v2] " Tomislav Novak
2023-06-05 19:19           ` Tomislav Novak
2023-08-18 18:04           ` Will Deacon [this message]
2023-08-18 18:04             ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169237465034.1400900.4830514571452045431.b4-ty@kernel.org \
    --to=will@kernel.org \
    --cc=ast@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=sgosselin@google.com \
    --cc=tnovak@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.