From: Rob Herring <robh@kernel.org>
To: Tanmay Shah <tanmay.shah@amd.com>
Cc: Ben Levinsky <ben.levinsky@amd.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings
Date: Wed, 30 Aug 2023 13:16:21 -0500 [thread overview]
Message-ID: <169341938045.463502.9445399366399743283.robh@kernel.org> (raw)
In-Reply-To: <20230829181900.2561194-2-tanmay.shah@amd.com>
On Tue, 29 Aug 2023 11:18:58 -0700, Tanmay Shah wrote:
> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>
> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
> UltraScale+ platform. It will help in defining TCM in device-tree
> and make it's access platform agnostic and data-driven.
>
> Tightly-coupled memories(TCMs) are low-latency memory that provides
> predictable instruction execution and predictable data load/store
> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>
> The TCM resources(reg, reg-names and power-domain) are documented for
> each TCM in the R5 node. The reg and reg-names are made as required
> properties as we don't want to hardcode TCM addresses for future
> platforms and for zu+ legacy implementation will ensure that the
> old dts w/o reg/reg-names works and stable ABI is maintained.
>
> It also extends the examples for TCM split and lockstep modes.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>
> Changes in v4:
> - Use address-cells and size-cells value 2
> - Modify ranges property as per new value of address-cells
> and size-cells
> - Modify child node "reg" property accordingly
> - Remove previous ack for further review
>
>
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 131 +++++++++++++++---
> 1 file changed, 113 insertions(+), 18 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tanmay Shah <tanmay.shah@amd.com>
Cc: Ben Levinsky <ben.levinsky@amd.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Simek <michal.simek@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings
Date: Wed, 30 Aug 2023 13:16:21 -0500 [thread overview]
Message-ID: <169341938045.463502.9445399366399743283.robh@kernel.org> (raw)
In-Reply-To: <20230829181900.2561194-2-tanmay.shah@amd.com>
On Tue, 29 Aug 2023 11:18:58 -0700, Tanmay Shah wrote:
> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>
> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
> UltraScale+ platform. It will help in defining TCM in device-tree
> and make it's access platform agnostic and data-driven.
>
> Tightly-coupled memories(TCMs) are low-latency memory that provides
> predictable instruction execution and predictable data load/store
> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>
> The TCM resources(reg, reg-names and power-domain) are documented for
> each TCM in the R5 node. The reg and reg-names are made as required
> properties as we don't want to hardcode TCM addresses for future
> platforms and for zu+ legacy implementation will ensure that the
> old dts w/o reg/reg-names works and stable ABI is maintained.
>
> It also extends the examples for TCM split and lockstep modes.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
>
> Changes in v4:
> - Use address-cells and size-cells value 2
> - Modify ranges property as per new value of address-cells
> and size-cells
> - Modify child node "reg" property accordingly
> - Remove previous ack for further review
>
>
> .../remoteproc/xlnx,zynqmp-r5fss.yaml | 131 +++++++++++++++---
> 1 file changed, 113 insertions(+), 18 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2023-08-30 18:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 18:18 [PATCH v4 0/3] add zynqmp TCM bindings Tanmay Shah
2023-08-29 18:18 ` Tanmay Shah
2023-08-29 18:18 ` [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Tanmay Shah
2023-08-29 18:18 ` Tanmay Shah
2023-08-30 18:16 ` Rob Herring [this message]
2023-08-30 18:16 ` Rob Herring
2023-08-29 18:18 ` [PATCH v4 2/3] dts: zynqmp: add properties for TCM in remoteproc Tanmay Shah
2023-08-29 18:18 ` Tanmay Shah
2023-08-29 18:19 ` [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Tanmay Shah
2023-08-29 18:19 ` Tanmay Shah
2023-09-04 7:50 ` Philippe Mathieu-Daudé
2023-09-04 7:50 ` Philippe Mathieu-Daudé
2023-09-05 21:48 ` Tanmay Shah
2023-09-05 21:48 ` Tanmay Shah
2023-09-06 6:20 ` Philippe Mathieu-Daudé
2023-09-06 6:20 ` Philippe Mathieu-Daudé
2023-09-06 14:21 ` Tanmay Shah
2023-09-06 14:21 ` Tanmay Shah
2023-09-06 19:47 ` Mathieu Poirier
2023-09-06 19:47 ` Mathieu Poirier
2023-09-06 22:02 ` Tanmay Shah
2023-09-06 22:02 ` Tanmay Shah
2023-09-07 17:23 ` Tanmay Shah
2023-09-07 17:23 ` Tanmay Shah
2023-09-07 18:08 ` Mathieu Poirier
2023-09-07 18:08 ` Mathieu Poirier
2023-09-07 23:11 ` Tanmay Shah
2023-09-07 23:11 ` Tanmay Shah
2023-09-08 15:12 ` Mathieu Poirier
2023-09-08 15:12 ` Mathieu Poirier
2023-09-25 16:33 ` Tanmay Shah
2023-09-25 16:33 ` Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169341938045.463502.9445399366399743283.robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.