From: Tanmay Shah <tanmay.shah@amd.com> To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Bjorn Andersson" <andersson@kernel.org>, "Mathieu Poirier" <mathieu.poirier@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michal Simek" <michal.simek@amd.com> Cc: Conor Dooley <conor+dt@kernel.org>, Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>, Ben Levinsky <ben.levinsky@amd.com> Subject: Re: [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Date: Tue, 5 Sep 2023 16:48:54 -0500 [thread overview] Message-ID: <a88a0240-30a2-4c99-baeb-091b44e4c2b7@amd.com> (raw) In-Reply-To: <f6943509-25c5-b4fe-2218-638cc06a4e04@linaro.org> On 9/4/23 2:50 AM, Philippe Mathieu-Daudé wrote: > Hi, > > On 29/8/23 20:19, Tanmay Shah wrote: > > Use new dt bindings to get TCM address and size > > information. Also make sure that driver stays > > compatible with previous device-tree bindings. > > So, if TCM information isn't available in device-tree > > for zynqmp platform, hard-coded address of TCM will > > be used. > > > > New platforms that are compatible with this > > driver must add TCM support in device-tree as per new > > bindings. > > > > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> > > --- > > drivers/remoteproc/xlnx_r5_remoteproc.c | 279 +++++++++++++++++++----- > > 1 file changed, 221 insertions(+), 58 deletions(-) > > > > /** > > @@ -75,11 +79,17 @@ struct mbox_info { > > * Hardcoded TCM bank values. This will be removed once TCM bindings are > > * accepted for system-dt specifications and upstreamed in linux kernel > > Just curious, for how long this fall back code has to be maintained? > (When/how will we know we can remove it?) I believe we should never remove it. It's important that driver works with old bindings as well. > > > */ > > -static const struct mem_bank_data zynqmp_tcm_banks[] = { > > - {0xffe00000UL, 0x10000UL, PD_R5_0_ATCM, "atcm0"}, /* TCM 64KB each */ > > - {0xffe20000UL, 0x10000UL, PD_R5_0_BTCM, "btcm0"}, > > - {0xffe90000UL, 0x10000UL, PD_R5_1_ATCM, "atcm1"}, > > - {0xffeb0000UL, 0x10000UL, PD_R5_1_BTCM, "btcm1"}, > > +static const struct mem_bank_data zynqmp_tcm_banks_split[] = { > > + {0xffe00000, 0x0, 0x10000, PD_R5_0_ATCM, 0, "atcm0"}, /* TCM 64KB each */ > > + {0xffe20000, 0x20000, 0x10000, PD_R5_0_BTCM, 0, "btcm0"}, > > + {0xffe90000, 0x0, 0x10000, PD_R5_1_ATCM, 0, "atcm1"}, > > + {0xffeb0000, 0x20000, 0x10000, PD_R5_1_BTCM, 0, "btcm1"}, > > +}; >
WARNING: multiple messages have this Message-ID (diff)
From: Tanmay Shah <tanmay.shah@amd.com> To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "Bjorn Andersson" <andersson@kernel.org>, "Mathieu Poirier" <mathieu.poirier@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Michal Simek" <michal.simek@amd.com> Cc: Conor Dooley <conor+dt@kernel.org>, Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>, Ben Levinsky <ben.levinsky@amd.com> Subject: Re: [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Date: Tue, 5 Sep 2023 16:48:54 -0500 [thread overview] Message-ID: <a88a0240-30a2-4c99-baeb-091b44e4c2b7@amd.com> (raw) In-Reply-To: <f6943509-25c5-b4fe-2218-638cc06a4e04@linaro.org> On 9/4/23 2:50 AM, Philippe Mathieu-Daudé wrote: > Hi, > > On 29/8/23 20:19, Tanmay Shah wrote: > > Use new dt bindings to get TCM address and size > > information. Also make sure that driver stays > > compatible with previous device-tree bindings. > > So, if TCM information isn't available in device-tree > > for zynqmp platform, hard-coded address of TCM will > > be used. > > > > New platforms that are compatible with this > > driver must add TCM support in device-tree as per new > > bindings. > > > > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com> > > --- > > drivers/remoteproc/xlnx_r5_remoteproc.c | 279 +++++++++++++++++++----- > > 1 file changed, 221 insertions(+), 58 deletions(-) > > > > /** > > @@ -75,11 +79,17 @@ struct mbox_info { > > * Hardcoded TCM bank values. This will be removed once TCM bindings are > > * accepted for system-dt specifications and upstreamed in linux kernel > > Just curious, for how long this fall back code has to be maintained? > (When/how will we know we can remove it?) I believe we should never remove it. It's important that driver works with old bindings as well. > > > */ > > -static const struct mem_bank_data zynqmp_tcm_banks[] = { > > - {0xffe00000UL, 0x10000UL, PD_R5_0_ATCM, "atcm0"}, /* TCM 64KB each */ > > - {0xffe20000UL, 0x10000UL, PD_R5_0_BTCM, "btcm0"}, > > - {0xffe90000UL, 0x10000UL, PD_R5_1_ATCM, "atcm1"}, > > - {0xffeb0000UL, 0x10000UL, PD_R5_1_BTCM, "btcm1"}, > > +static const struct mem_bank_data zynqmp_tcm_banks_split[] = { > > + {0xffe00000, 0x0, 0x10000, PD_R5_0_ATCM, 0, "atcm0"}, /* TCM 64KB each */ > > + {0xffe20000, 0x20000, 0x10000, PD_R5_0_BTCM, 0, "btcm0"}, > > + {0xffe90000, 0x0, 0x10000, PD_R5_1_ATCM, 0, "atcm1"}, > > + {0xffeb0000, 0x20000, 0x10000, PD_R5_1_BTCM, 0, "btcm1"}, > > +}; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-05 21:49 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 18:18 [PATCH v4 0/3] add zynqmp TCM bindings Tanmay Shah 2023-08-29 18:18 ` Tanmay Shah 2023-08-29 18:18 ` [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Tanmay Shah 2023-08-29 18:18 ` Tanmay Shah 2023-08-30 18:16 ` Rob Herring 2023-08-30 18:16 ` Rob Herring 2023-08-29 18:18 ` [PATCH v4 2/3] dts: zynqmp: add properties for TCM in remoteproc Tanmay Shah 2023-08-29 18:18 ` Tanmay Shah 2023-08-29 18:19 ` [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Tanmay Shah 2023-08-29 18:19 ` Tanmay Shah 2023-09-04 7:50 ` Philippe Mathieu-Daudé 2023-09-04 7:50 ` Philippe Mathieu-Daudé 2023-09-05 21:48 ` Tanmay Shah [this message] 2023-09-05 21:48 ` Tanmay Shah 2023-09-06 6:20 ` Philippe Mathieu-Daudé 2023-09-06 6:20 ` Philippe Mathieu-Daudé 2023-09-06 14:21 ` Tanmay Shah 2023-09-06 14:21 ` Tanmay Shah 2023-09-06 19:47 ` Mathieu Poirier 2023-09-06 19:47 ` Mathieu Poirier 2023-09-06 22:02 ` Tanmay Shah 2023-09-06 22:02 ` Tanmay Shah 2023-09-07 17:23 ` Tanmay Shah 2023-09-07 17:23 ` Tanmay Shah 2023-09-07 18:08 ` Mathieu Poirier 2023-09-07 18:08 ` Mathieu Poirier 2023-09-07 23:11 ` Tanmay Shah 2023-09-07 23:11 ` Tanmay Shah 2023-09-08 15:12 ` Mathieu Poirier 2023-09-08 15:12 ` Mathieu Poirier 2023-09-25 16:33 ` Tanmay Shah 2023-09-25 16:33 ` Tanmay Shah
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a88a0240-30a2-4c99-baeb-091b44e4c2b7@amd.com \ --to=tanmay.shah@amd.com \ --cc=andersson@kernel.org \ --cc=ben.levinsky@amd.com \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=michal.simek@amd.com \ --cc=philmd@linaro.org \ --cc=radhey.shyam.pandey@amd.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.