From: Hans de Goede <hdegoede@redhat.com> To: Thomas Zimmermann <tzimmermann@suse.de>, zackr@vmware.com, javierm@redhat.com, jfalempe@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/5] sysfb: Fix memory-region management Date: Tue, 25 Jan 2022 16:34:05 +0100 [thread overview] Message-ID: <16f9e064-99cc-4205-d03e-ae41ed034309@redhat.com> (raw) In-Reply-To: <20220125091222.21457-1-tzimmermann@suse.de> Hi Thomas, On 1/25/22 10:12, Thomas Zimmermann wrote: > Request framebuffer memory in simpledrm and simplefb. Do a hot-unplug > operation when removing fbdev firmware drivers. > > After being unloaded by a hardware driver, simplefb leaves behind the > firmware framebuffer's platform device. This prevents other drivers > from acquiring the memory as reported at [1]. > > Patch 1 changes the removal code of remove_conflicting_framebuffers() > to remove the underlying device and the rsp memory region. > > Patches 2 to 4 update sysfb and its drivers. The sysfb code does no > longer mark the framebuffer memory with IORESOURCE_BUSY. Instead, the > device drivers acquire the memory when they probe the device. > > Patch 5 adds a todo item to acquire memory regions in all DRM drivers. > > Tested with simpledrm and simplefb. > > [1] https://lore.kernel.org/dri-devel/20220117180359.18114-1-zack@kde.org/ > > v2: > * fix possible NULL deref in simpledrm (Jocelyn) > * various style fixes (Javier) The entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans > > Javier Martinez Canillas (1): > drivers/firmware: Don't mark as busy the simple-framebuffer IO > resource > > Thomas Zimmermann (4): > fbdev: Hot-unplug firmware fb devices on forced removal > drm/simpledrm: Request memory region in driver > fbdev/simplefb: Request memory region in driver > drm: Add TODO item for requesting memory regions > > Documentation/gpu/todo.rst | 15 +++++++ > drivers/firmware/sysfb_simplefb.c | 2 +- > drivers/gpu/drm/tiny/simpledrm.c | 22 ++++++++--- > drivers/video/fbdev/core/fbmem.c | 29 ++++++++++++-- > drivers/video/fbdev/simplefb.c | 65 +++++++++++++++++++++---------- > include/linux/fb.h | 1 + > 6 files changed, 105 insertions(+), 29 deletions(-) > > > base-commit: 0bb81b5d6db5f689b67f9d8b35323235c45e890f > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > prerequisite-patch-id: 8e52143a6cd7b8fb789e656208f6edde71d0f499 >
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Thomas Zimmermann <tzimmermann@suse.de>, zackr@vmware.com, javierm@redhat.com, jfalempe@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@linux.ie, daniel@ffwll.ch, deller@gmx.de Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 0/5] sysfb: Fix memory-region management Date: Tue, 25 Jan 2022 16:34:05 +0100 [thread overview] Message-ID: <16f9e064-99cc-4205-d03e-ae41ed034309@redhat.com> (raw) In-Reply-To: <20220125091222.21457-1-tzimmermann@suse.de> Hi Thomas, On 1/25/22 10:12, Thomas Zimmermann wrote: > Request framebuffer memory in simpledrm and simplefb. Do a hot-unplug > operation when removing fbdev firmware drivers. > > After being unloaded by a hardware driver, simplefb leaves behind the > firmware framebuffer's platform device. This prevents other drivers > from acquiring the memory as reported at [1]. > > Patch 1 changes the removal code of remove_conflicting_framebuffers() > to remove the underlying device and the rsp memory region. > > Patches 2 to 4 update sysfb and its drivers. The sysfb code does no > longer mark the framebuffer memory with IORESOURCE_BUSY. Instead, the > device drivers acquire the memory when they probe the device. > > Patch 5 adds a todo item to acquire memory regions in all DRM drivers. > > Tested with simpledrm and simplefb. > > [1] https://lore.kernel.org/dri-devel/20220117180359.18114-1-zack@kde.org/ > > v2: > * fix possible NULL deref in simpledrm (Jocelyn) > * various style fixes (Javier) The entire series looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> for the series. Regards, Hans > > Javier Martinez Canillas (1): > drivers/firmware: Don't mark as busy the simple-framebuffer IO > resource > > Thomas Zimmermann (4): > fbdev: Hot-unplug firmware fb devices on forced removal > drm/simpledrm: Request memory region in driver > fbdev/simplefb: Request memory region in driver > drm: Add TODO item for requesting memory regions > > Documentation/gpu/todo.rst | 15 +++++++ > drivers/firmware/sysfb_simplefb.c | 2 +- > drivers/gpu/drm/tiny/simpledrm.c | 22 ++++++++--- > drivers/video/fbdev/core/fbmem.c | 29 ++++++++++++-- > drivers/video/fbdev/simplefb.c | 65 +++++++++++++++++++++---------- > include/linux/fb.h | 1 + > 6 files changed, 105 insertions(+), 29 deletions(-) > > > base-commit: 0bb81b5d6db5f689b67f9d8b35323235c45e890f > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > prerequisite-patch-id: 8e52143a6cd7b8fb789e656208f6edde71d0f499 >
next prev parent reply other threads:[~2022-01-25 15:34 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-25 9:12 [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 9:12 ` [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 9:12 ` [PATCH 2/5] drivers/firmware: Don't mark as busy the simple-framebuffer IO resource Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 9:12 ` [PATCH 3/5] drm/simpledrm: Request memory region in driver Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 13:41 ` Jocelyn Falempe 2022-01-25 13:41 ` Jocelyn Falempe 2022-01-25 9:12 ` [PATCH 4/5] fbdev/simplefb: " Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 9:33 ` Javier Martinez Canillas 2022-01-25 9:33 ` Javier Martinez Canillas 2022-01-25 9:12 ` [PATCH 5/5] drm: Add TODO item for requesting memory regions Thomas Zimmermann 2022-01-25 9:12 ` Thomas Zimmermann 2022-01-25 9:13 ` [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann 2022-01-25 9:13 ` Thomas Zimmermann 2022-01-25 15:34 ` Hans de Goede [this message] 2022-01-25 15:34 ` Hans de Goede -- strict thread matches above, loose matches on Subject: below -- 2022-01-24 12:36 Thomas Zimmermann 2022-01-24 12:36 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=16f9e064-99cc-4205-d03e-ae41ed034309@redhat.com \ --to=hdegoede@redhat.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=javierm@redhat.com \ --cc=jfalempe@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ --cc=zackr@vmware.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.