All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	zackr@vmware.com, jfalempe@redhat.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@linux.ie, daniel@ffwll.ch, deller@gmx.de,
	hdegoede@redhat.com
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/5] fbdev/simplefb: Request memory region in driver
Date: Tue, 25 Jan 2022 10:33:12 +0100	[thread overview]
Message-ID: <db92f89b-e266-f87d-d635-4207fd2585c4@redhat.com> (raw)
In-Reply-To: <20220125091222.21457-5-tzimmermann@suse.de>

Hello Thomas,

On 1/25/22 10:12, Thomas Zimmermann wrote:
> Requesting the framebuffer memory in simpledrm marks the memory
> range as busy. This used to be done by the firmware sysfb code,
> but the driver is the correct place.
> 
> v2:
> 	* store memory region in struct for later cleanup (Javier)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Thanks a lot for updating the patch. Now this logic is also more
similar to the changes done for the simpledrm driver in PATCH 3/5.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat


WARNING: multiple messages have this Message-ID (diff)
From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	zackr@vmware.com, jfalempe@redhat.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@linux.ie, daniel@ffwll.ch, deller@gmx.de,
	hdegoede@redhat.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 4/5] fbdev/simplefb: Request memory region in driver
Date: Tue, 25 Jan 2022 10:33:12 +0100	[thread overview]
Message-ID: <db92f89b-e266-f87d-d635-4207fd2585c4@redhat.com> (raw)
In-Reply-To: <20220125091222.21457-5-tzimmermann@suse.de>

Hello Thomas,

On 1/25/22 10:12, Thomas Zimmermann wrote:
> Requesting the framebuffer memory in simpledrm marks the memory
> range as busy. This used to be done by the firmware sysfb code,
> but the driver is the correct place.
> 
> v2:
> 	* store memory region in struct for later cleanup (Javier)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Thanks a lot for updating the patch. Now this logic is also more
similar to the changes done for the simpledrm driver in PATCH 3/5.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat


  reply	other threads:[~2022-01-25  9:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  9:12 [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann
2022-01-25  9:12 ` Thomas Zimmermann
2022-01-25  9:12 ` [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal Thomas Zimmermann
2022-01-25  9:12   ` Thomas Zimmermann
2022-01-25  9:12 ` [PATCH 2/5] drivers/firmware: Don't mark as busy the simple-framebuffer IO resource Thomas Zimmermann
2022-01-25  9:12   ` Thomas Zimmermann
2022-01-25  9:12 ` [PATCH 3/5] drm/simpledrm: Request memory region in driver Thomas Zimmermann
2022-01-25  9:12   ` Thomas Zimmermann
2022-01-25 13:41   ` Jocelyn Falempe
2022-01-25 13:41     ` Jocelyn Falempe
2022-01-25  9:12 ` [PATCH 4/5] fbdev/simplefb: " Thomas Zimmermann
2022-01-25  9:12   ` Thomas Zimmermann
2022-01-25  9:33   ` Javier Martinez Canillas [this message]
2022-01-25  9:33     ` Javier Martinez Canillas
2022-01-25  9:12 ` [PATCH 5/5] drm: Add TODO item for requesting memory regions Thomas Zimmermann
2022-01-25  9:12   ` Thomas Zimmermann
2022-01-25  9:13 ` [PATCH 0/5] sysfb: Fix memory-region management Thomas Zimmermann
2022-01-25  9:13   ` Thomas Zimmermann
2022-01-25 15:34 ` Hans de Goede
2022-01-25 15:34   ` Hans de Goede
  -- strict thread matches above, loose matches on Subject: below --
2022-01-24 12:36 Thomas Zimmermann
2022-01-24 12:36 ` [PATCH 4/5] fbdev/simplefb: Request memory region in driver Thomas Zimmermann
2022-01-24 12:36   ` Thomas Zimmermann
2022-01-24 14:24   ` Javier Martinez Canillas
2022-01-24 14:24     ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db92f89b-e266-f87d-d635-4207fd2585c4@redhat.com \
    --to=javierm@redhat.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=jfalempe@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.