All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jérôme Pouiller" <Jerome.Pouiller@silabs.com>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: wfx: match parentheses alignment
Date: Mon, 24 Feb 2020 09:22:36 +0000	[thread overview]
Message-ID: <1761697.Ie2Hvvaxtr@pc-42> (raw)
In-Reply-To: <20200223193201.GA20843@kaaira-HP-Pavilion-Notebook>

On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
> 
> match next line with open parentheses by giving appropriate tabs.

Maybe the body of the commit message should start with a capital letter,
else:

Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

> 
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
>  drivers/staging/wfx/data_tx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
>  }
> 
>  static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> -                                     struct ieee80211_sta *sta,
> -                                     struct ieee80211_hdr *hdr)
> +                                struct ieee80211_sta *sta,
> +                                struct ieee80211_hdr *hdr)
>  {
>         struct wfx_sta_priv *sta_priv =
>                 sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
>  }
> 
>  static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> -                                 struct ieee80211_tx_info *tx_info)
> +                            struct ieee80211_tx_info *tx_info)
>  {
>         bool tx_policy_renew = false;
>         u8 rate_id;


-- 
Jérôme Pouiller


WARNING: multiple messages have this Message-ID (diff)
From: "Jérôme Pouiller" <Jerome.Pouiller@silabs.com>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: wfx: match parentheses alignment
Date: Mon, 24 Feb 2020 09:22:36 +0000	[thread overview]
Message-ID: <1761697.Ie2Hvvaxtr@pc-42> (raw)
In-Reply-To: <20200223193201.GA20843@kaaira-HP-Pavilion-Notebook>

On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
> 
> match next line with open parentheses by giving appropriate tabs.

Maybe the body of the commit message should start with a capital letter,
else:

Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

> 
> Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
> ---
>  drivers/staging/wfx/data_tx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
>  }
> 
>  static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> -                                     struct ieee80211_sta *sta,
> -                                     struct ieee80211_hdr *hdr)
> +                                struct ieee80211_sta *sta,
> +                                struct ieee80211_hdr *hdr)
>  {
>         struct wfx_sta_priv *sta_priv =
>                 sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
>  }
> 
>  static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> -                                 struct ieee80211_tx_info *tx_info)
> +                            struct ieee80211_tx_info *tx_info)
>  {
>         bool tx_policy_renew = false;
>         u8 rate_id;


-- 
Jérôme Pouiller

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-02-24  9:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-23 19:32 [PATCH] staging: wfx: match parentheses alignment Kaaira Gupta
2020-02-23 19:32 ` Kaaira Gupta
2020-02-24  9:22 ` Jérôme Pouiller [this message]
2020-02-24  9:22   ` Jérôme Pouiller
2020-02-24 14:13 ` Joe Perches
2020-02-24 14:13   ` Joe Perches
2020-02-24 16:26   ` [PATCH v2] staging: wfx: data_tx.c: " Kaaira Gupta
2020-02-24 16:26     ` Kaaira Gupta
2020-03-04  6:48     ` Greg Kroah-Hartman
2020-03-04  6:48       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1761697.Ie2Hvvaxtr@pc-42 \
    --to=jerome.pouiller@silabs.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kgupta@es.iitr.ac.in \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.