From: Kaaira Gupta <kgupta@es.iitr.ac.in> To: Joe Perches <joe@perches.com>, jerome.pouiller@silabs.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment Date: Mon, 24 Feb 2020 21:56:21 +0530 [thread overview] Message-ID: <20200224162621.GA6611@kaaira-HP-Pavilion-Notebook> (raw) In-Reply-To: <8c458c189abb45fb3021f7882a40d28a24cc662d.camel@perches.com> On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote: > > Match next line with open parentheses by giving appropriate tabs. Changed the first word to caps. Will keep this in mind from now on. Thanks! > > This patch is only for data_tx.c > > There are many more parentheses that are not aligned > in staging/wfx in other files. > > Realistically, either change the subject to show > that it's only for data_tx or do them all. I have made the changes in the subject line and will submit a separate patch with clean-ups in all the other files > > (but not traces.h, those use a different style) > > $ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch] > drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Kaaira Gupta <kgupta@es.iitr.ac.in> To: Joe Perches <joe@perches.com>, jerome.pouiller@silabs.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: wfx: data_tx.c: match parentheses alignment Date: Mon, 24 Feb 2020 21:56:21 +0530 [thread overview] Message-ID: <20200224162621.GA6611@kaaira-HP-Pavilion-Notebook> (raw) In-Reply-To: <8c458c189abb45fb3021f7882a40d28a24cc662d.camel@perches.com> On Mon, Feb 24, 2020 at 06:13:32AM -0800, Joe Perches wrote: > On Mon, 2020-02-24 at 01:02 +0530, Kaaira Gupta wrote: > > Match next line with open parentheses by giving appropriate tabs. Changed the first word to caps. Will keep this in mind from now on. Thanks! > > This patch is only for data_tx.c > > There are many more parentheses that are not aligned > in staging/wfx in other files. > > Realistically, either change the subject to show > that it's only for data_tx or do them all. I have made the changes in the subject line and will submit a separate patch with clean-ups in all the other files > > (but not traces.h, those use a different style) > > $ ./scripts/checkpatch.pl -f --terse --nosummary --types=parenthesis_alignment drivers/staging/wfx/*.[ch] > drivers/staging/wfx/data_tx.c:303: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/data_tx.c:371: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/debug.c:35: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:35: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:45: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:55: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:72: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:97: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:106: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:118: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:133: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/key.c:147: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:393: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:408: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/queue.c:433: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:123: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:235: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:291: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:340: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/sta.c:717: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:156: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:194: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:206: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:211: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:234: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:257: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:265: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:271: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:278: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:296: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:302: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:307: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:313: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:324: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:329: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:334: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:351: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:362: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:416: CHECK: Alignment should match open parenthesis > drivers/staging/wfx/traces.h:418: CHECK: Alignment should match open parenthesis > > > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-02-24 16:26 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-23 19:32 [PATCH] staging: wfx: match parentheses alignment Kaaira Gupta 2020-02-23 19:32 ` Kaaira Gupta 2020-02-24 9:22 ` Jérôme Pouiller 2020-02-24 9:22 ` Jérôme Pouiller 2020-02-24 14:13 ` Joe Perches 2020-02-24 14:13 ` Joe Perches 2020-02-24 16:26 ` Kaaira Gupta [this message] 2020-02-24 16:26 ` [PATCH v2] staging: wfx: data_tx.c: " Kaaira Gupta 2020-03-04 6:48 ` Greg Kroah-Hartman 2020-03-04 6:48 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200224162621.GA6611@kaaira-HP-Pavilion-Notebook \ --to=kgupta@es.iitr.ac.in \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=jerome.pouiller@silabs.com \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.