From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: Build failure: shmobile drm driver references backlight symbols
Date: Tue, 29 Oct 2013 18:20:52 +0100 [thread overview]
Message-ID: <1773467.v8Jb5caonk@avalon> (raw)
In-Reply-To: <20131029100413.GA8857@n2100.arm.linux.org.uk>
Hi Russell,
On Tuesday 29 October 2013 10:04:13 Russell King - ARM Linux wrote:
> My build system picked up on this failure:
>
> drivers/built-in.o: In function `shmob_drm_backlight_init':
> fmc-chardev.c:(.text+0x9f2d0): undefined reference to
> `backlight_device_register' drivers/built-in.o: In function
> `shmob_drm_backlight_exit':
> fmc-chardev.c:(.text+0x9f370): undefined reference to
> `backlight_device_unregister'
>
> which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being
> built without the backlight dependency being enabled. It looks like
> the backlight dependency is a hard requirement, so needs ot be added
> to the Kconfig entry for this driver in some way.
Thank you for the report. I'll send a fix.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: Re: Build failure: shmobile drm driver references backlight symbols
Date: Tue, 29 Oct 2013 18:20:52 +0100 [thread overview]
Message-ID: <1773467.v8Jb5caonk@avalon> (raw)
In-Reply-To: <20131029100413.GA8857@n2100.arm.linux.org.uk>
Hi Russell,
On Tuesday 29 October 2013 10:04:13 Russell King - ARM Linux wrote:
> My build system picked up on this failure:
>
> drivers/built-in.o: In function `shmob_drm_backlight_init':
> fmc-chardev.c:(.text+0x9f2d0): undefined reference to
> `backlight_device_register' drivers/built-in.o: In function
> `shmob_drm_backlight_exit':
> fmc-chardev.c:(.text+0x9f370): undefined reference to
> `backlight_device_unregister'
>
> which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being
> built without the backlight dependency being enabled. It looks like
> the backlight dependency is a hard requirement, so needs ot be added
> to the Kconfig entry for this driver in some way.
Thank you for the report. I'll send a fix.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-10-29 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 10:04 Build failure: shmobile drm driver references backlight symbols Russell King - ARM Linux
2013-10-29 10:04 ` Russell King - ARM Linux
2013-10-29 17:20 ` Laurent Pinchart [this message]
2013-10-29 17:20 ` Laurent Pinchart
2013-10-29 17:20 ` [PATCH] drm: shmobile: Add dependency on BACKLIGHT_CLASS_DEVICE Laurent Pinchart
2013-10-29 17:20 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1773467.v8Jb5caonk@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.