All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dt: bindings: Add a generic ethernet device binding
Date: Fri, 15 Jul 2016 22:42:54 +0200	[thread overview]
Message-ID: <1788846.r3134d1VMR@wuerfel> (raw)
In-Reply-To: <1468405204-5845-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Wednesday, July 13, 2016 12:20:04 PM CEST Hans de Goede wrote:
> +&mmc1 {
> +       non-removable;
> +       status = "okay";
> +
> +       sdio_wifi: sdio_wifi@1 {
> +               compatible = "generic,ethernet"
> +               reg = <1>;
> +       };
> +};

For discoverable buses, we normally use a compatible property that
reflects the device ID on that bus, e.g. on PCI we have "pci1A2B:3C4D",
and I think that makes more sense than having to come up with strings
for sdio devices.

In fact, Linux completely ignores the compatible strings on those
buses (pci, usb, sdio, ...), so I think we can just do the same thing
using no compatible string at all.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt: bindings: Add a generic ethernet device binding
Date: Fri, 15 Jul 2016 22:42:54 +0200	[thread overview]
Message-ID: <1788846.r3134d1VMR@wuerfel> (raw)
In-Reply-To: <1468405204-5845-1-git-send-email-hdegoede@redhat.com>

On Wednesday, July 13, 2016 12:20:04 PM CEST Hans de Goede wrote:
> +&mmc1 {
> +       non-removable;
> +       status = "okay";
> +
> +       sdio_wifi: sdio_wifi at 1 {
> +               compatible = "generic,ethernet"
> +               reg = <1>;
> +       };
> +};

For discoverable buses, we normally use a compatible property that
reflects the device ID on that bus, e.g. on PCI we have "pci1A2B:3C4D",
and I think that makes more sense than having to come up with strings
for sdio devices.

In fact, Linux completely ignores the compatible strings on those
buses (pci, usb, sdio, ...), so I think we can just do the same thing
using no compatible string at all.

	Arnd

  parent reply	other threads:[~2016-07-15 20:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 10:20 [PATCH] dt: bindings: Add a generic ethernet device binding Hans de Goede
2016-07-13 10:20 ` Hans de Goede
2016-07-14 23:17 ` David Miller
2016-07-14 23:17   ` David Miller
     [not found]   ` <20160714.161707.2089949241813985527.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-15  6:40     ` Hans de Goede
2016-07-15  6:40       ` Hans de Goede
     [not found]       ` <47a052a1-cc8b-0f75-e44a-450c4a0ac075-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-15  6:44         ` Hans de Goede
2016-07-15  6:44           ` Hans de Goede
2016-07-15 17:51         ` David Miller
2016-07-15 17:51           ` David Miller
     [not found]           ` <20160715.105158.2028840258568316933.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-16 10:12             ` Hans de Goede
2016-07-16 10:12               ` Hans de Goede
2016-07-17  1:02               ` David Miller
2016-07-17  1:02                 ` David Miller
     [not found] ` <1468405204-5845-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-15 20:42   ` Arnd Bergmann [this message]
2016-07-15 20:42     ` Arnd Bergmann
2016-07-16 10:18     ` Hans de Goede
2016-07-16 10:18       ` Hans de Goede
     [not found]       ` <289d5b2e-6232-2c91-f11d-774265e05125-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-16 19:19         ` Arnd Bergmann
2016-07-16 19:19           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1788846.r3134d1VMR@wuerfel \
    --to=arnd-r2ngtmty4d4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.