All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] dt: bindings: Add a generic ethernet device binding
Date: Sat, 16 Jul 2016 12:12:37 +0200	[thread overview]
Message-ID: <888927c4-0987-ccfb-e2de-d03f6d4ab319@redhat.com> (raw)
In-Reply-To: <20160715.105158.2028840258568316933.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>

Hi,

On 15-07-16 19:51, David Miller wrote:
> From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Date: Fri, 15 Jul 2016 08:40:00 +0200
>
>> Hi,
>>
>> On 15-07-16 01:17, David Miller wrote:
>>> From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>> Date: Wed, 13 Jul 2016 12:20:04 +0200
>>>
>>>> On some boards (android tablets) different batches use different sdio
>>>> wifi modules. This is not a problem since sdio is a discoverable bus,
>>>> so we only need to describe and activate the mmc controller in dt and
>>>> then the kernel will automatically load the right driver.
>>>>
>>>> But sometimes it is useful to specify certain ethernet properties for
>>>> these "unknown" sdio devices, specifically we want the boot-loader
>>>> to be able to set "local-mac-address" as some of these sdio wifi
>>>> modules come without an eeprom / without a factory programmed mac
>>>> address.
>>>>
>>>> Since the exact device is unknown (differs per batch) we cannot use
>>>> a wifi-chip specific compatible. This commit adds a new
>>>> "generic,ethernet" binding for use in dt-nodes describing such an
>>>> unknown ethernet device.
>>>>
>>>> Cc: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>
>>> Precedence exists for a "system ethernet address" as far back as the
>>> original sparc device tree implementation, so please just specify it
>>> that way rather than trying to force having to make an alias or
>>> reference to it from a specific device.
>>
>> Some boards where this is applicable have both a wired and a wireless
>> ethernet, so one global setting will not work.
>
> Then call it "eth:local-mac-address" and "wifi:local-mac-address"

Until we get a board with 2 ethernet interfaces, really the alias thing
is working fine here, that is not the problem.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt: bindings: Add a generic ethernet device binding
Date: Sat, 16 Jul 2016 12:12:37 +0200	[thread overview]
Message-ID: <888927c4-0987-ccfb-e2de-d03f6d4ab319@redhat.com> (raw)
In-Reply-To: <20160715.105158.2028840258568316933.davem@davemloft.net>

Hi,

On 15-07-16 19:51, David Miller wrote:
> From: Hans de Goede <hdegoede@redhat.com>
> Date: Fri, 15 Jul 2016 08:40:00 +0200
>
>> Hi,
>>
>> On 15-07-16 01:17, David Miller wrote:
>>> From: Hans de Goede <hdegoede@redhat.com>
>>> Date: Wed, 13 Jul 2016 12:20:04 +0200
>>>
>>>> On some boards (android tablets) different batches use different sdio
>>>> wifi modules. This is not a problem since sdio is a discoverable bus,
>>>> so we only need to describe and activate the mmc controller in dt and
>>>> then the kernel will automatically load the right driver.
>>>>
>>>> But sometimes it is useful to specify certain ethernet properties for
>>>> these "unknown" sdio devices, specifically we want the boot-loader
>>>> to be able to set "local-mac-address" as some of these sdio wifi
>>>> modules come without an eeprom / without a factory programmed mac
>>>> address.
>>>>
>>>> Since the exact device is unknown (differs per batch) we cannot use
>>>> a wifi-chip specific compatible. This commit adds a new
>>>> "generic,ethernet" binding for use in dt-nodes describing such an
>>>> unknown ethernet device.
>>>>
>>>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> Precedence exists for a "system ethernet address" as far back as the
>>> original sparc device tree implementation, so please just specify it
>>> that way rather than trying to force having to make an alias or
>>> reference to it from a specific device.
>>
>> Some boards where this is applicable have both a wired and a wireless
>> ethernet, so one global setting will not work.
>
> Then call it "eth:local-mac-address" and "wifi:local-mac-address"

Until we get a board with 2 ethernet interfaces, really the alias thing
is working fine here, that is not the problem.

Regards,

Hans

  parent reply	other threads:[~2016-07-16 10:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 10:20 [PATCH] dt: bindings: Add a generic ethernet device binding Hans de Goede
2016-07-13 10:20 ` Hans de Goede
2016-07-14 23:17 ` David Miller
2016-07-14 23:17   ` David Miller
     [not found]   ` <20160714.161707.2089949241813985527.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-15  6:40     ` Hans de Goede
2016-07-15  6:40       ` Hans de Goede
     [not found]       ` <47a052a1-cc8b-0f75-e44a-450c4a0ac075-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-15  6:44         ` Hans de Goede
2016-07-15  6:44           ` Hans de Goede
2016-07-15 17:51         ` David Miller
2016-07-15 17:51           ` David Miller
     [not found]           ` <20160715.105158.2028840258568316933.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-16 10:12             ` Hans de Goede [this message]
2016-07-16 10:12               ` Hans de Goede
2016-07-17  1:02               ` David Miller
2016-07-17  1:02                 ` David Miller
     [not found] ` <1468405204-5845-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-15 20:42   ` Arnd Bergmann
2016-07-15 20:42     ` Arnd Bergmann
2016-07-16 10:18     ` Hans de Goede
2016-07-16 10:18       ` Hans de Goede
     [not found]       ` <289d5b2e-6232-2c91-f11d-774265e05125-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-16 19:19         ` Arnd Bergmann
2016-07-16 19:19           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=888927c4-0987-ccfb-e2de-d03f6d4ab319@redhat.com \
    --to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.