From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
To: JeffyChen <jeffy.chen@rock-chips.com>,
linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
linux-rockchip@lists.infradead.org
Cc: klaus.goger@theobroma-systems.com,
Huang Jiachai <sandy.huang@rock-chips.com>
Subject: Re: [regression, bisected] rockchip rk3399 video output breakage
Date: Tue, 24 Apr 2018 15:47:35 +0200 [thread overview]
Message-ID: <179239ba-0833-945c-0c2f-26fd9b7c2755@theobroma-systems.com> (raw)
In-Reply-To: <5ADF321E.4060408@rock-chips.com>
On 24.04.18 15:33, JeffyChen wrote:
>>> [ 36.076577] WARNING: CPU: 1 PID: 83 at
>>> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1004
>>> vop_crtc_atomic_flush+0x1c0/0x1c8
>
> this looks like an issue recently reported by heiko, we found that might
> due to an unbalanced irq disable in vop driver.
>
> my test patch is:
>
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1601,6 +1601,8 @@ static void vop_unbind(struct device *dev, struct
> device *master, void *data)
> {
> struct vop *vop = dev_get_drvdata(dev);
>
> + // Pair with the initial disable_irq()
> + enable_irq(vop->irq);
>
>
>
> and i think sandy would send the real patch soon(maybe already sent?)
Works fine with your patch! Thank you very much Jeffy.
Best regards,
Jakob
prev parent reply other threads:[~2018-04-24 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:19 [regression, bisected] rockchip rk3399 video output breakage Jakob Unterwurzacher
2018-04-24 12:37 ` JeffyChen
2018-04-24 13:11 ` Jakob Unterwurzacher
2018-04-24 13:33 ` JeffyChen
2018-04-24 13:33 ` JeffyChen
2018-04-24 13:47 ` Jakob Unterwurzacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179239ba-0833-945c-0c2f-26fd9b7c2755@theobroma-systems.com \
--to=jakob.unterwurzacher@theobroma-systems.com \
--cc=jeffy.chen@rock-chips.com \
--cc=jroedel@suse.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sandy.huang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.