From: JeffyChen <jeffy.chen@rock-chips.com> To: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>, linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>, linux-rockchip@lists.infradead.org Cc: klaus.goger@theobroma-systems.com, Huang Jiachai <sandy.huang@rock-chips.com> Subject: Re: [regression, bisected] rockchip rk3399 video output breakage Date: Tue, 24 Apr 2018 21:33:18 +0800 [thread overview] Message-ID: <5ADF321E.4060408@rock-chips.com> (raw) In-Reply-To: <fdd0fe29-2117-c67b-5dba-5d1ab0b19dd1@theobroma-systems.com> Hi Jokab, Thanks for your reply. On 04/24/2018 09:11 PM, Jakob Unterwurzacher wrote: > On 24.04.18 14:37, JeffyChen wrote: >> >> right, i think it's a known issue, as the iommu failed to get clks: >> [ 1.525153] rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -2 >> [ 1.525316] rk_iommu: probe of ff8f3f00.iommu failed with error -2 >> [ 1.525484] rk_iommu ff903f00.iommu: Failed to get clk 'iface': -2 >> [ 1.525643] rk_iommu: probe of ff903f00.iommu failed with error -2 >> >> >> there's a followed patch to add those clks to the dtsi, and also a fix >> patch to make those clks optional(by heiko): >> >> https://www.spinics.net/lists/arm-kernel/msg645696.html >> >> http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020349.html >> > > Thanks, I tested both, and both get the screen to display some kernel > output! > > However, I am getting some nasty error messages and the screen seems to > refresh only once every 30 seconds: > >> [ 15.586502] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [CRTC:30:crtc-0] flip_done timed out >> [ 25.826490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [CONNECTOR:37:HDMI-A-1] flip_done timed out >> [ 36.066490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [PLANE:28:plane-0] flip_done timed out >> [ 36.066504] [drm:drm_calc_timestamping_constants] crtc 30: hwmode: >> htotal 2200, vtotal 1125, vdisplay 1080 >> [ 36.066508] [drm:drm_calc_timestamping_constants] crtc 30: clock >> 148500 kHz framedur 16666666 linedur 14814 >> [ 36.076535] rockchip-vop ff8f0000.vop: [drm:vop_crtc_atomic_flush] >> *ERROR* VOP vblank IRQ stuck for 10 ms >> [ 36.076577] WARNING: CPU: 1 PID: 83 at >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1004 >> vop_crtc_atomic_flush+0x1c0/0x1c8 this looks like an issue recently reported by heiko, we found that might due to an unbalanced irq disable in vop driver. my test patch is: +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1601,6 +1601,8 @@ static void vop_unbind(struct device *dev, struct device *master, void *data) { struct vop *vop = dev_get_drvdata(dev); + // Pair with the initial disable_irq() + enable_irq(vop->irq); and i think sandy would send the real patch soon(maybe already sent?) > > Full dmesg with patch "arm64: dts: rockchip: add clocks in iommu nodes": > https://gist.github.com/jakob-tsd/3fd49894d52dcd8a409eb9e6136b2d39 > > Full dmesg with patch "iommu/rockchip: make clock handling optional": > https://gist.github.com/jakob-tsd/da96572a40d11f0f6dff3ee481098138 > (looks the same) > > Thanks, > Jakob > > >
WARNING: multiple messages have this Message-ID (diff)
From: JeffyChen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> To: Jakob Unterwurzacher <jakob.unterwurzacher-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Huang Jiachai <sandy.huang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>, klaus.goger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org Subject: Re: [regression, bisected] rockchip rk3399 video output breakage Date: Tue, 24 Apr 2018 21:33:18 +0800 [thread overview] Message-ID: <5ADF321E.4060408@rock-chips.com> (raw) In-Reply-To: <fdd0fe29-2117-c67b-5dba-5d1ab0b19dd1-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org> Hi Jokab, Thanks for your reply. On 04/24/2018 09:11 PM, Jakob Unterwurzacher wrote: > On 24.04.18 14:37, JeffyChen wrote: >> >> right, i think it's a known issue, as the iommu failed to get clks: >> [ 1.525153] rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -2 >> [ 1.525316] rk_iommu: probe of ff8f3f00.iommu failed with error -2 >> [ 1.525484] rk_iommu ff903f00.iommu: Failed to get clk 'iface': -2 >> [ 1.525643] rk_iommu: probe of ff903f00.iommu failed with error -2 >> >> >> there's a followed patch to add those clks to the dtsi, and also a fix >> patch to make those clks optional(by heiko): >> >> https://www.spinics.net/lists/arm-kernel/msg645696.html >> >> http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020349.html >> > > Thanks, I tested both, and both get the screen to display some kernel > output! > > However, I am getting some nasty error messages and the screen seems to > refresh only once every 30 seconds: > >> [ 15.586502] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [CRTC:30:crtc-0] flip_done timed out >> [ 25.826490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [CONNECTOR:37:HDMI-A-1] flip_done timed out >> [ 36.066490] [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* >> [PLANE:28:plane-0] flip_done timed out >> [ 36.066504] [drm:drm_calc_timestamping_constants] crtc 30: hwmode: >> htotal 2200, vtotal 1125, vdisplay 1080 >> [ 36.066508] [drm:drm_calc_timestamping_constants] crtc 30: clock >> 148500 kHz framedur 16666666 linedur 14814 >> [ 36.076535] rockchip-vop ff8f0000.vop: [drm:vop_crtc_atomic_flush] >> *ERROR* VOP vblank IRQ stuck for 10 ms >> [ 36.076577] WARNING: CPU: 1 PID: 83 at >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c:1004 >> vop_crtc_atomic_flush+0x1c0/0x1c8 this looks like an issue recently reported by heiko, we found that might due to an unbalanced irq disable in vop driver. my test patch is: +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1601,6 +1601,8 @@ static void vop_unbind(struct device *dev, struct device *master, void *data) { struct vop *vop = dev_get_drvdata(dev); + // Pair with the initial disable_irq() + enable_irq(vop->irq); and i think sandy would send the real patch soon(maybe already sent?) > > Full dmesg with patch "arm64: dts: rockchip: add clocks in iommu nodes": > https://gist.github.com/jakob-tsd/3fd49894d52dcd8a409eb9e6136b2d39 > > Full dmesg with patch "iommu/rockchip: make clock handling optional": > https://gist.github.com/jakob-tsd/da96572a40d11f0f6dff3ee481098138 > (looks the same) > > Thanks, > Jakob > > >
next prev parent reply other threads:[~2018-04-24 13:33 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-24 12:19 [regression, bisected] rockchip rk3399 video output breakage Jakob Unterwurzacher 2018-04-24 12:37 ` JeffyChen 2018-04-24 13:11 ` Jakob Unterwurzacher 2018-04-24 13:33 ` JeffyChen [this message] 2018-04-24 13:33 ` JeffyChen 2018-04-24 13:47 ` Jakob Unterwurzacher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5ADF321E.4060408@rock-chips.com \ --to=jeffy.chen@rock-chips.com \ --cc=jakob.unterwurzacher@theobroma-systems.com \ --cc=jroedel@suse.de \ --cc=klaus.goger@theobroma-systems.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=sandy.huang@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.