All of lore.kernel.org
 help / color / mirror / Atom feed
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>,
	linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
	linux-rockchip@lists.infradead.org
Subject: Re: [regression, bisected] rockchip rk3399 video output breakage
Date: Tue, 24 Apr 2018 20:37:07 +0800	[thread overview]
Message-ID: <5ADF24F3.6070106@rock-chips.com> (raw)
In-Reply-To: <3beabd18-0c39-be65-cfe7-8498dc7c296b@theobroma-systems.com>

Hi Jakob,

Thanks for your message.

On 04/24/2018 08:19 PM, Jakob Unterwurzacher wrote:
>
> Full dmesg:
> https://gist.github.com/jakob-tsd/33cf395e355bf9bb6956c36438d999e7
>
> I have bisected the "master bind failed" down to:
>
>> commit 9176a303d971dc0fb35469c531c0d263667d2277
>> Author: Jeffy Chen <jeffy.chen@rock-chips.com>
>> Date:   Fri Mar 23 15:38:10 2018 +0800
>>
>>     iommu/rockchip: Use IOMMU device for dma mapping operations
>>
>>     Use the first registered IOMMU device for dma mapping operations, and
>>     drop the domain platform device.
>>
>>     This is similar to exynos iommu driver.
>>
>>     Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>>     Reviewed-by: Tomasz Figa <tfiga@chromium.org>
>>     Reviewed-by: Robin Murphy <robin.murphy@arm.com>
>>     Signed-off-by: Joerg Roedel <jroedel@suse.de>
>
> Moving to one commit earlier brings the screen to life. Just with
> colorful garbage, but I guess that's a different problem.
>
> Is this a known issue with the IOMMU change?

right, i think it's a known issue, as the iommu failed to get clks:
[    1.525153] rk_iommu ff8f3f00.iommu: Failed to get clk 'iface': -2
[    1.525316] rk_iommu: probe of ff8f3f00.iommu failed with error -2
[    1.525484] rk_iommu ff903f00.iommu: Failed to get clk 'iface': -2
[    1.525643] rk_iommu: probe of ff903f00.iommu failed with error -2


there's a followed patch to add those clks to the dtsi, and also a fix 
patch to make those clks optional(by heiko):

https://www.spinics.net/lists/arm-kernel/msg645696.html

http://lists.infradead.org/pipermail/linux-rockchip/2018-April/020349.html

>
> Thanks,
> Jakob

  reply	other threads:[~2018-04-24 12:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 12:19 [regression, bisected] rockchip rk3399 video output breakage Jakob Unterwurzacher
2018-04-24 12:37 ` JeffyChen [this message]
2018-04-24 13:11   ` Jakob Unterwurzacher
2018-04-24 13:33     ` JeffyChen
2018-04-24 13:33       ` JeffyChen
2018-04-24 13:47       ` Jakob Unterwurzacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ADF24F3.6070106@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=jakob.unterwurzacher@theobroma-systems.com \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.