[PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

[PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

[Cleber Rosa]

This is a reply to an issue[1] reported by Peter, and while at it, an
update of the MAINTAINERS entry so other people now the status and
where to go for help with regards to the acceptance tests'
infrastructure.

[1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html

Cleber Rosa (2):
  Acceptance Tests: add standard clean up at test tearDown()
  Acceptance Tests: updates to the MAINTAINERS file

 MAINTAINERS                               | 6 +++---
 tests/acceptance/avocado_qemu/__init__.py | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.31.1

[PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

[Cleber Rosa]

The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.

But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.

This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..1e807e2e55 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
         for vm in self._vms.values():
             vm.shutdown()
         self._sd = None
+        super(Test, self).tearDown()
 
     def fetch_asset(self, name,
                     asset_hash=None, algorithm=None,
-- 
2.31.1

Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

[Willian Rampazzo]

On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> The avocado.Test class, used as the basis of the avocado_qemu.Test
> class, performs a clean of temporary directories up as part of its own
> tearDown() implementation.
>
> But the avocado_qemu.Test class is currently missing the same clean
> up, as it implemented its own tearDown() method without resorting to
> the upper class behavior.
>
> This brings avocado_qemu.Test behavior in sync with the standard
> avocado.Test behavior and prevents temporary directories from
> cluttering the test results directory (unless instructed to do so with
> Avocado's "--keep-tmp" option).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/acceptance/avocado_qemu/__init__.py | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown()

[Wainer dos Santos Moschetta]

Hi,

On 8/3/21 4:34 PM, Cleber Rosa wrote:
> The avocado.Test class, used as the basis of the avocado_qemu.Test
> class, performs a clean of temporary directories up as part of its own
> tearDown() implementation.
>
> But the avocado_qemu.Test class is currently missing the same clean
> up, as it implemented its own tearDown() method without resorting to
> the upper class behavior.
Good catch Peter!
>
> This brings avocado_qemu.Test behavior in sync with the standard
> avocado.Test behavior and prevents temporary directories from
> cluttering the test results directory (unless instructed to do so with
> Avocado's "--keep-tmp" option).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   tests/acceptance/avocado_qemu/__init__.py | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
> index 2c4fef3e14..1e807e2e55 100644
> --- a/tests/acceptance/avocado_qemu/__init__.py
> +++ b/tests/acceptance/avocado_qemu/__init__.py
> @@ -276,6 +276,7 @@ def tearDown(self):
>           for vm in self._vms.values():
>               vm.shutdown()
>           self._sd = None
> +        super(Test, self).tearDown()

Could you use the new form of super [1] to make the pylint happier?

[1] https://www.python.org/dev/peps/pep-3135/

Thanks!

- Wainer

>   
>       def fetch_asset(self, name,
>                       asset_hash=None, algorithm=None,

[PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Cleber Rosa]

The tests/acceptance directory is currently lacking a maintainer
entry, even though I've been performing that role (of course with help
from many others).  Thus, its status is, even more now, Maintained.

This also removes the currently broken Trello board link, which was
make unavailable unintentionally by a third party.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 37b1a8e442..d35b948e8d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile
 F: tests/tcg/Makefile.include
 
 Acceptance (Integration) Testing with the Avocado framework
-W: https://trello.com/b/6Qi1pxVn/avocado-qemu
-R: Cleber Rosa <crosa@redhat.com>
+M: Cleber Rosa <crosa@redhat.com>
 R: Philippe Mathieu-Daudé <philmd@redhat.com>
 R: Wainer dos Santos Moschetta <wainersm@redhat.com>
-S: Odd Fixes
+S: Maintained
+F: tests/Makefile.include
 F: tests/acceptance/
 
 Documentation
-- 
2.31.1

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Willian Rampazzo]

On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
>
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Philippe Mathieu-Daudé]

On 8/3/21 10:09 PM, Willian Rampazzo wrote:
> On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
>>
>> The tests/acceptance directory is currently lacking a maintainer
>> entry, even though I've been performing that role (of course with help
>> from many others).  Thus, its status is, even more now, Maintained.
>>
>> This also removes the currently broken Trello board link, which was
>> make unavailable unintentionally by a third party.
>>
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>  MAINTAINERS | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
> 
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Willian you could send an extra patch to add yourself a R: tag.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Willian Rampazzo]

On Wed, Aug 4, 2021 at 6:45 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 8/3/21 10:09 PM, Willian Rampazzo wrote:
> > On Tue, Aug 3, 2021 at 4:35 PM Cleber Rosa <crosa@redhat.com> wrote:
> >>
> >> The tests/acceptance directory is currently lacking a maintainer
> >> entry, even though I've been performing that role (of course with help
> >> from many others).  Thus, its status is, even more now, Maintained.
> >>
> >> This also removes the currently broken Trello board link, which was
> >> make unavailable unintentionally by a third party.
> >>
> >> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> >> ---
> >>  MAINTAINERS | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>
> Willian you could send an extra patch to add yourself a R: tag.

Ack!

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Wainer dos Santos Moschetta]

Hi,

On 8/3/21 4:34 PM, Cleber Rosa wrote:
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
yay!
>
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
I can still access the link. Anyway, maybe we could migrate the cards 
(not everything, just those which still make sense) to the GitLab's 
Issues tracker?
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   MAINTAINERS | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b1a8e442..d35b948e8d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile
>   F: tests/tcg/Makefile.include
>   
>   Acceptance (Integration) Testing with the Avocado framework
> -W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> -R: Cleber Rosa <crosa@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
>   R: Philippe Mathieu-Daudé <philmd@redhat.com>
>   R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> -S: Odd Fixes
> +S: Maintained
> +F: tests/Makefile.include
>   F: tests/acceptance/
>   
>   Documentation

Re: [PATCH 2/2] Acceptance Tests: updates to the MAINTAINERS file

[Thomas Huth]

On 03/08/2021 21.34, Cleber Rosa wrote:
> The tests/acceptance directory is currently lacking a maintainer
> entry, even though I've been performing that role (of course with help
> from many others).  Thus, its status is, even more now, Maintained.
> 
> This also removes the currently broken Trello board link, which was
> make unavailable unintentionally by a third party.
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   MAINTAINERS | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 37b1a8e442..d35b948e8d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3418,11 +3418,11 @@ F: tests/tcg/Makefile
>   F: tests/tcg/Makefile.include
>   
>   Acceptance (Integration) Testing with the Avocado framework
> -W: https://trello.com/b/6Qi1pxVn/avocado-qemu
> -R: Cleber Rosa <crosa@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
>   R: Philippe Mathieu-Daudé <philmd@redhat.com>
>   R: Wainer dos Santos Moschetta <wainersm@redhat.com>
> -S: Odd Fixes
> +S: Maintained
> +F: tests/Makefile.include

Not sure whether we really should add tests/Makefile.include in this 
section, since there are only a couple of lines in there that are related to 
the "acceptance" tests... Anyway:

Acked-by: Thomas Huth <thuth@redhat.com>

Cleber, now that the freeze period is over, could you collect the related 
patches on the list and send a pull request?

  Thomas

Re: [PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

[Peter Maydell]

On Tue, 3 Aug 2021 at 20:35, Cleber Rosa <crosa@redhat.com> wrote:
>
> This is a reply to an issue[1] reported by Peter, and while at it, an
> update of the MAINTAINERS entry so other people now the status and
> where to go for help with regards to the acceptance tests'
> infrastructure.
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html

Ping? I was reminded of this today, and it looks like
the acceptance tests are still wasting gigabytes of
everybody's disk space with non-cleaned-up tempfiles...

-- PMM

Re: [PATCH 0/2] Acceptance Tests: clean up of temporary dirs and MAINTAINERS entry

[Willian Rampazzo]

On Mon, Sep 20, 2021 at 10:59 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 3 Aug 2021 at 20:35, Cleber Rosa <crosa@redhat.com> wrote:
> >
> > This is a reply to an issue[1] reported by Peter, and while at it, an
> > update of the MAINTAINERS entry so other people now the status and
> > where to go for help with regards to the acceptance tests'
> > infrastructure.
> >
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg00349.html
>
> Ping? I was reminded of this today, and it looks like
> the acceptance tests are still wasting gigabytes of
> everybody's disk space with non-cleaned-up tempfiles...

Cleber will be out until next Wed. I took the bug fix patch and
changed it based on Wainer's comment:

https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html

>
> -- PMM
>