[PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Renesas new DMAEngine driver requests src/dst_addr_width

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
>> Laurent

Could you please check and give your Ack to this patch?

 sound/soc/sh/rcar/core.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index 907d480..c48d999 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct rsnd_dma *dma,
 	cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
 	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
 	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
+	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	dev_dbg(dev, "dma : %s %pad -> %pad\n",
 		dma_name, &cfg.src_addr, &cfg.dst_addr);
-- 
1.7.9.5

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Laurent Pinchart]

Hi Morimoto-san,

On Wednesday 16 July 2014 23:18:44 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Renesas new DMAEngine driver requests src/dst_addr_width
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> 
> >> Laurent
> 
> Could you please check and give your Ack to this patch?

What tree is the patch based on ? It doesn't apply on Takashi's latest master 
branch. I need a bit of context to review it.

>  sound/soc/sh/rcar/core.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
> index 907d480..c48d999 100644
> --- a/sound/soc/sh/rcar/core.c
> +++ b/sound/soc/sh/rcar/core.c
> @@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct
> rsnd_dma *dma, cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
>  	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
>  	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
> +	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> +	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> 
>  	dev_dbg(dev, "dma : %s %pad -> %pad\n",
>  		dma_name, &cfg.src_addr, &cfg.dst_addr);

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Kuninori Morimoto]

Hi Laurent

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > 
> > Renesas new DMAEngine driver requests src/dst_addr_width
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > 
> > >> Laurent
> > 
> > Could you please check and give your Ack to this patch?
> 
> What tree is the patch based on ? It doesn't apply on Takashi's latest master 
> branch. I need a bit of context to review it.

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git :: topic/rcar

or Gerrt's driver tree

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Laurent Pinchart]

Hi Morimoto-san,

On Monday 21 July 2014 16:55:41 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > Renesas new DMAEngine driver requests src/dst_addr_width
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > 
> > > >> Laurent
> > > 
> > > Could you please check and give your Ack to this patch?
> > 
> > What tree is the patch based on ? It doesn't apply on Takashi's latest
> > master branch. I need a bit of context to review it.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git ::
> topic/rcar
> 
> or Gerrt's driver tree

Of course :-)

I've tried to understand the driver and couldn't even find out which DMA 
controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't 
been able to confirm that from the source code. If the assumption is true the 
patch looks OK to me, but if you need a formal Acked-by then I'll need you to 
guide me through the driver I'm afraid.

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Kuninori Morimoto]

Hi Laurent

> > > What tree is the patch based on ? It doesn't apply on Takashi's latest
> > > master branch. I need a bit of context to review it.
(snip)
> I've tried to understand the driver and couldn't even find out which DMA 
> controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't 
> been able to confirm that from the source code. If the assumption is true the 
> patch looks OK to me, but if you need a formal Acked-by then I'll need you to 
> guide me through the driver I'm afraid.

Ahh I'm sorry about this confusion.
It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC)
The platform side is not upstreamed yet.
(Because it depends on rcar-dmac)

But, I posted RFC audio DMAC support patches which
was based on Ben's DMAC before.

    http://www.spinics.net/lists/linux-sh/msg32949.html

I can re-post this patch if all DMAC was ready

Best regards
---
Kuninori Morimoto

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Laurent Pinchart]

Hi Morimoto-san,

Thank you for the patch.

On Wednesday 16 July 2014 23:18:44 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Renesas new DMAEngine driver requests src/dst_addr_width
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> >> Laurent
> 
> Could you please check and give your Ack to this patch?
> 
>  sound/soc/sh/rcar/core.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
> index 907d480..c48d999 100644
> --- a/sound/soc/sh/rcar/core.c
> +++ b/sound/soc/sh/rcar/core.c
> @@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct
> rsnd_dma *dma, cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
>  	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
>  	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
> +	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> +	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
> 
>  	dev_dbg(dev, "dma : %s %pad -> %pad\n",
>  		dma_name, &cfg.src_addr, &cfg.dst_addr);

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Laurent Pinchart]

Hi Morimoto-san,

On Monday 21 July 2014 19:34:36 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > > > What tree is the patch based on ? It doesn't apply on Takashi's latest
> > > > master branch. I need a bit of context to review it.
> 
> (snip)
> 
> > I've tried to understand the driver and couldn't even find out which DMA
> > controller was used :-/ I suspect it's the audio peri-peri DMAC, but I
> > haven't been able to confirm that from the source code. If the assumption
> > is true the patch looks OK to me, but if you need a formal Acked-by then
> > I'll need you to guide me through the driver I'm afraid.
> 
> Ahh I'm sorry about this confusion.
> It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC)
> The platform side is not upstreamed yet.
> (Because it depends on rcar-dmac)
> 
> But, I posted RFC audio DMAC support patches which
> was based on Ben's DMAC before.
> 
>     http://www.spinics.net/lists/linux-sh/msg32949.html
> 
> I can re-post this patch if all DMAC was ready

No need to, that was enough. Thank you. I've acked the patch.

By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is 
there an easy (or at least not too difficult) way to do so with your audio 
driver ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 214 bytes --]

On Wed, Jul 16, 2014 at 11:18:44PM -0700, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Renesas new DMAEngine driver requests src/dst_addr_width

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

[Kuninori Morimoto]

Hi Laurent

> > I can re-post this patch if all DMAC was ready
> 
> No need to, that was enough. Thank you. I've acked the patch.
> 
> By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is 
> there an easy (or at least not too difficult) way to do so with your audio 
> driver ?

Thank you for your help.
Yes, me too :)

I re-try your v2 DMAC driver with sound driver today.
Then, I will post platform side patches to ML