All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com
Subject: Re: [PATCH v2 1/8] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name
Date: Mon, 21 Mar 2022 23:14:07 +0100	[thread overview]
Message-ID: <1836a22dbff076d4f49095c9d59cb05f@walle.cc> (raw)
In-Reply-To: <20220228111712.111737-2-tudor.ambarus@microchip.com>

Am 2022-02-28 12:17, schrieb Tudor Ambarus:
> The method is matching a flash_info entry by searching by name. Rename
> the method for better clarity.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Reviewed-by: Michael Walle <michael@walle.cc>

> ---
>  drivers/mtd/spi-nor/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 9014008e60b3..f3c359d03163 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2876,8 +2876,8 @@ void spi_nor_restore(struct spi_nor *nor)
>  }
>  EXPORT_SYMBOL_GPL(spi_nor_restore);
> 
> -static const struct flash_info *spi_nor_match_id(struct spi_nor *nor,
> -						 const char *name)
> +static const struct flash_info *spi_nor_match_name(struct spi_nor 
> *nor,
> +						   const char *name)
>  {
>  	unsigned int i, j;
> 
> @@ -2899,7 +2899,7 @@ static const struct flash_info
> *spi_nor_get_flash_info(struct spi_nor *nor,
>  	const struct flash_info *info = NULL;
> 
>  	if (name)
> -		info = spi_nor_match_id(nor, name);
> +		info = spi_nor_match_name(nor, name);
>  	/* Try to auto-detect if chip name wasn't specified or not found */
>  	if (!info)
>  		info = spi_nor_read_id(nor);

-- 
-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com
Subject: Re: [PATCH v2 1/8] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name
Date: Mon, 21 Mar 2022 23:14:07 +0100	[thread overview]
Message-ID: <1836a22dbff076d4f49095c9d59cb05f@walle.cc> (raw)
In-Reply-To: <20220228111712.111737-2-tudor.ambarus@microchip.com>

Am 2022-02-28 12:17, schrieb Tudor Ambarus:
> The method is matching a flash_info entry by searching by name. Rename
> the method for better clarity.
> 
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

Reviewed-by: Michael Walle <michael@walle.cc>

> ---
>  drivers/mtd/spi-nor/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
> index 9014008e60b3..f3c359d03163 100644
> --- a/drivers/mtd/spi-nor/core.c
> +++ b/drivers/mtd/spi-nor/core.c
> @@ -2876,8 +2876,8 @@ void spi_nor_restore(struct spi_nor *nor)
>  }
>  EXPORT_SYMBOL_GPL(spi_nor_restore);
> 
> -static const struct flash_info *spi_nor_match_id(struct spi_nor *nor,
> -						 const char *name)
> +static const struct flash_info *spi_nor_match_name(struct spi_nor 
> *nor,
> +						   const char *name)
>  {
>  	unsigned int i, j;
> 
> @@ -2899,7 +2899,7 @@ static const struct flash_info
> *spi_nor_get_flash_info(struct spi_nor *nor,
>  	const struct flash_info *info = NULL;
> 
>  	if (name)
> -		info = spi_nor_match_id(nor, name);
> +		info = spi_nor_match_name(nor, name);
>  	/* Try to auto-detect if chip name wasn't specified or not found */
>  	if (!info)
>  		info = spi_nor_read_id(nor);

-- 
-michael

  parent reply	other threads:[~2022-03-21 22:14 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 11:17 [PATCH v2 0/8] mtd: spi-nor: Rework Octal DTR methods Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-02-28 11:17 ` [PATCH v2 1/8] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 11:57   ` Pratyush Yadav
2022-03-21 11:57     ` Pratyush Yadav
2022-03-21 22:14   ` Michael Walle [this message]
2022-03-21 22:14     ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 2/8] mtd: spi-nor: Introduce spi_nor_match_id() Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:00   ` Pratyush Yadav
2022-03-21 12:00     ` Pratyush Yadav
2022-03-21 22:15   ` Michael Walle
2022-03-21 22:15     ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 3/8] mtd: spi-nor: core: Use auto-detection only once Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:14   ` Pratyush Yadav
2022-03-21 12:14     ` Pratyush Yadav
2022-03-21 12:50     ` Tudor.Ambarus
2022-03-21 12:50       ` Tudor.Ambarus
2022-03-21 17:42       ` Pratyush Yadav
2022-03-21 17:42         ` Pratyush Yadav
2022-03-21 22:38         ` Michael Walle
2022-03-21 22:38           ` Michael Walle
2022-03-30 18:50           ` Pratyush Yadav
2022-03-30 18:50             ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 4/8] mtd: spi-nor: core: Introduce method for RDID op Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:21   ` Pratyush Yadav
2022-03-21 12:21     ` Pratyush Yadav
2022-03-21 13:18     ` Tudor.Ambarus
2022-03-21 13:18       ` Tudor.Ambarus
2022-03-21 17:39       ` Pratyush Yadav
2022-03-21 17:39         ` Pratyush Yadav
2022-03-30  6:53         ` Tudor.Ambarus
2022-03-30  6:53           ` Tudor.Ambarus
2022-03-30 18:49           ` Pratyush Yadav
2022-03-30 18:49             ` Pratyush Yadav
2022-03-21 22:56   ` Michael Walle
2022-03-21 22:56     ` Michael Walle
2022-03-22  7:32     ` Pratyush Yadav
2022-03-22  7:32       ` Pratyush Yadav
2022-03-22  8:19       ` Michael Walle
2022-03-22  8:19         ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 5/8] mtd: spi-nor: manufacturers: Use spi_nor_read_id() core method Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:27   ` Pratyush Yadav
2022-03-21 12:27     ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 6/8] mtd: spi-nor: core: Add helpers to read/write any register Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 23:13   ` Michael Walle
2022-03-21 23:13     ` Michael Walle
2022-04-11  7:29     ` Tudor.Ambarus
2022-04-11  7:29       ` Tudor.Ambarus
2022-02-28 11:17 ` [PATCH v2 7/8] mtd: spi-nor: micron-st: Rework spi_nor_micron_octal_dtr_enable() Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:33   ` Pratyush Yadav
2022-03-21 12:33     ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 8/8] mtd: spi-nor: spansion: Rework spi_nor_cypress_octal_dtr_enable() Tudor Ambarus
2022-02-28 11:17   ` Tudor Ambarus
2022-03-21 12:34   ` Pratyush Yadav
2022-03-21 12:34     ` Pratyush Yadav
2022-03-21 13:19     ` Tudor.Ambarus
2022-03-21 13:19       ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1836a22dbff076d4f49095c9d59cb05f@walle.cc \
    --to=michael@walle.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.