From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <michael@walle.cc>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<vigneshr@ti.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <nicolas.ferre@microchip.com>
Subject: Re: [PATCH v2 7/8] mtd: spi-nor: micron-st: Rework spi_nor_micron_octal_dtr_enable()
Date: Mon, 21 Mar 2022 18:03:28 +0530 [thread overview]
Message-ID: <20220321123328.pmronanogv6oveut@ti.com> (raw)
In-Reply-To: <20220228111712.111737-8-tudor.ambarus@microchip.com>
On 28/02/22 01:17PM, Tudor Ambarus wrote:
> Introduce template operation to remove code duplication.
> Split spi_nor_micron_octal_dtr_enable() in spi_nor_micron_octal_dtr_en()
> and spi_nor_micron_octal_dtr_dis() as it no longer made sense to try to
> keep everything alltogether: too many "if (enable)" throughout the code,
> which made the code difficult to follow.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Will send my tested-by separately once I get a chance to test this.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
WARNING: multiple messages have this Message-ID (diff)
From: Pratyush Yadav <p.yadav@ti.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <michael@walle.cc>, <miquel.raynal@bootlin.com>, <richard@nod.at>,
<vigneshr@ti.com>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <nicolas.ferre@microchip.com>
Subject: Re: [PATCH v2 7/8] mtd: spi-nor: micron-st: Rework spi_nor_micron_octal_dtr_enable()
Date: Mon, 21 Mar 2022 18:03:28 +0530 [thread overview]
Message-ID: <20220321123328.pmronanogv6oveut@ti.com> (raw)
In-Reply-To: <20220228111712.111737-8-tudor.ambarus@microchip.com>
On 28/02/22 01:17PM, Tudor Ambarus wrote:
> Introduce template operation to remove code duplication.
> Split spi_nor_micron_octal_dtr_enable() in spi_nor_micron_octal_dtr_en()
> and spi_nor_micron_octal_dtr_dis() as it no longer made sense to try to
> keep everything alltogether: too many "if (enable)" throughout the code,
> which made the code difficult to follow.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Pratyush Yadav <p.yadav@ti.com>
Will send my tested-by separately once I get a chance to test this.
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-03-21 12:33 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 11:17 [PATCH v2 0/8] mtd: spi-nor: Rework Octal DTR methods Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-02-28 11:17 ` [PATCH v2 1/8] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 11:57 ` Pratyush Yadav
2022-03-21 11:57 ` Pratyush Yadav
2022-03-21 22:14 ` Michael Walle
2022-03-21 22:14 ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 2/8] mtd: spi-nor: Introduce spi_nor_match_id() Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:00 ` Pratyush Yadav
2022-03-21 12:00 ` Pratyush Yadav
2022-03-21 22:15 ` Michael Walle
2022-03-21 22:15 ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 3/8] mtd: spi-nor: core: Use auto-detection only once Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:14 ` Pratyush Yadav
2022-03-21 12:14 ` Pratyush Yadav
2022-03-21 12:50 ` Tudor.Ambarus
2022-03-21 12:50 ` Tudor.Ambarus
2022-03-21 17:42 ` Pratyush Yadav
2022-03-21 17:42 ` Pratyush Yadav
2022-03-21 22:38 ` Michael Walle
2022-03-21 22:38 ` Michael Walle
2022-03-30 18:50 ` Pratyush Yadav
2022-03-30 18:50 ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 4/8] mtd: spi-nor: core: Introduce method for RDID op Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:21 ` Pratyush Yadav
2022-03-21 12:21 ` Pratyush Yadav
2022-03-21 13:18 ` Tudor.Ambarus
2022-03-21 13:18 ` Tudor.Ambarus
2022-03-21 17:39 ` Pratyush Yadav
2022-03-21 17:39 ` Pratyush Yadav
2022-03-30 6:53 ` Tudor.Ambarus
2022-03-30 6:53 ` Tudor.Ambarus
2022-03-30 18:49 ` Pratyush Yadav
2022-03-30 18:49 ` Pratyush Yadav
2022-03-21 22:56 ` Michael Walle
2022-03-21 22:56 ` Michael Walle
2022-03-22 7:32 ` Pratyush Yadav
2022-03-22 7:32 ` Pratyush Yadav
2022-03-22 8:19 ` Michael Walle
2022-03-22 8:19 ` Michael Walle
2022-02-28 11:17 ` [PATCH v2 5/8] mtd: spi-nor: manufacturers: Use spi_nor_read_id() core method Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:27 ` Pratyush Yadav
2022-03-21 12:27 ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 6/8] mtd: spi-nor: core: Add helpers to read/write any register Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 23:13 ` Michael Walle
2022-03-21 23:13 ` Michael Walle
2022-04-11 7:29 ` Tudor.Ambarus
2022-04-11 7:29 ` Tudor.Ambarus
2022-02-28 11:17 ` [PATCH v2 7/8] mtd: spi-nor: micron-st: Rework spi_nor_micron_octal_dtr_enable() Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:33 ` Pratyush Yadav [this message]
2022-03-21 12:33 ` Pratyush Yadav
2022-02-28 11:17 ` [PATCH v2 8/8] mtd: spi-nor: spansion: Rework spi_nor_cypress_octal_dtr_enable() Tudor Ambarus
2022-02-28 11:17 ` Tudor Ambarus
2022-03-21 12:34 ` Pratyush Yadav
2022-03-21 12:34 ` Pratyush Yadav
2022-03-21 13:19 ` Tudor.Ambarus
2022-03-21 13:19 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220321123328.pmronanogv6oveut@ti.com \
--to=p.yadav@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.