From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: kieran.bingham+renesas@ideasonboard.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Date: Wed, 26 Sep 2018 15:53:25 +0300 [thread overview] Message-ID: <1865239.8JzXlkvomL@avalon> (raw) In-Reply-To: <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> Hi Thomas, On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote: > Hi, > > thanks for reviewing the patch and the one for rcar-du. Please also add > them to your tree. I took both patches in my tree. Thank you. > Am 26.09.18 um 14:14 schrieb Kieran Bingham: > > On 26/09/18 12:55, Thomas Zimmermann wrote: > >> This patch unifies the naming of DRM functions for reference counting > >> of struct drm_device. The resulting code is more aligned with the rest > >> of the Linux kernel interfaces. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > >> --- > >> > >> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index > >> 6ececad6f845..8554102a6ead 100644 > >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> drm_irq_uninstall(ddev); > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> > >> return 0; > >> } > >> > >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> > >> err_free_drm_dev: > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> return ret; > >> } > >> -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Thomas Zimmermann <tzimmermann@suse.de> Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, dri-devel@lists.freedesktop.org Subject: Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Date: Wed, 26 Sep 2018 15:53:25 +0300 [thread overview] Message-ID: <1865239.8JzXlkvomL@avalon> (raw) In-Reply-To: <2721d64e-f3a4-9e0a-3af8-dfec8b1bd90c@suse.de> Hi Thomas, On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote: > Hi, > > thanks for reviewing the patch and the one for rcar-du. Please also add > them to your tree. I took both patches in my tree. Thank you. > Am 26.09.18 um 14:14 schrieb Kieran Bingham: > > On 26/09/18 12:55, Thomas Zimmermann wrote: > >> This patch unifies the naming of DRM functions for reference counting > >> of struct drm_device. The resulting code is more aligned with the rest > >> of the Linux kernel interfaces. > >> > >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > >> --- > >> > >> drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index > >> 6ececad6f845..8554102a6ead 100644 > >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > >> @@ -194,7 +194,7 @@ static int shmob_drm_remove(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> drm_irq_uninstall(ddev); > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> > >> return 0; > >> } > >> > >> @@ -290,7 +290,7 @@ static int shmob_drm_probe(struct platform_device > >> *pdev) > >> drm_kms_helper_poll_fini(ddev); > >> drm_mode_config_cleanup(ddev); > >> > >> err_free_drm_dev: > >> - drm_dev_unref(ddev); > >> + drm_dev_put(ddev); > >> return ret; > >> } > >> -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-26 19:06 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-26 11:55 [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put Thomas Zimmermann 2018-09-26 11:55 ` Thomas Zimmermann 2018-09-26 12:14 ` Kieran Bingham 2018-09-26 12:14 ` Kieran Bingham 2018-09-26 12:26 ` Thomas Zimmermann 2018-09-26 12:26 ` Thomas Zimmermann 2018-09-26 12:53 ` Laurent Pinchart [this message] 2018-09-26 12:53 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1865239.8JzXlkvomL@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.