All of lore.kernel.org
 help / color / mirror / Atom feed
* [B.A.T.M.A.N.] no able to switch routing algo to V ?
@ 2016-05-07 14:08 contact
  2016-05-07 14:18 ` Sven Eckelmann
  0 siblings, 1 reply; 17+ messages in thread
From: contact @ 2016-05-07 14:08 UTC (permalink / raw)
  To: The list for a Better Approach To Mobile Ad-hoc Networking

Hello,

I just got openwrt 15.05.1 with batman-adv 2016.1 on 3 picostation HP, 
this time a selected before the build of openwrt batman V option, I can 
see it when it ask for available routing algo ,

root@OpenWrt:/etc/init.d# cat /sys/kernel/debug/batman_adv/routing_algos
Available routing algorithms:
  * BATMAN_IV
  * BATMAN_V

but when I do :

echo BATMAN_V > /sys/module/batman_adv/parameters/routing_algo

It does nothing, still on BATMAN_IV during session and on reboot ?

sysctl -a does not show any routing_algoritms param for batman-adv ?

Best Regards,

Laurent

^ permalink raw reply	[flat|nested] 17+ messages in thread
* [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix double neigh_node_put in batadv_v_ogm_route_update
@ 2016-05-06 20:27 Sven Eckelmann
  2016-05-07 12:07 ` Marek Lindner
  0 siblings, 1 reply; 17+ messages in thread
From: Sven Eckelmann @ 2016-05-06 20:27 UTC (permalink / raw)
  To: b.a.t.m.a.n

The router is put down twice when it was non-NULL and either orig_ifinfo is
NULL afterwards or batman-adv receives a packet with the same sequence
number. This will end up in a use-after-free when the batadv_neigh_node is
removed because the reference counter ended up too early at 0.

Fixes: 667996ebeab4 ("batman-adv: OGMv2 - implement originators logic")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
It looks like this bug was solved in next/master by refactoring in
30c96bc7870f ("batman-adv: move and restructure batadv_v_ogm_forward")

only compile tested. Please add so many reported by as you want - 
just don't know it it is *the* bug and who actually reported it.
---
 net/batman-adv/bat_v_ogm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
index d9bcbe6..91df28a 100644
--- a/net/batman-adv/bat_v_ogm.c
+++ b/net/batman-adv/bat_v_ogm.c
@@ -529,8 +529,10 @@ static void batadv_v_ogm_route_update(struct batadv_priv *bat_priv,
 		goto out;
 	}
 
-	if (router)
+	if (router) {
 		batadv_neigh_node_put(router);
+		router = NULL;
+	}
 
 	/* Update routes, and check if the OGM is from the best next hop */
 	batadv_v_ogm_orig_update(bat_priv, orig_node, neigh_node, ogm2,
-- 
2.8.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread
end of thread, other threads:[~2016-05-07 22:40 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-07 14:08 [B.A.T.M.A.N.] no able to switch routing algo to V ? contact
2016-05-07 14:18 ` Sven Eckelmann
2016-05-07 16:04   ` contact
2016-05-07 16:28     ` Sven Eckelmann
2016-05-07 16:42       ` contact
2016-05-07 16:44         ` Sven Eckelmann
2016-05-07 16:51           ` contact
2016-05-07 16:53             ` Marek Lindner
2016-05-07 16:59               ` contact
2016-05-07 17:01                 ` Marek Lindner
2016-05-07 17:06                   ` contact
2016-05-07 18:09                     ` contact
2016-05-07 18:45                       ` contact
2016-05-07 22:40                         ` Marek Lindner
2016-05-07 16:55             ` Sven Eckelmann
  -- strict thread matches above, loose matches on Subject: below --
2016-05-06 20:27 [B.A.T.M.A.N.] [PATCH maint] batman-adv: Fix double neigh_node_put in batadv_v_ogm_route_update Sven Eckelmann
2016-05-07 12:07 ` Marek Lindner
2016-05-07 12:29   ` [B.A.T.M.A.N.] no able to switch routing algo to V ? contact
2016-05-07 13:14     ` Sven Eckelmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.