All of lore.kernel.org
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
Date: Tue, 05 Sep 2017 16:25:21 +0300	[thread overview]
Message-ID: <188621504617921@web52g.yandex.ru> (raw)
In-Reply-To: <d0cbdcb29a280665736ccc4f9441feeebe22f337.1502526524.git.arvind.yadav.cs@gmail.com>

Hi Arvind

12.08.2017, 11:38, "Arvind Yadav" <arvind.yadav.cs@gmail.com>:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Looks good to me, thank you
kernel-janitors@ please queue this up

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

> ---
>  drivers/w1/masters/ds2490.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
> index 46ccb2f..a02da9a 100644
> --- a/drivers/w1/masters/ds2490.c
> +++ b/drivers/w1/masters/ds2490.c
> @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf)
>          kfree(dev);
>  }
>
> -static struct usb_device_id ds_id_table [] = {
> +static const struct usb_device_id ds_id_table[] = {
>          { USB_DEVICE(0x04fa, 0x2490) },
>          { },
>  };
> --
> 2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error
Date: Tue, 05 Sep 2017 13:25:21 +0000	[thread overview]
Message-ID: <188621504617921@web52g.yandex.ru> (raw)
In-Reply-To: <d0cbdcb29a280665736ccc4f9441feeebe22f337.1502526524.git.arvind.yadav.cs@gmail.com>

Hi Arvind

12.08.2017, 11:38, "Arvind Yadav" <arvind.yadav.cs@gmail.com>:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Looks good to me, thank you
kernel-janitors@ please queue this up

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

> ---
>  drivers/w1/masters/ds2490.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1/masters/ds2490.c
> index 46ccb2f..a02da9a 100644
> --- a/drivers/w1/masters/ds2490.c
> +++ b/drivers/w1/masters/ds2490.c
> @@ -1088,7 +1088,7 @@ static void ds_disconnect(struct usb_interface *intf)
>          kfree(dev);
>  }
>
> -static struct usb_device_id ds_id_table [] = {
> +static const struct usb_device_id ds_id_table[] = {
>          { USB_DEVICE(0x04fa, 0x2490) },
>          { },
>  };
> --
> 2.7.4

  reply	other threads:[~2017-09-05 13:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-12  8:35 [PATCH] drm: udl: constify usb_device_id Arvind Yadav
2017-08-12  8:38 ` [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error Arvind Yadav
2017-09-05 13:25   ` Evgeniy Polyakov [this message]
2017-09-05 13:25     ` Evgeniy Polyakov
2017-08-12  8:39 ` [PATCH] watchdog: pcwd_usb: constify usb_device_id Arvind Yadav
2017-08-14 14:49   ` Guenter Roeck
2017-08-14 14:12 ` [PATCH] drm: udl: " Daniel Vetter
2017-08-14 14:12   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=188621504617921@web52g.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.