All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: airlied@linux.ie, airlied@redhat.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: udl: constify usb_device_id
Date: Mon, 14 Aug 2017 16:12:37 +0200	[thread overview]
Message-ID: <20170814141237.nkxzuligzp35ovyt@phenom.ffwll.local> (raw)
In-Reply-To: <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com>

On Sat, Aug 12, 2017 at 02:05:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index cd8b017..2877afc 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -118,7 +118,7 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>   * which is compatible with all known USB 2.0 era graphics chips and firmware,
>   * but allows DisplayLink to increment those for any future incompatible chips
>   */
> -static struct usb_device_id id_table[] = {
> +static const struct usb_device_id id_table[] = {
>  	{.idVendor = 0x17e9, .bInterfaceClass = 0xff,
>  	 .bInterfaceSubClass = 0x00,
>  	 .bInterfaceProtocol = 0x00,
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: airlied@redhat.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: udl: constify usb_device_id
Date: Mon, 14 Aug 2017 16:12:37 +0200	[thread overview]
Message-ID: <20170814141237.nkxzuligzp35ovyt@phenom.ffwll.local> (raw)
In-Reply-To: <22fa8ca67a6d4a59997f463bf241ed56596fbcfa.1502526524.git.arvind.yadav.cs@gmail.com>

On Sat, Aug 12, 2017 at 02:05:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thanks.
-Daniel

> ---
>  drivers/gpu/drm/udl/udl_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index cd8b017..2877afc 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -118,7 +118,7 @@ static void udl_usb_disconnect(struct usb_interface *interface)
>   * which is compatible with all known USB 2.0 era graphics chips and firmware,
>   * but allows DisplayLink to increment those for any future incompatible chips
>   */
> -static struct usb_device_id id_table[] = {
> +static const struct usb_device_id id_table[] = {
>  	{.idVendor = 0x17e9, .bInterfaceClass = 0xff,
>  	 .bInterfaceSubClass = 0x00,
>  	 .bInterfaceProtocol = 0x00,
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-08-14 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-12  8:35 [PATCH] drm: udl: constify usb_device_id Arvind Yadav
2017-08-12  8:38 ` [PATCH] w1: ds2490: constify usb_device_id and fix space before '[' error Arvind Yadav
2017-09-05 13:25   ` Evgeniy Polyakov
2017-09-05 13:25     ` Evgeniy Polyakov
2017-08-12  8:39 ` [PATCH] watchdog: pcwd_usb: constify usb_device_id Arvind Yadav
2017-08-14 14:49   ` Guenter Roeck
2017-08-14 14:12 ` Daniel Vetter [this message]
2017-08-14 14:12   ` [PATCH] drm: udl: " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170814141237.nkxzuligzp35ovyt@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.