From: Paul Mackerras <paulus@samba.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/15] perf_counter: unify and fix delayed counter wakeup
Date: Tue, 31 Mar 2009 16:45:23 +1100 [thread overview]
Message-ID: <18897.44531.88862.844627@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20090330171023.153932974@chello.nl>
Peter Zijlstra writes:
> +void perf_counter_wakeup(struct perf_counter *counter)
> +{
> + struct perf_mmap_data *data;
> +
> + rcu_read_lock();
> + data = rcu_dereference(counter->data);
> + if (data) {
> + (void)atomic_xchg(&data->wakeup, POLL_IN);
Really just a nit, but how is this atomic_xchg any different from
atomic_set(&data->wakeup, POLL_IN) aside from being slower?
Paul.
next prev parent reply other threads:[~2009-03-31 5:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 17:07 [PATCH 00/15] pending perf_counter bits Peter Zijlstra
2009-03-30 17:07 ` [PATCH 01/15] perf_counter: unify and fix delayed counter wakeup Peter Zijlstra
2009-03-31 5:45 ` Paul Mackerras [this message]
2009-03-31 6:37 ` Peter Zijlstra
2009-04-01 9:04 ` Ingo Molnar
2009-04-01 10:12 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 02/15] perf_counter: fix update_userpage() Peter Zijlstra
2009-04-01 10:12 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 03/15] perf_counter: kerneltop: simplify data_head read Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 04/15] perf_counter: executable mmap() information Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 05/15] perf_counter: kerneltop: parse the mmap data stream Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 06/15] perf_counter: powerpc: only reserve PMU hardware when we need it Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Paul Mackerras
2009-03-30 17:07 ` [PATCH 07/15] perf_counter: make it possible for hw_perf_counter_init to return error codes Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Paul Mackerras
2009-03-30 17:07 ` [PATCH 08/15] perf_counter: x86: proper error propagation for the x86 hw_perf_counter_init() Peter Zijlstra
2009-04-01 10:13 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 09/15] perf_counter tools: optionally scale counter values in perfstat mode Peter Zijlstra
2009-04-01 9:39 ` Ingo Molnar
2009-04-01 10:50 ` Paul Mackerras
2009-04-01 10:14 ` [tip:perfcounters/core] " Paul Mackerras
2009-03-30 17:07 ` [PATCH 10/15] perf_counter: small cleanup of the output routines Peter Zijlstra
2009-04-01 10:14 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 11/15] perf_counter: re-arrange the perf_event_type Peter Zijlstra
2009-04-01 10:14 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 12/15] pref_counter: kerneltop: update event_types Peter Zijlstra
2009-04-01 10:14 ` [tip:perfcounters/core] perf_counter tools: " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 13/15] perf_counter: provide generic callchain bits Peter Zijlstra
2009-03-31 6:12 ` Paul Mackerras
2009-03-31 6:39 ` Peter Zijlstra
2009-03-31 7:24 ` Corey Ashford
2009-03-31 8:43 ` Peter Zijlstra
2009-03-31 9:09 ` Paul Mackerras
2009-03-31 9:12 ` Paul Mackerras
2009-03-31 14:00 ` Peter Zijlstra
2009-03-31 17:11 ` Corey Ashford
2009-04-01 3:48 ` Paul Mackerras
2009-04-01 7:59 ` Peter Zijlstra
2009-04-01 8:45 ` Paul Mackerras
2009-04-01 10:00 ` Ingo Molnar
2009-04-01 11:53 ` Paul Mackerras
2009-04-01 23:25 ` Corey Ashford
2009-04-02 6:43 ` Peter Zijlstra
2009-04-02 7:41 ` Peter Zijlstra
2009-04-02 9:10 ` Paul Mackerras
2009-04-02 9:14 ` Peter Zijlstra
2009-04-01 10:14 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 14/15] perf_counter: x86: callchain support Peter Zijlstra
2009-04-01 10:14 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-30 17:07 ` [PATCH 15/15] perf_counter: pmc arbitration Peter Zijlstra
2009-04-01 10:15 ` [tip:perfcounters/core] " Peter Zijlstra
2009-03-31 5:43 ` [PATCH 00/15] pending perf_counter bits Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18897.44531.88862.844627@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.