From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Jan Kara <jack@suse.cz>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
KVM list <kvm@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-nvdimm <linux-nvdimm@ml01.01.org>,
Ross Zwisler <ross.zwisler@intel.com>,
linux-kernel@vger.kernel.org,
Qemu Developers <qemu-devel@nongnu.org>,
Linux MM <linux-mm@kvack.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Nitesh Narayan Lal <nilal@redhat.com>
Subject: Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files
Date: Thu, 12 Oct 2017 17:27:28 -0400 (EDT) [thread overview]
Message-ID: <1893461099.19940340.1507843648978.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4jdWUeoF1PxWhXx3vciLmOL9AyW_yPq0W6DRFe3RP2fkA@mail.gmail.com>
>
> On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta <pagupta@redhat.com> wrote:
> > This patch moves common code to base header files
> > so that it can be used for both ACPI pmem and VIRTIO pmem
> > drivers. More common code needs to be moved out in future
> > based on functionality required for virtio_pmem driver and
> > coupling of code with existing ACPI pmem driver.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> [..]
> > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h
> > new file mode 100644
> > index 000000000000..e2e718c74b3f
> > --- /dev/null
> > +++ b/include/linux/pmem_common.h
>
> This should be a common C file, not a header.
Sure! will create a common C file to put all the common code there.
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Jan Kara <jack@suse.cz>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
KVM list <kvm@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
linux-nvdimm <linux-nvdimm@ml01.01.org>,
Ross Zwisler <ross.zwisler@intel.com>,
linux-kernel@vger.kernel.org,
Qemu Developers <qemu-devel@nongnu.org>,
Linux MM <linux-mm@kvack.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Nitesh Narayan Lal <nilal@redhat.com>
Subject: Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files
Date: Thu, 12 Oct 2017 17:27:28 -0400 (EDT) [thread overview]
Message-ID: <1893461099.19940340.1507843648978.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4jdWUeoF1PxWhXx3vciLmOL9AyW_yPq0W6DRFe3RP2fkA@mail.gmail.com>
>
> On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta <pagupta@redhat.com> wrote:
> > This patch moves common code to base header files
> > so that it can be used for both ACPI pmem and VIRTIO pmem
> > drivers. More common code needs to be moved out in future
> > based on functionality required for virtio_pmem driver and
> > coupling of code with existing ACPI pmem driver.
> >
> > Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
> [..]
> > diff --git a/include/linux/pmem_common.h b/include/linux/pmem_common.h
> > new file mode 100644
> > index 000000000000..e2e718c74b3f
> > --- /dev/null
> > +++ b/include/linux/pmem_common.h
>
> This should be a common C file, not a header.
Sure! will create a common C file to put all the common code there.
>
>
next prev parent reply other threads:[~2017-10-12 21:27 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:50 [RFC 0/2] KVM "fake DAX" device flushing Pankaj Gupta
2017-10-12 15:50 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 15:50 ` Pankaj Gupta
2017-10-12 15:50 ` [RFC 1/2] pmem: Move reusable code to base header files Pankaj Gupta
2017-10-12 15:50 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 15:50 ` Pankaj Gupta
2017-10-12 20:42 ` Dan Williams
2017-10-12 20:42 ` [Qemu-devel] " Dan Williams
2017-10-12 20:42 ` Dan Williams
2017-10-12 21:27 ` Pankaj Gupta [this message]
2017-10-12 21:27 ` [Qemu-devel] " Pankaj Gupta
[not found] ` <20171012155027.3277-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-12 15:50 ` [RFC 2/2] KVM: add virtio-pmem driver Pankaj Gupta
2017-10-12 15:50 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 15:50 ` Pankaj Gupta
2017-10-12 15:50 ` Pankaj Gupta
2017-10-12 20:51 ` Dan Williams
2017-10-12 20:51 ` [Qemu-devel] " Dan Williams
2017-10-12 20:51 ` Dan Williams
2017-10-12 21:25 ` Pankaj Gupta
2017-10-12 21:25 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 21:25 ` Pankaj Gupta
2017-10-12 21:54 ` Dan Williams
2017-10-12 21:54 ` [Qemu-devel] " Dan Williams
2017-10-12 21:54 ` Dan Williams
[not found] ` <CAPcyv4gkri7t+3Unf0sc9AHMnz-v9G_qV_bJppLjUUNAn7drrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-12 22:18 ` Pankaj Gupta
2017-10-12 22:18 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 22:18 ` Pankaj Gupta
2017-10-12 22:18 ` Pankaj Gupta
2017-10-12 22:27 ` Rik van Riel
2017-10-12 22:27 ` [Qemu-devel] " Rik van Riel
2017-10-12 22:27 ` Rik van Riel
2017-10-12 22:27 ` Rik van Riel
2017-10-12 22:27 ` Rik van Riel
2017-10-12 22:39 ` Pankaj Gupta
2017-10-12 22:39 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 22:39 ` Pankaj Gupta
2017-10-12 22:52 ` Pankaj Gupta
2017-10-12 22:52 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 22:52 ` Pankaj Gupta
2017-10-12 22:59 ` Dan Williams
2017-10-12 22:59 ` [Qemu-devel] " Dan Williams
2017-10-12 22:59 ` Dan Williams
2017-10-12 23:07 ` Pankaj Gupta
2017-10-12 23:07 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 23:07 ` Pankaj Gupta
2017-10-13 9:44 ` Stefan Hajnoczi
2017-10-13 9:44 ` [Qemu-devel] " Stefan Hajnoczi
2017-10-13 9:44 ` Stefan Hajnoczi
2017-10-13 10:48 ` Pankaj Gupta
2017-10-13 10:48 ` [Qemu-devel] " Pankaj Gupta
2017-10-13 10:48 ` Pankaj Gupta
[not found] ` <24301306.20068579.1507891695416.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-16 14:47 ` Stefan Hajnoczi
2017-10-16 14:47 ` [Qemu-devel] " Stefan Hajnoczi
2017-10-16 14:47 ` Stefan Hajnoczi
2017-10-16 14:47 ` Stefan Hajnoczi
2017-10-16 15:58 ` Dan Williams
2017-10-16 15:58 ` [Qemu-devel] " Dan Williams
2017-10-16 15:58 ` Dan Williams
2017-10-16 17:04 ` Pankaj Gupta
2017-10-16 17:04 ` [Qemu-devel] " Pankaj Gupta
2017-10-16 17:04 ` Pankaj Gupta
[not found] ` <20171013094431.GA27308-lxVrvc10SDRcolVlb+j0YCZi+YwRKgec@public.gmane.org>
2017-10-13 15:25 ` Dan Williams
2017-10-13 15:25 ` [Qemu-devel] " Dan Williams
2017-10-13 15:25 ` Dan Williams
2017-10-13 15:25 ` Dan Williams
[not found] ` <20171012155027.3277-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-17 7:16 ` Christoph Hellwig
2017-10-17 7:16 ` [Qemu-devel] " Christoph Hellwig
2017-10-17 7:16 ` Christoph Hellwig
2017-10-17 7:16 ` Christoph Hellwig
2017-10-17 7:40 ` [Qemu-devel] " Pankaj Gupta
2017-10-17 7:40 ` Pankaj Gupta
2017-10-17 8:02 ` Christoph Hellwig
2017-10-17 8:02 ` Christoph Hellwig
2017-10-17 8:30 ` Pankaj Gupta
2017-10-17 8:30 ` Pankaj Gupta
2017-10-18 13:03 ` Stefan Hajnoczi
2017-10-18 13:03 ` Stefan Hajnoczi
2017-10-18 15:51 ` Dan Williams
2017-10-18 15:51 ` Dan Williams
[not found] ` <CAPcyv4h6aFkyHhh4R4DTznbSCLf9CuBoszk0Q1gB5EKNcp_SeQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 8:01 ` Stefan Hajnoczi
2017-10-19 8:01 ` Stefan Hajnoczi
2017-10-19 8:01 ` Stefan Hajnoczi
2017-10-19 8:01 ` Christoph Hellwig
2017-10-19 8:01 ` Christoph Hellwig
[not found] ` <20171019080149.GB10089-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-10-19 18:21 ` Dan Williams
2017-10-19 18:21 ` Dan Williams
2017-10-19 18:21 ` Dan Williams
[not found] ` <CAPcyv4j=Cdp68C15HddKaErpve2UGRfSTiL6bHiS=3gQybz9pg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-20 8:00 ` Christoph Hellwig
2017-10-20 8:00 ` Christoph Hellwig
2017-10-20 8:00 ` Christoph Hellwig
[not found] ` <20171020080049.GA25471-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-10-20 15:05 ` Dan Williams
2017-10-20 15:05 ` Dan Williams
2017-10-20 15:05 ` Dan Williams
2017-10-20 16:06 ` Christoph Hellwig
2017-10-20 16:06 ` Christoph Hellwig
2017-10-20 16:11 ` Dan Williams
2017-10-20 16:11 ` Dan Williams
2017-10-12 15:50 ` [RFC] QEMU: Add virtio pmem device Pankaj Gupta
2017-10-12 15:50 ` [Qemu-devel] " Pankaj Gupta
2017-10-12 15:50 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1893461099.19940340.1507843648978.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.zwisler@intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.