* [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
@ 2020-12-26 8:56 Chenyang Li
2020-12-26 13:16 ` Paul Menzel
2021-01-04 17:08 ` Alex Deucher
0 siblings, 2 replies; 6+ messages in thread
From: Chenyang Li @ 2020-12-26 8:56 UTC (permalink / raw)
To: Alex Deucher, amd-gfx, Paul Menzel, Chen Guchun, Christian König
Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index ee9480d14cbc..86cfb3d55477 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -21,7 +21,7 @@
*
*/
-#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
+#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
#define _AMDGPU_TRACE_H_
#include <linux/stringify.h>
--
2.29.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
2020-12-26 8:56 [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition Chenyang Li
@ 2020-12-26 13:16 ` Paul Menzel
2020-12-27 9:38 ` Christian König
2021-01-04 17:08 ` Alex Deucher
1 sibling, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2020-12-26 13:16 UTC (permalink / raw)
To: Chenyang Li; +Cc: Alex Deucher, Christian König, amd-gfx, Chen Guchun
Dear 李晨阳,
Am 26.12.20 um 09:56 schrieb Chenyang Li:
> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>
> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index ee9480d14cbc..86cfb3d55477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -21,7 +21,7 @@
> *
> */
>
> -#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
> +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
> #define _AMDGPU_TRACE_H_
>
> #include <linux/stringify.h>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
PS: Next time, for patch iterations, you should include the version in
the tag: PATCH v2. The switch `-v` (`--reroll-count`) helps with that:
git format-patch -1 -v 2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
2020-12-26 13:16 ` Paul Menzel
@ 2020-12-27 9:38 ` Christian König
2020-12-27 10:53 ` Paul Menzel
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2020-12-27 9:38 UTC (permalink / raw)
To: Paul Menzel, Chenyang Li
Cc: Alex Deucher, Christian König, amd-gfx, Chen Guchun
Am 26.12.20 um 14:16 schrieb Paul Menzel:
> Dear 李晨阳,
>
>
> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>
>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
Well this Fixes tag is superfluous/misleading and should probably be
removed.
Why was that added?
Christian.
>> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
>> index ee9480d14cbc..86cfb3d55477 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
>> @@ -21,7 +21,7 @@
>> *
>> */
>> -#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
>> +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
>> #define _AMDGPU_TRACE_H_
>> #include <linux/stringify.h>
>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
>
> Kind regards,
>
> Paul
>
>
> PS: Next time, for patch iterations, you should include the version in
> the tag: PATCH v2. The switch `-v` (`--reroll-count`) helps with that:
>
> git format-patch -1 -v 2
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
2020-12-27 9:38 ` Christian König
@ 2020-12-27 10:53 ` Paul Menzel
2020-12-29 10:12 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2020-12-27 10:53 UTC (permalink / raw)
To: Christian König
Cc: Alex Deucher, Chenyang Li, Chen Guchun, amd-gfx, Christina König
Dear Christian,
Am 27.12.20 um 10:38 schrieb Christian König:
> Am 26.12.20 um 14:16 schrieb Paul Menzel:
>> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>>
>>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
>
> Well this Fixes tag is superfluous/misleading and should probably be
> removed.
Why is it misleading?
> Why was that added?
I asked for that, because that is the commit introducing the issue, and
with that tag it’s more likely to picked for the stable series.
[…]
Kind regards,
Paul
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
2020-12-27 10:53 ` Paul Menzel
@ 2020-12-29 10:12 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2020-12-29 10:12 UTC (permalink / raw)
To: Paul Menzel, Christian König
Cc: Alex Deucher, Chenyang Li, Chen Guchun, amd-gfx
Am 27.12.20 um 11:53 schrieb Paul Menzel:
> Dear Christian,
>
>
> Am 27.12.20 um 10:38 schrieb Christian König:
>> Am 26.12.20 um 14:16 schrieb Paul Menzel:
>
>>> Am 26.12.20 um 09:56 schrieb Chenyang Li:
>>>> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>>>>
>>>> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
>>
>> Well this Fixes tag is superfluous/misleading and should probably be
>> removed.
>
> Why is it misleading?
The purpose of a Fixes tag is to distinct into which stable sources a
patch should be added.
E.g. if somebody maintains a backport which has the originally buggy
patch then he can figure out that he needs this one as well.
But since this problem is there for as long as the driver existed that
is pretty much superfluous and confusing.
>
>> Why was that added?
>
> I asked for that, because that is the commit introducing the issue,
> and with that tag it’s more likely to picked for the stable series.
Ah, yes that is a rather good idea. But we should probably use a "CC:
stable@kernel.org" tag instead since this patch can be added pretty much
everywhere.
Thanks,
Christian.
>
> […]
>
>
> Kind regards,
>
> Paul
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition
2020-12-26 8:56 [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition Chenyang Li
2020-12-26 13:16 ` Paul Menzel
@ 2021-01-04 17:08 ` Alex Deucher
1 sibling, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2021-01-04 17:08 UTC (permalink / raw)
To: Chenyang Li
Cc: Alex Deucher, Paul Menzel, Chen Guchun, amd-gfx list,
Christian König
Applied. Thanks!
Alex
On Sun, Dec 27, 2020 at 3:56 PM Chenyang Li <lichenyang@loongson.cn> wrote:
>
> Add an underscore in amdgpu_trace.h line 24 "_AMDGPU_TRACE_H".
>
> Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)")
> Signed-off-by: Chenyang Li <lichenyang@loongson.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index ee9480d14cbc..86cfb3d55477 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -21,7 +21,7 @@
> *
> */
>
> -#if !defined(_AMDGPU_TRACE_H) || defined(TRACE_HEADER_MULTI_READ)
> +#if !defined(_AMDGPU_TRACE_H_) || defined(TRACE_HEADER_MULTI_READ)
> #define _AMDGPU_TRACE_H_
>
> #include <linux/stringify.h>
> --
> 2.29.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-04 17:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 8:56 [PATCH] drm/amdgpu: Fix macro name _AMDGPU_TRACE_H_ in preprocessor if condition Chenyang Li
2020-12-26 13:16 ` Paul Menzel
2020-12-27 9:38 ` Christian König
2020-12-27 10:53 ` Paul Menzel
2020-12-29 10:12 ` Christian König
2021-01-04 17:08 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.