* [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed
@ 2020-02-24 15:36 Nicolas Saenz Julienne
2020-02-24 16:28 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Saenz Julienne @ 2020-02-24 15:36 UTC (permalink / raw)
To: Doug Berger, Florian Fainelli, David S. Miller, Stefan Wahren
Cc: Nicolas Saenz Julienne, bcm-kernel-feedback-list, netdev, linux-kernel
Outdated Raspberry Pi 4 firmware might configure the external PHY as
rgmii although the kernel currently sets it as rgmii-rxid. This makes
connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
explicitly clear that bit whenever we don't need it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
---
drivers/net/ethernet/broadcom/genet/bcmmii.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 6392a2530183..10244941a7a6 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -294,6 +294,7 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
*/
if (priv->ext_phy) {
reg = bcmgenet_ext_readl(priv, EXT_RGMII_OOB_CTRL);
+ reg &= ~ID_MODE_DIS;
reg |= id_mode_dis;
if (GENET_IS_V1(priv) || GENET_IS_V2(priv) || GENET_IS_V3(priv))
reg |= RGMII_MODE_EN_V123;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed
2020-02-24 15:36 [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed Nicolas Saenz Julienne
@ 2020-02-24 16:28 ` Leon Romanovsky
2020-02-24 16:30 ` Nicolas Saenz Julienne
0 siblings, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2020-02-24 16:28 UTC (permalink / raw)
To: Nicolas Saenz Julienne
Cc: Doug Berger, Florian Fainelli, David S. Miller, Stefan Wahren,
bcm-kernel-feedback-list, netdev, linux-kernel
On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote:
> Outdated Raspberry Pi 4 firmware might configure the external PHY as
> rgmii although the kernel currently sets it as rgmii-rxid. This makes
> connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
> explicitly clear that bit whenever we don't need it.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
The expectation is that Fixes line comes before SOB line.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed
2020-02-24 16:28 ` Leon Romanovsky
@ 2020-02-24 16:30 ` Nicolas Saenz Julienne
2020-02-24 17:23 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Saenz Julienne @ 2020-02-24 16:30 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Doug Berger, Florian Fainelli, David S. Miller, Stefan Wahren,
bcm-kernel-feedback-list, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
On Mon, 2020-02-24 at 18:28 +0200, Leon Romanovsky wrote:
> On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote:
> > Outdated Raspberry Pi 4 firmware might configure the external PHY as
> > rgmii although the kernel currently sets it as rgmii-rxid. This makes
> > connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
> > explicitly clear that bit whenever we don't need it.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
>
> The expectation is that Fixes line comes before SOB line.
Ouch, sorry for that.
I'll edit that on v2.
Regards,
Nicolas
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed
2020-02-24 16:30 ` Nicolas Saenz Julienne
@ 2020-02-24 17:23 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-02-24 17:23 UTC (permalink / raw)
To: Nicolas Saenz Julienne, Leon Romanovsky
Cc: Doug Berger, Florian Fainelli, David S. Miller, Stefan Wahren,
bcm-kernel-feedback-list, netdev, linux-kernel
On 2/24/20 8:30 AM, Nicolas Saenz Julienne wrote:
> On Mon, 2020-02-24 at 18:28 +0200, Leon Romanovsky wrote:
>> On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote:
>>> Outdated Raspberry Pi 4 firmware might configure the external PHY as
>>> rgmii although the kernel currently sets it as rgmii-rxid. This makes
>>> connections unreliable as ID_MODE_DIS is left enabled. To avoid this,
>>> explicitly clear that bit whenever we don't need it.
>>>
>>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>>> Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support")
>>
>> The expectation is that Fixes line comes before SOB line.
>
> Ouch, sorry for that.
>
> I'll edit that on v2.
And you will want to indicate which tree you are targeting:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n78
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 15:36 [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed Nicolas Saenz Julienne
2020-02-24 16:28 ` Leon Romanovsky
2020-02-24 16:30 ` Nicolas Saenz Julienne
2020-02-24 17:23 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.