From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacob Chen <jacob-chen@iotwrt.com> Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, laurent.pinchart+renesas@ideasonboard.com, hans.verkuil@cisco.com, s.nawrocki@samsung.com, tfiga@chromium.org, nicolas@ndufresne.ca, Yakir Yang <ykk@rock-chips.com> Subject: Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Date: Sat, 15 Jul 2017 12:23:12 +0300 [thread overview] Message-ID: <1918615.rEp9U5BAbC@avalon> (raw) In-Reply-To: <1500101920-24039-7-git-send-email-jacob-chen@iotwrt.com> Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:40 Jacob Chen wrote: > Add DT bindings documentation for Rockchip RGA > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > .../devicetree/bindings/media/rockchip-rga.txt | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-rga.txt > > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt > b/Documentation/devicetree/bindings/media/rockchip-rga.txt new file mode > 100644 > index 0000000..966eba0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt > @@ -0,0 +1,35 @@ > +device-tree bindings for rockchip 2D raster graphic acceleration controller > (RGA) > + > +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D "Separate" from what ? Do you mean "standalone" ? > +graphics operations, such as point/line drawing, image scaling, rotation, > +BitBLT, alpha blending and image blur/sharpness. > + > +Required properties: > +- compatible: value should be one of the following > + "rockchip,rk3228-rga"; > + "rockchip,rk3288-rga"; > + "rockchip,rk3399-rga"; The driver in patch 2/6 has match entry for rk3328, which is missing from this list. As the implementation of the driver doesn't seem to discriminate between the four SoCs, wouldn't it make sense to create a generic compatible string on which the driver would match ? You can have both the generic and SoC-specific compatible strings in DT if there are differences between the IP core in those SoCs that might need to be handled later by the driver. > +- interrupts: RGA interrupt number. This is an "interrupt specifier", not just an "interrupt number" (as you can see in the example below there are three numbers) > + > +- clocks: phandle to RGA sclk/hclk/aclk clocks > + > +- clock-names: should be "aclk" "hclk" and "sclk" Nitpicking, there should be a comma after "aclk". > + > +- resets: Must contain an entry for each entry in reset-names. > + See ../reset/reset.txt for details. > +- reset-names: should be "core" "axi" and "ahb" And a comma after "core". > + > +Example: > +SoC specific DT entry: s/SoC specific/SoC-specific/ > + rga: rga@ff680000 { > + compatible = "rockchip,rk3399-rga"; > + reg = <0xff680000 0x10000>; > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "rga"; The interrupt-names property is not described above. Do you really need it ? > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; > + clock-names = "aclk", "hclk", "sclk"; > + > + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; > + reset-names = "core, "axi", "ahb"; > + }; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Date: Sat, 15 Jul 2017 12:23:12 +0300 [thread overview] Message-ID: <1918615.rEp9U5BAbC@avalon> (raw) In-Reply-To: <1500101920-24039-7-git-send-email-jacob-chen@iotwrt.com> Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:40 Jacob Chen wrote: > Add DT bindings documentation for Rockchip RGA > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > .../devicetree/bindings/media/rockchip-rga.txt | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-rga.txt > > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt > b/Documentation/devicetree/bindings/media/rockchip-rga.txt new file mode > 100644 > index 0000000..966eba0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt > @@ -0,0 +1,35 @@ > +device-tree bindings for rockchip 2D raster graphic acceleration controller > (RGA) > + > +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D "Separate" from what ? Do you mean "standalone" ? > +graphics operations, such as point/line drawing, image scaling, rotation, > +BitBLT, alpha blending and image blur/sharpness. > + > +Required properties: > +- compatible: value should be one of the following > + "rockchip,rk3228-rga"; > + "rockchip,rk3288-rga"; > + "rockchip,rk3399-rga"; The driver in patch 2/6 has match entry for rk3328, which is missing from this list. As the implementation of the driver doesn't seem to discriminate between the four SoCs, wouldn't it make sense to create a generic compatible string on which the driver would match ? You can have both the generic and SoC-specific compatible strings in DT if there are differences between the IP core in those SoCs that might need to be handled later by the driver. > +- interrupts: RGA interrupt number. This is an "interrupt specifier", not just an "interrupt number" (as you can see in the example below there are three numbers) > + > +- clocks: phandle to RGA sclk/hclk/aclk clocks > + > +- clock-names: should be "aclk" "hclk" and "sclk" Nitpicking, there should be a comma after "aclk". > + > +- resets: Must contain an entry for each entry in reset-names. > + See ../reset/reset.txt for details. > +- reset-names: should be "core" "axi" and "ahb" And a comma after "core". > + > +Example: > +SoC specific DT entry: s/SoC specific/SoC-specific/ > + rga: rga at ff680000 { > + compatible = "rockchip,rk3399-rga"; > + reg = <0xff680000 0x10000>; > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "rga"; The interrupt-names property is not described above. Do you really need it ? > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; > + clock-names = "aclk", "hclk", "sclk"; > + > + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; > + reset-names = "core, "axi", "ahb"; > + }; -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2017-07-15 9:23 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-15 6:58 [PATCH v2 0/6] Add Rockchip RGA V4l2 support Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 1/6] [media] v4l: add blend modes controls Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 6:58 ` [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:42 ` Laurent Pinchart 2017-07-15 9:42 ` Laurent Pinchart 2017-07-15 16:49 ` Personnel 2017-07-15 16:49 ` Personnel 2017-07-16 4:19 ` Jacob Chen 2017-07-16 4:19 ` Jacob Chen 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 3:43 ` Jacob Chen 2017-07-17 3:43 ` Jacob Chen 2017-07-17 3:43 ` Jacob Chen 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 14:45 ` Nicolas Dufresne 2017-07-17 14:45 ` Nicolas Dufresne 2017-07-19 10:40 ` Jacob Chen 2017-07-19 10:40 ` Jacob Chen 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` [PATCH] rockchip/rga: fix semicolon.cocci warnings kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 6:58 ` [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 6:58 ` [PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399 Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:16 ` Laurent Pinchart 2017-07-15 9:16 ` Laurent Pinchart 2017-07-15 9:16 ` Laurent Pinchart 2017-07-16 4:23 ` Jacob Chen 2017-07-16 4:23 ` Jacob Chen 2017-07-16 4:23 ` Jacob Chen 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 3:09 ` Jacob Chen 2017-07-17 3:09 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:23 ` Laurent Pinchart [this message] 2017-07-15 9:23 ` Laurent Pinchart 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-17 2:21 ` Laurent Pinchart 2017-07-17 2:21 ` Laurent Pinchart 2017-07-17 2:21 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1918615.rEp9U5BAbC@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=hans.verkuil@cisco.com \ --cc=heiko@sntech.de \ --cc=jacob-chen@iotwrt.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=tfiga@chromium.org \ --cc=ykk@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.