From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jacob Chen <jacob-chen@iotwrt.com> Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org, mchehab@kernel.org, linux-media@vger.kernel.org, laurent.pinchart+renesas@ideasonboard.com, hans.verkuil@cisco.com, s.nawrocki@samsung.com, tfiga@chromium.org, nicolas@ndufresne.ca Subject: Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Date: Sat, 15 Jul 2017 12:42:23 +0300 [thread overview] Message-ID: <2363665.x6z9MR1vqI@avalon> (raw) In-Reply-To: <1500101920-24039-3-git-send-email-jacob-chen@iotwrt.com> Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness. > > The drvier is mostly based on s5p-g2d v4l2 m2m driver. > And supports various operations from the rendering pipeline. > - copy > - fast solid color fill > - rotation > - flip > - alpha blending I notice that you don't support the drawing operations. How do you plan to support them later through the V4L2 M2M API ? I hate stating the obvious, but wouldn't the DRM API be better fit for a graphic accelerator ? Additionally, V4L2 M2M has one source and one destination. How do you implement alpha blending in that case, which by definition requires at least two sources ? > The code in rga-hw.c is used to configure regs accroding to operations. > > The code in rga-buf.c is used to create private mmu table for RGA. > The tables is stored in a list, and be removed when buffer is cleanup. Looking at the implementation it seems to be a scatter-gather list, not an MMU. Is that right ? Does the hardware documentation refer to it as an MMU ? > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platform/rockchip-rga/Makefile | 3 + > drivers/media/platform/rockchip-rga/rga-buf.c | 122 ++++ > drivers/media/platform/rockchip-rga/rga-hw.c | 652 ++++++++++++++++++ > drivers/media/platform/rockchip-rga/rga-hw.h | 437 ++++++++++++ > drivers/media/platform/rockchip-rga/rga.c | 958 +++++++++++++++++++++++ > drivers/media/platform/rockchip-rga/rga.h | 111 +++ > 8 files changed, 2296 insertions(+) > create mode 100644 drivers/media/platform/rockchip-rga/Makefile > create mode 100644 drivers/media/platform/rockchip-rga/rga-buf.c > create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.c > create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.h > create mode 100644 drivers/media/platform/rockchip-rga/rga.c > create mode 100644 drivers/media/platform/rockchip-rga/rga.h -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Date: Sat, 15 Jul 2017 12:42:23 +0300 [thread overview] Message-ID: <2363665.x6z9MR1vqI@avalon> (raw) In-Reply-To: <1500101920-24039-3-git-send-email-jacob-chen@iotwrt.com> Hi Jacob, Thank you for the patch. On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness. > > The drvier is mostly based on s5p-g2d v4l2 m2m driver. > And supports various operations from the rendering pipeline. > - copy > - fast solid color fill > - rotation > - flip > - alpha blending I notice that you don't support the drawing operations. How do you plan to support them later through the V4L2 M2M API ? I hate stating the obvious, but wouldn't the DRM API be better fit for a graphic accelerator ? Additionally, V4L2 M2M has one source and one destination. How do you implement alpha blending in that case, which by definition requires at least two sources ? > The code in rga-hw.c is used to configure regs accroding to operations. > > The code in rga-buf.c is used to create private mmu table for RGA. > The tables is stored in a list, and be removed when buffer is cleanup. Looking at the implementation it seems to be a scatter-gather list, not an MMU. Is that right ? Does the hardware documentation refer to it as an MMU ? > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platform/rockchip-rga/Makefile | 3 + > drivers/media/platform/rockchip-rga/rga-buf.c | 122 ++++ > drivers/media/platform/rockchip-rga/rga-hw.c | 652 ++++++++++++++++++ > drivers/media/platform/rockchip-rga/rga-hw.h | 437 ++++++++++++ > drivers/media/platform/rockchip-rga/rga.c | 958 +++++++++++++++++++++++ > drivers/media/platform/rockchip-rga/rga.h | 111 +++ > 8 files changed, 2296 insertions(+) > create mode 100644 drivers/media/platform/rockchip-rga/Makefile > create mode 100644 drivers/media/platform/rockchip-rga/rga-buf.c > create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.c > create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.h > create mode 100644 drivers/media/platform/rockchip-rga/rga.c > create mode 100644 drivers/media/platform/rockchip-rga/rga.h -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2017-07-15 9:42 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-15 6:58 [PATCH v2 0/6] Add Rockchip RGA V4l2 support Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 1/6] [media] v4l: add blend modes controls Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 9:31 ` Laurent Pinchart 2017-07-15 6:58 ` [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:42 ` Laurent Pinchart [this message] 2017-07-15 9:42 ` Laurent Pinchart 2017-07-15 16:49 ` Personnel 2017-07-15 16:49 ` Personnel 2017-07-16 4:19 ` Jacob Chen 2017-07-16 4:19 ` Jacob Chen 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 2:43 ` Laurent Pinchart 2017-07-17 3:43 ` Jacob Chen 2017-07-17 3:43 ` Jacob Chen 2017-07-17 3:43 ` Jacob Chen 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 2:37 ` Laurent Pinchart 2017-07-17 14:45 ` Nicolas Dufresne 2017-07-17 14:45 ` Nicolas Dufresne 2017-07-19 10:40 ` Jacob Chen 2017-07-19 10:40 ` Jacob Chen 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` [PATCH] rockchip/rga: fix semicolon.cocci warnings kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 17:42 ` kbuild test robot 2017-07-15 6:58 ` [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 8:12 ` Heiko Stuebner 2017-07-15 6:58 ` [PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399 Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:16 ` Laurent Pinchart 2017-07-15 9:16 ` Laurent Pinchart 2017-07-15 9:16 ` Laurent Pinchart 2017-07-16 4:23 ` Jacob Chen 2017-07-16 4:23 ` Jacob Chen 2017-07-16 4:23 ` Jacob Chen 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 2:28 ` Laurent Pinchart 2017-07-17 3:09 ` Jacob Chen 2017-07-17 3:09 ` Jacob Chen 2017-07-15 6:58 ` [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Jacob Chen 2017-07-15 6:58 ` Jacob Chen 2017-07-15 9:23 ` Laurent Pinchart 2017-07-15 9:23 ` Laurent Pinchart 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-16 16:07 ` Heiko Stuebner 2017-07-17 2:21 ` Laurent Pinchart 2017-07-17 2:21 ` Laurent Pinchart 2017-07-17 2:21 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2363665.x6z9MR1vqI@avalon \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=hans.verkuil@cisco.com \ --cc=heiko@sntech.de \ --cc=jacob-chen@iotwrt.com \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=mchehab@kernel.org \ --cc=nicolas@ndufresne.ca \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=tfiga@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.