* [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
@ 2021-02-01 15:59 Helge Deller
2021-02-13 16:13 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Helge Deller @ 2021-02-01 15:59 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
John Paul Adrian Glaubitz
The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
and as such fail to run a trivial symlink command like
ln -s /bin/bash /tmp
which results in an -EINVAL return code.
Adding the define fixes the problem.
Signed-off-by: Helge Deller <deller@gmx.de>
---
diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
index 2617e73472..0a74807a8b 100644
--- a/linux-user/alpha/target_fcntl.h
+++ b/linux-user/alpha/target_fcntl.h
@@ -23,6 +23,7 @@
#define TARGET_O_CLOEXEC 010000000
#define TARGET___O_SYNC 020000000
#define TARGET_O_PATH 040000000
+#define TARGET___O_TMPFILE 0100000000
#define TARGET_F_GETLK 7
#define TARGET_F_SETLK 8
diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
index bd966a59b8..08e3a4fcb0 100644
--- a/linux-user/hppa/target_fcntl.h
+++ b/linux-user/hppa/target_fcntl.h
@@ -21,6 +21,7 @@
#define TARGET_O_CLOEXEC 010000000
#define TARGET___O_SYNC 000100000
#define TARGET_O_PATH 020000000
+#define TARGET___O_TMPFILE 040000000
#define TARGET_F_RDLCK 1
#define TARGET_F_WRLCK 2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
@ 2021-02-13 16:13 ` Laurent Vivier
2021-02-13 16:18 ` Laurent Vivier
2021-02-22 0:59 ` Helge Deller
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-02-13 16:13 UTC (permalink / raw)
To: Helge Deller, qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
John Paul Adrian Glaubitz
Le 01/02/2021 à 16:59, Helge Deller a écrit :
> The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
> and as such fail to run a trivial symlink command like
>
> ln -s /bin/bash /tmp
>
> which results in an -EINVAL return code.
>
> Adding the define fixes the problem.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
> index 2617e73472..0a74807a8b 100644
> --- a/linux-user/alpha/target_fcntl.h
> +++ b/linux-user/alpha/target_fcntl.h
> @@ -23,6 +23,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 020000000
> #define TARGET_O_PATH 040000000
> +#define TARGET___O_TMPFILE 0100000000
>
> #define TARGET_F_GETLK 7
> #define TARGET_F_SETLK 8
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -21,6 +21,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 000100000
> #define TARGET_O_PATH 020000000
> +#define TARGET___O_TMPFILE 040000000
>
> #define TARGET_F_RDLCK 1
> #define TARGET_F_WRLCK 2
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
2021-02-13 16:13 ` Laurent Vivier
@ 2021-02-13 16:18 ` Laurent Vivier
2021-02-22 0:59 ` Helge Deller
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-02-13 16:18 UTC (permalink / raw)
To: Helge Deller, qemu-devel
Cc: Richard Henderson, Philippe Mathieu-Daudé,
John Paul Adrian Glaubitz
Le 01/02/2021 à 16:59, Helge Deller a écrit :
> The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
> and as such fail to run a trivial symlink command like
>
> ln -s /bin/bash /tmp
>
> which results in an -EINVAL return code.
>
> Adding the define fixes the problem.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
> index 2617e73472..0a74807a8b 100644
> --- a/linux-user/alpha/target_fcntl.h
> +++ b/linux-user/alpha/target_fcntl.h
> @@ -23,6 +23,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 020000000
> #define TARGET_O_PATH 040000000
> +#define TARGET___O_TMPFILE 0100000000
>
> #define TARGET_F_GETLK 7
> #define TARGET_F_SETLK 8
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -21,6 +21,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 000100000
> #define TARGET_O_PATH 020000000
> +#define TARGET___O_TMPFILE 040000000
>
> #define TARGET_F_RDLCK 1
> #define TARGET_F_WRLCK 2
>
Applied to my linux-user-for-6.0 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
2021-02-13 16:13 ` Laurent Vivier
2021-02-13 16:18 ` Laurent Vivier
@ 2021-02-22 0:59 ` Helge Deller
2 siblings, 0 replies; 4+ messages in thread
From: Helge Deller @ 2021-02-22 0:59 UTC (permalink / raw)
To: qemu-stable; +Cc: qemu-devel
Dear qemu-stable,
can you please consider adding this patch to the qemu-stable branch.
Upstream commit 23b311155078bdd5bacc016ff3b3ebb5462b10c0
Thanks,
Helge
On 2/1/21 4:59 PM, Helge Deller wrote:
> The hppa and alpha targets miss the #define of the TARGET___O_TMPFILE
> and as such fail to run a trivial symlink command like
>
> ln -s /bin/bash /tmp
>
> which results in an -EINVAL return code.
>
> Adding the define fixes the problem.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> ---
>
> diff --git a/linux-user/alpha/target_fcntl.h b/linux-user/alpha/target_fcntl.h
> index 2617e73472..0a74807a8b 100644
> --- a/linux-user/alpha/target_fcntl.h
> +++ b/linux-user/alpha/target_fcntl.h
> @@ -23,6 +23,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 020000000
> #define TARGET_O_PATH 040000000
> +#define TARGET___O_TMPFILE 0100000000
>
> #define TARGET_F_GETLK 7
> #define TARGET_F_SETLK 8
> diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
> index bd966a59b8..08e3a4fcb0 100644
> --- a/linux-user/hppa/target_fcntl.h
> +++ b/linux-user/hppa/target_fcntl.h
> @@ -21,6 +21,7 @@
> #define TARGET_O_CLOEXEC 010000000
> #define TARGET___O_SYNC 000100000
> #define TARGET_O_PATH 020000000
> +#define TARGET___O_TMPFILE 040000000
>
> #define TARGET_F_RDLCK 1
> #define TARGET_F_WRLCK 2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 15:59 [PATCH] linux-user: Add missing TARGET___O_TMPFILE for hppa and alpha Helge Deller
2021-02-13 16:13 ` Laurent Vivier
2021-02-13 16:18 ` Laurent Vivier
2021-02-22 0:59 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.