From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver
Date: Wed, 09 Feb 2011 13:35:26 +0000 [thread overview]
Message-ID: <19794.38942.679388.812321@ipc1.ka-ro> (raw)
In-Reply-To: <1297257651-8002-2-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
Sascha Hauer writes:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: linux-fbdev@vger.kernel.org
> Cc: Shawn Guo <shawn.guo@freescale.com>
> ---
> arch/arm/mach-mxs/include/mach/fb.h | 48 ++
> drivers/video/Kconfig | 9 +
> drivers/video/Makefile | 1 +
> drivers/video/mxsfb.c | 914 +++++++++++++++++++++++++++++++++++
> 4 files changed, 972 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-mxs/include/mach/fb.h
> create mode 100644 drivers/video/mxsfb.c
>
[...]
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> new file mode 100644
> index 0000000..92a5804
> --- /dev/null
> +++ b/drivers/video/mxsfb.c
[...]
> +static int __devexit mxsfb_remove(struct platform_device *pdev)
> +{
> + struct fb_info *fb_info = platform_get_drvdata(pdev);
> + struct mxsfb_info *host = to_imxfb_host(fb_info);
> + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +
> + mxsfb_disable_controller(fb_info);
>
IMO this should also be guarded by an:
| if (host->enabled)
otherwise it may lead to an unbalanced clk_disable() call.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver
Date: Wed, 9 Feb 2011 14:35:26 +0100 [thread overview]
Message-ID: <19794.38942.679388.812321@ipc1.ka-ro> (raw)
In-Reply-To: <1297257651-8002-2-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
Sascha Hauer writes:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: linux-fbdev at vger.kernel.org
> Cc: Shawn Guo <shawn.guo@freescale.com>
> ---
> arch/arm/mach-mxs/include/mach/fb.h | 48 ++
> drivers/video/Kconfig | 9 +
> drivers/video/Makefile | 1 +
> drivers/video/mxsfb.c | 914 +++++++++++++++++++++++++++++++++++
> 4 files changed, 972 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-mxs/include/mach/fb.h
> create mode 100644 drivers/video/mxsfb.c
>
[...]
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> new file mode 100644
> index 0000000..92a5804
> --- /dev/null
> +++ b/drivers/video/mxsfb.c
[...]
> +static int __devexit mxsfb_remove(struct platform_device *pdev)
> +{
> + struct fb_info *fb_info = platform_get_drvdata(pdev);
> + struct mxsfb_info *host = to_imxfb_host(fb_info);
> + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +
> + mxsfb_disable_controller(fb_info);
>
IMO this should also be guarded by an:
| if (host->enabled)
otherwise it may lead to an unbalanced clk_disable() call.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2011-02-09 13:35 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 13:20 [PATCH] i.MX23/28 framebuffer driver Sascha Hauer
2011-02-09 13:20 ` [PATCH 1/2] video: Add " Sascha Hauer
2011-02-09 13:20 ` Sascha Hauer
2011-02-09 13:35 ` Lothar Waßmann [this message]
2011-02-09 13:35 ` Lothar Waßmann
2011-02-10 3:16 ` Li Frank-B20596
2011-02-10 3:16 ` Li Frank-B20596
2011-02-10 8:51 ` Juergen Beisert
2011-02-10 8:51 ` Juergen Beisert
2011-02-10 9:15 ` Li Frank-B20596
2011-02-10 9:15 ` Li Frank-B20596
2011-02-10 9:52 ` Juergen Beisert
2011-02-10 9:52 ` Juergen Beisert
2011-02-10 10:37 ` Li Frank-B20596
2011-02-10 10:37 ` Li Frank-B20596
2011-02-10 11:12 ` Juergen Beisert
2011-02-10 11:12 ` Juergen Beisert
2011-02-10 12:23 ` Li Frank-B20596
2011-02-10 12:23 ` Li Frank-B20596
2011-02-10 9:23 ` Li Frank-B20596
2011-02-10 9:23 ` Li Frank-B20596
2011-02-10 9:46 ` Juergen Beisert
2011-02-10 9:46 ` Juergen Beisert
2011-02-10 10:08 ` Li Frank-B20596
2011-02-10 10:08 ` Li Frank-B20596
2011-02-10 10:47 ` Wolfram Sang
2011-02-10 10:47 ` Wolfram Sang
2011-02-10 11:51 ` Sascha Hauer
2011-02-10 11:51 ` Sascha Hauer
2011-02-10 12:32 ` Li Frank-B20596
2011-02-10 12:32 ` Li Frank-B20596
2011-02-09 13:20 ` [PATCH 2/2] ARM i.MX23/28: Add framebuffer device support Sascha Hauer
2011-02-09 14:33 ` Fabio Estevam
2011-02-10 3:23 ` Li Frank-B20596
2011-02-09 14:47 ` [PATCH] i.MX23/28 framebuffer driver Arnd Bergmann
2011-02-09 15:37 ` Sascha Hauer
2011-02-09 16:31 ` Arnd Bergmann
2011-02-09 16:31 ` Arnd Bergmann
2011-02-10 17:09 ` Robert Schwebel
2011-02-10 17:09 ` Robert Schwebel
2011-02-15 14:13 ` Clark, Rob
2011-02-15 14:13 ` Clark, Rob
2011-02-16 12:22 ` Arnd Bergmann
2011-02-16 12:22 ` Arnd Bergmann
2011-02-16 14:42 ` Jesse Barker
2011-02-17 1:08 ` Clark, Rob
2011-02-17 1:08 ` Clark, Rob
2011-02-17 1:24 ` Jammy Zhou
2011-02-17 15:25 ` Clark, Rob
2011-02-17 15:25 ` Clark, Rob
2011-02-18 2:25 ` Jammy Zhou
2011-02-18 4:34 ` Clark, Rob
2011-02-18 4:34 ` Clark, Rob
2011-02-17 16:14 ` James Simmons
2011-02-17 16:14 ` James Simmons
2011-02-17 16:14 ` James Simmons
2011-02-18 2:19 ` Jammy Zhou
2011-02-18 2:19 ` Jammy Zhou
[not found] ` <AANLkTimcwr4vpycSQCH9vMaB+umh+yHD_+WD2MJNqMOB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-18 4:32 ` Clark, Rob
2011-02-18 4:32 ` Clark, Rob
2011-02-18 4:32 ` Clark, Rob
2011-02-21 3:12 ` Dave Airlie
2011-02-21 3:12 ` Dave Airlie
2011-02-21 3:12 ` Dave Airlie
2011-02-10 9:22 ` Domenico Andreoli
2011-02-16 9:56 [PATCH v2] i.MX23/28 Framebuffer driver Sascha Hauer
2011-02-16 9:56 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer
2011-02-16 9:56 ` Sascha Hauer
2011-02-18 5:24 ` Shawn Guo
2011-02-18 5:24 ` Shawn Guo
2011-02-18 8:30 ` Sascha Hauer
2011-02-18 8:30 ` Sascha Hauer
2011-02-18 8:57 ` Shawn Guo
2011-02-18 8:57 ` Shawn Guo
2011-02-18 12:29 ` Shawn Guo
2011-02-18 12:29 ` Shawn Guo
2011-02-21 14:17 ` Sascha Hauer
2011-02-21 14:17 ` Sascha Hauer
2011-02-28 8:02 [PATCH v3] i.MX23/28 Framebuffer support Sascha Hauer
2011-02-28 8:02 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer
2011-02-28 8:02 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19794.38942.679388.812321@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.