From: Juergen Beisert <jbe@pengutronix.de> To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Date: Thu, 10 Feb 2011 08:51:10 +0000 [thread overview] Message-ID: <201102100951.10977.jbe@pengutronix.de> (raw) In-Reply-To: <09EC74FE2C9E8444BF2FF67BD36E1D6916776E@039-SN1MPN1-003.039d.mgd.msft.net> Li Frank-B20596 wrote: > > +#define CTRL 0x00 > > +#define CTRL1 0x10 > > +#define MX28_CTRL2 0x20 > > +#define MX23_TRANSFER_COUNT 0x20 > > +#define MX28_TRANSFER_COUNT 0x30 > > +#define MX28_CUR_BUF 0x40 > > +#define MX28_NEXT_BUF 0x50 > > +#define MX23_CUR_BUF 0x30 > > +#define MX23_NEXT_BUF 0x40 > > +#define TIMING 0x60 > > +#define VDCTRL0 0x70 > > +#define VDCTRL1 0x80 > > +#define VDCTRL2 0x90 > > +#define VDCTRL3 0xa0 > > +#define VDCTRL4 0xb0 > > Why you give up mx23/mx28 register define role, which generate from SOC > xml. Your macros prevent me from writing short and compact code. If you need more than one of these macros you always have to split each line to follow the 80 columns rule. Unreadable. > There is a set header files for each mx23/mx28 module, which generate > from xml. I know original header files affect run time one Image. > But I think we can copy common part of such register definition because > That keep consistent with mx23/mx28 data sheet. Data sheet and header file > generate from one source xml. > > HW_<Module name>_<Register name>. > BM_<Module name>_<Register name>_Bit name. IMHO when I define the macros where they belong to, there is not need for this redundant HW_<Module name> or BW__<Module name> prefixes. They are just needless. Regards, Juergen -- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | Phone: +49-8766-939 228 | Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: jbe@pengutronix.de (Juergen Beisert) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Date: Thu, 10 Feb 2011 09:51:10 +0100 [thread overview] Message-ID: <201102100951.10977.jbe@pengutronix.de> (raw) In-Reply-To: <09EC74FE2C9E8444BF2FF67BD36E1D6916776E@039-SN1MPN1-003.039d.mgd.msft.net> Li Frank-B20596 wrote: > > +#define CTRL 0x00 > > +#define CTRL1 0x10 > > +#define MX28_CTRL2 0x20 > > +#define MX23_TRANSFER_COUNT 0x20 > > +#define MX28_TRANSFER_COUNT 0x30 > > +#define MX28_CUR_BUF 0x40 > > +#define MX28_NEXT_BUF 0x50 > > +#define MX23_CUR_BUF 0x30 > > +#define MX23_NEXT_BUF 0x40 > > +#define TIMING 0x60 > > +#define VDCTRL0 0x70 > > +#define VDCTRL1 0x80 > > +#define VDCTRL2 0x90 > > +#define VDCTRL3 0xa0 > > +#define VDCTRL4 0xb0 > > Why you give up mx23/mx28 register define role, which generate from SOC > xml. Your macros prevent me from writing short and compact code. If you need more than one of these macros you always have to split each line to follow the 80 columns rule. Unreadable. > There is a set header files for each mx23/mx28 module, which generate > from xml. I know original header files affect run time one Image. > But I think we can copy common part of such register definition because > That keep consistent with mx23/mx28 data sheet. Data sheet and header file > generate from one source xml. > > HW_<Module name>_<Register name>. > BM_<Module name>_<Register name>_Bit name. IMHO when I define the macros where they belong to, there is not need for this redundant HW_<Module name> or BW__<Module name> prefixes. They are just needless. Regards, Juergen -- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | Phone: +49-8766-939 228 | Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-02-10 8:51 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-09 13:20 [PATCH] i.MX23/28 framebuffer driver Sascha Hauer 2011-02-09 13:20 ` [PATCH 1/2] video: Add " Sascha Hauer 2011-02-09 13:20 ` Sascha Hauer 2011-02-09 13:35 ` Lothar Waßmann 2011-02-09 13:35 ` Lothar Waßmann 2011-02-10 3:16 ` Li Frank-B20596 2011-02-10 3:16 ` Li Frank-B20596 2011-02-10 8:51 ` Juergen Beisert [this message] 2011-02-10 8:51 ` Juergen Beisert 2011-02-10 9:15 ` Li Frank-B20596 2011-02-10 9:15 ` Li Frank-B20596 2011-02-10 9:52 ` Juergen Beisert 2011-02-10 9:52 ` Juergen Beisert 2011-02-10 10:37 ` Li Frank-B20596 2011-02-10 10:37 ` Li Frank-B20596 2011-02-10 11:12 ` Juergen Beisert 2011-02-10 11:12 ` Juergen Beisert 2011-02-10 12:23 ` Li Frank-B20596 2011-02-10 12:23 ` Li Frank-B20596 2011-02-10 9:23 ` Li Frank-B20596 2011-02-10 9:23 ` Li Frank-B20596 2011-02-10 9:46 ` Juergen Beisert 2011-02-10 9:46 ` Juergen Beisert 2011-02-10 10:08 ` Li Frank-B20596 2011-02-10 10:08 ` Li Frank-B20596 2011-02-10 10:47 ` Wolfram Sang 2011-02-10 10:47 ` Wolfram Sang 2011-02-10 11:51 ` Sascha Hauer 2011-02-10 11:51 ` Sascha Hauer 2011-02-10 12:32 ` Li Frank-B20596 2011-02-10 12:32 ` Li Frank-B20596 2011-02-09 13:20 ` [PATCH 2/2] ARM i.MX23/28: Add framebuffer device support Sascha Hauer 2011-02-09 14:33 ` Fabio Estevam 2011-02-10 3:23 ` Li Frank-B20596 2011-02-09 14:47 ` [PATCH] i.MX23/28 framebuffer driver Arnd Bergmann 2011-02-09 15:37 ` Sascha Hauer 2011-02-09 16:31 ` Arnd Bergmann 2011-02-09 16:31 ` Arnd Bergmann 2011-02-10 17:09 ` Robert Schwebel 2011-02-10 17:09 ` Robert Schwebel 2011-02-15 14:13 ` Clark, Rob 2011-02-15 14:13 ` Clark, Rob 2011-02-16 12:22 ` Arnd Bergmann 2011-02-16 12:22 ` Arnd Bergmann 2011-02-16 14:42 ` Jesse Barker 2011-02-17 1:08 ` Clark, Rob 2011-02-17 1:08 ` Clark, Rob 2011-02-17 1:24 ` Jammy Zhou 2011-02-17 15:25 ` Clark, Rob 2011-02-17 15:25 ` Clark, Rob 2011-02-18 2:25 ` Jammy Zhou 2011-02-18 4:34 ` Clark, Rob 2011-02-18 4:34 ` Clark, Rob 2011-02-17 16:14 ` James Simmons 2011-02-17 16:14 ` James Simmons 2011-02-17 16:14 ` James Simmons 2011-02-18 2:19 ` Jammy Zhou 2011-02-18 2:19 ` Jammy Zhou [not found] ` <AANLkTimcwr4vpycSQCH9vMaB+umh+yHD_+WD2MJNqMOB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2011-02-18 4:32 ` Clark, Rob 2011-02-18 4:32 ` Clark, Rob 2011-02-18 4:32 ` Clark, Rob 2011-02-21 3:12 ` Dave Airlie 2011-02-21 3:12 ` Dave Airlie 2011-02-21 3:12 ` Dave Airlie 2011-02-10 9:22 ` Domenico Andreoli 2011-02-16 9:56 [PATCH v2] i.MX23/28 Framebuffer driver Sascha Hauer 2011-02-16 9:56 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer 2011-02-16 9:56 ` Sascha Hauer 2011-02-18 5:24 ` Shawn Guo 2011-02-18 5:24 ` Shawn Guo 2011-02-18 8:30 ` Sascha Hauer 2011-02-18 8:30 ` Sascha Hauer 2011-02-18 8:57 ` Shawn Guo 2011-02-18 8:57 ` Shawn Guo 2011-02-18 12:29 ` Shawn Guo 2011-02-18 12:29 ` Shawn Guo 2011-02-21 14:17 ` Sascha Hauer 2011-02-21 14:17 ` Sascha Hauer 2011-02-28 8:02 [PATCH v3] i.MX23/28 Framebuffer support Sascha Hauer 2011-02-28 8:02 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer 2011-02-28 8:02 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201102100951.10977.jbe@pengutronix.de \ --to=jbe@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.