All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Ed Swierk <eswierk@skyportsystems.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	"Denis V. Lunev" <den@openvz.org>
Subject: Re: [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k
Date: Mon, 14 Nov 2016 10:59:10 -0600	[thread overview]
Message-ID: <19dc5096-a0c0-5d6a-84a6-a1066fbac52e@redhat.com> (raw)
In-Reply-To: <20161114155428.GA9518@noname.str.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On 11/14/2016 09:54 AM, Kevin Wolf wrote:

>>>> Our qcow2 support is currently limited to a maximum of 2M clusters;
>>>> while MAX_WRITE_ZEROES_BOUNCE_BUFFER is 32k * 512, or 16M.  The
>>>> maximum-size bounce buffer should not be the problem here; but for some
>>>> reason, it looks like alignment is larger than max_transfer which should
>>>> not normally be possible.  I'm still playing with what should be the
>>>> right patch, but hope to have something posted soon.
>>>
>>> Are you still playing with it?
>>
>> Patch was posted here:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg01603.html
> 
> Ah, yes, sorry. I didn't make the connection today because this one had
> qcow2 in the subject line and the patch doesn't.
> 
> Are you going to add a qemu-iotests case then, or do you want us to
> merge the patch as it is?

I think the patch is ready to merge as-is; I'm still adding a
qemu-iotests addition, but the addition requires enhancing blkdebug
which is a bit extreme to be doing after soft freeze (so the tests are
probably 2.9 material, while the bug fix is still for 2.8)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-11-14 16:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  0:24 [Qemu-devel] Assertion failure on qcow2 disk with cluster_size != 64k Ed Swierk
2016-10-21  1:38 ` Eric Blake
2016-10-21 13:14   ` Ed Swierk
2016-10-24 20:32     ` Eric Blake
2016-11-14  9:50       ` Kevin Wolf
2016-11-14 15:46         ` Eric Blake
2016-11-14 15:54           ` Kevin Wolf
2016-11-14 16:59             ` Eric Blake [this message]
2016-10-24 21:21 ` Eric Blake
2016-10-24 23:06   ` Ed Swierk
2016-10-25  8:39     ` Kevin Wolf
2016-10-25 13:51       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19dc5096-a0c0-5d6a-84a6-a1066fbac52e@redhat.com \
    --to=eblake@redhat.com \
    --cc=den@openvz.org \
    --cc=eswierk@skyportsystems.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.