[Qemu-devel] Failing qemu-iotest 005 with raw

[Qemu-devel] Failing qemu-iotest 005 with raw

[Thomas Huth]

When running iotest 005 with raw, the test currently fails for me:

005         - output mismatch (see 005.out.bad)
--- /home/thuth/devel/qemu/tests/qemu-iotests/005.out	2019-04-23
16:43:11.000000000 +0200
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad	2019-04-26
11:34:11.000000000 +0200
@@ -1,13 +1,12 @@
 QA output created by 005

 creating large image
+qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
format 'IMGFMT'
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000

 small read
-read 4096/4096 bytes at offset 1024
-4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+read failed: Input/output error

 small write
-wrote 4096/4096 bytes at offset 8192
-4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+write failed: Input/output error
 *** done


Could this be fixed somehow, or should the test rather be skipped for
IMGFMT=raw?

 Thomas

[Qemu-devel] Failing qemu-iotest 005 with raw

[Thomas Huth]

When running iotest 005 with raw, the test currently fails for me:

005         - output mismatch (see 005.out.bad)
--- /home/thuth/devel/qemu/tests/qemu-iotests/005.out	2019-04-23
16:43:11.000000000 +0200
+++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad	2019-04-26
11:34:11.000000000 +0200
@@ -1,13 +1,12 @@
 QA output created by 005

 creating large image
+qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
format 'IMGFMT'
 Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000

 small read
-read 4096/4096 bytes at offset 1024
-4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+read failed: Input/output error

 small write
-wrote 4096/4096 bytes at offset 8192
-4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+write failed: Input/output error
 *** done


Could this be fixed somehow, or should the test rather be skipped for
IMGFMT=raw?

 Thomas

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Kevin Wolf]

Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben:
> 
> When running iotest 005 with raw, the test currently fails for me:
> 
> 005         - output mismatch (see 005.out.bad)
> --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out	2019-04-23
> 16:43:11.000000000 +0200
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad	2019-04-26
> 11:34:11.000000000 +0200
> @@ -1,13 +1,12 @@
>  QA output created by 005
> 
>  creating large image
> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
> format 'IMGFMT'
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
> [...]
> 
> Could this be fixed somehow, or should the test rather be skipped for
> IMGFMT=raw?

The test passes for me on XFS. Looks like the raw driver can handle
large image files, but your host filesystem can't.

We would have to check whether the host filesystem can support large
files and skip the test if it can't. I'm not sure how to do that. But
actually, this isn't testing anything interesting for raw, so just
unconditionally disabling the test for raw could be reasonable enough.

Kevin

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Kevin Wolf]

Am 26.04.2019 um 11:41 hat Thomas Huth geschrieben:
> 
> When running iotest 005 with raw, the test currently fails for me:
> 
> 005         - output mismatch (see 005.out.bad)
> --- /home/thuth/devel/qemu/tests/qemu-iotests/005.out	2019-04-23
> 16:43:11.000000000 +0200
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/005.out.bad	2019-04-26
> 11:34:11.000000000 +0200
> @@ -1,13 +1,12 @@
>  QA output created by 005
> 
>  creating large image
> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
> format 'IMGFMT'
>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
> [...]
> 
> Could this be fixed somehow, or should the test rather be skipped for
> IMGFMT=raw?

The test passes for me on XFS. Looks like the raw driver can handle
large image files, but your host filesystem can't.

We would have to check whether the host filesystem can support large
files and skip the test if it can't. I'm not sure how to do that. But
actually, this isn't testing anything interesting for raw, so just
unconditionally disabling the test for raw could be reasonable enough.

Kevin

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 4/26/19 5:53 AM, Kevin Wolf wrote:

>>  creating large image
>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
>> format 'IMGFMT'
>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
>> [...]
>>
>> Could this be fixed somehow, or should the test rather be skipped for
>> IMGFMT=raw?
> 
> The test passes for me on XFS. Looks like the raw driver can handle
> large image files, but your host filesystem can't.
> 
> We would have to check whether the host filesystem can support large
> files and skip the test if it can't. I'm not sure how to do that. But
> actually, this isn't testing anything interesting for raw, so just
> unconditionally disabling the test for raw could be reasonable enough.

iotest 220 in commit 3b94c343 can serve as such an example (it skips the
test on at least ext4, while passing on tmpfs which allows larger sparse
files).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]

On 4/26/19 5:53 AM, Kevin Wolf wrote:

>>  creating large image
>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
>> format 'IMGFMT'
>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
>> [...]
>>
>> Could this be fixed somehow, or should the test rather be skipped for
>> IMGFMT=raw?
> 
> The test passes for me on XFS. Looks like the raw driver can handle
> large image files, but your host filesystem can't.
> 
> We would have to check whether the host filesystem can support large
> files and skip the test if it can't. I'm not sure how to do that. But
> actually, this isn't testing anything interesting for raw, so just
> unconditionally disabling the test for raw could be reasonable enough.

iotest 220 in commit 3b94c343 can serve as such an example (it skips the
test on at least ext4, while passing on tmpfs which allows larger sparse
files).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Thomas Huth]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On 28/04/2019 04.36, Eric Blake wrote:
> On 4/26/19 5:53 AM, Kevin Wolf wrote:
> 
>>>  creating large image
>>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
>>> format 'IMGFMT'
>>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
>>> [...]
>>>
>>> Could this be fixed somehow, or should the test rather be skipped for
>>> IMGFMT=raw?
>>
>> The test passes for me on XFS. Looks like the raw driver can handle
>> large image files, but your host filesystem can't.
>>
>> We would have to check whether the host filesystem can support large
>> files and skip the test if it can't. I'm not sure how to do that. But
>> actually, this isn't testing anything interesting for raw, so just
>> unconditionally disabling the test for raw could be reasonable enough.
> 
> iotest 220 in commit 3b94c343 can serve as such an example (it skips the
> test on at least ext4, while passing on tmpfs which allows larger sparse
> files).

That should do the trick, thanks. I'll send a patch.

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [Qemu-devel] Failing qemu-iotest 005 with raw

[Thomas Huth]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On 28/04/2019 04.36, Eric Blake wrote:
> On 4/26/19 5:53 AM, Kevin Wolf wrote:
> 
>>>  creating large image
>>> +qemu-img: TEST_DIR/t.IMGFMT: The image size is too large for file
>>> format 'IMGFMT'
>>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5368709120000
>>> [...]
>>>
>>> Could this be fixed somehow, or should the test rather be skipped for
>>> IMGFMT=raw?
>>
>> The test passes for me on XFS. Looks like the raw driver can handle
>> large image files, but your host filesystem can't.
>>
>> We would have to check whether the host filesystem can support large
>> files and skip the test if it can't. I'm not sure how to do that. But
>> actually, this isn't testing anything interesting for raw, so just
>> unconditionally disabling the test for raw could be reasonable enough.
> 
> iotest 220 in commit 3b94c343 can serve as such an example (it skips the
> test on at least ext4, while passing on tmpfs which allows larger sparse
> files).

That should do the trick, thanks. I'll send a patch.

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]