All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-pci@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations
Date: Thu, 3 Nov 2022 17:07:47 +0100	[thread overview]
Message-ID: <1a36babb-a18d-b189-1ed3-0dc03f50e997@denx.de> (raw)
In-Reply-To: <166744542553.1047593.11633766224075181622.robh@kernel.org>

On 11/3/22 04:24, Rob Herring wrote:
> 
> On Wed, 02 Nov 2022 22:57:27 +0100, Marek Vasut wrote:
>> The i.MX SoCs have various clock configurations routed into the PCIe IP,
>> the list of clock is below. Document all those configurations in the DT
>> binding document.
>>
>> All SoCs: pcie, pcie_bus
>> 6QDL, 7D: + pcie_phy
>> 6SX:      + pcie_phy          pcie_inbound_axi
>> 8MQ:      + pcie_phy pcie_aux
>> 8MM, 8MP: +          pcie_aux
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Richard Zhu <hongxing.zhu@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> To: devicetree@vger.kernel.org
>> ---
>>   .../bindings/pci/fsl,imx6q-pcie.yaml          | 74 +++++++++++++++++--
>>   1 file changed, 69 insertions(+), 5 deletions(-)
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected)
> 	arch/arm/boot/dts/imx6dl-emcon-avari.dtb
> 	arch/arm/boot/dts/imx6q-emcon-avari.dtb

This part is unrelated to this patch.

> pcie@33800000: clock-names:1: 'pcie_bus' was expected
> 	arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb

This and all the clock related goop should be solved by this series:

[PATCH 1/3] arm64: dts: imx8mm: Deduplicate PCIe clock-names property

Once that lands, this could land too without any errors anymore.

[...]


WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-pci@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations
Date: Thu, 3 Nov 2022 17:07:47 +0100	[thread overview]
Message-ID: <1a36babb-a18d-b189-1ed3-0dc03f50e997@denx.de> (raw)
In-Reply-To: <166744542553.1047593.11633766224075181622.robh@kernel.org>

On 11/3/22 04:24, Rob Herring wrote:
> 
> On Wed, 02 Nov 2022 22:57:27 +0100, Marek Vasut wrote:
>> The i.MX SoCs have various clock configurations routed into the PCIe IP,
>> the list of clock is below. Document all those configurations in the DT
>> binding document.
>>
>> All SoCs: pcie, pcie_bus
>> 6QDL, 7D: + pcie_phy
>> 6SX:      + pcie_phy          pcie_inbound_axi
>> 8MQ:      + pcie_phy pcie_aux
>> 8MM, 8MP: +          pcie_aux
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Lucas Stach <l.stach@pengutronix.de>
>> Cc: Richard Zhu <hongxing.zhu@nxp.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: linux-arm-kernel@lists.infradead.org
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> To: devicetree@vger.kernel.org
>> ---
>>   .../bindings/pci/fsl,imx6q-pcie.yaml          | 74 +++++++++++++++++--
>>   1 file changed, 69 insertions(+), 5 deletions(-)
>>
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> pcie@1ffc000: Unevaluated properties are not allowed ('disable-gpio' was unexpected)
> 	arch/arm/boot/dts/imx6dl-emcon-avari.dtb
> 	arch/arm/boot/dts/imx6q-emcon-avari.dtb

This part is unrelated to this patch.

> pcie@33800000: clock-names:1: 'pcie_bus' was expected
> 	arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dtb

This and all the clock related goop should be solved by this series:

[PATCH 1/3] arm64: dts: imx8mm: Deduplicate PCIe clock-names property

Once that lands, this could land too without any errors anymore.

[...]


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-03 16:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 21:57 [PATCH 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations Marek Vasut
2022-11-02 21:57 ` Marek Vasut
2022-11-02 21:57 ` [PATCH 2/3] dt-bindings: imx6q-pcie: Handle various PD configurations Marek Vasut
2022-11-02 21:57   ` Marek Vasut
2022-11-03  3:24   ` Rob Herring
2022-11-03  3:24     ` Rob Herring
2022-11-03  8:29   ` Alexander Stein
2022-11-03  8:29     ` Alexander Stein
2022-11-03 12:32     ` Rob Herring
2022-11-03 12:32       ` Rob Herring
2022-11-03 16:25       ` Marek Vasut
2022-11-03 16:25         ` Marek Vasut
2022-11-04  7:19         ` Alexander Stein
2022-11-04  7:19           ` Alexander Stein
2022-11-04 11:41           ` Marek Vasut
2022-11-04 11:41             ` Marek Vasut
2022-11-02 21:57 ` [PATCH 3/3] dt-bindings: imx6q-pcie: Handle more resets on legacy platforms Marek Vasut
2022-11-02 21:57   ` Marek Vasut
2022-11-03  3:24   ` Rob Herring
2022-11-03  3:24     ` Rob Herring
2022-11-03  3:24 ` [PATCH 1/3] dt-bindings: imx6q-pcie: Handle various clock configurations Rob Herring
2022-11-03  3:24   ` Rob Herring
2022-11-03 16:07   ` Marek Vasut [this message]
2022-11-03 16:07     ` Marek Vasut
2022-11-03  8:25 ` Alexander Stein
2022-11-03  8:25   ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a36babb-a18d-b189-1ed3-0dc03f50e997@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.