Re: [PATCH v1 4/7] i2c: stm32f7: support DT binding i2c-analog-filter

[Patrice CHOTARD <patrice.chotard@foss.st.com>]

Hi Patrick

On 8/3/21 12:05 PM, Patrice Chotard wrote:
> From: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Replace driver internally coded enabling/disabling of the
> analog-filter with the DT binding "i2c-analog-filter".
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> 
>  drivers/i2c/stm32f7_i2c.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c
> index b449084b5f..e71a0e0aa3 100644
> --- a/drivers/i2c/stm32f7_i2c.c
> +++ b/drivers/i2c/stm32f7_i2c.c
> @@ -108,7 +108,6 @@ struct stm32_i2c_regs {
>  #define STM32_I2C_DNF_DEFAULT			0
>  #define STM32_I2C_DNF_MAX			16
>  
> -#define STM32_I2C_ANALOG_FILTER_ENABLE	1
>  #define STM32_I2C_ANALOG_FILTER_DELAY_MIN	50	/* ns */
>  #define STM32_I2C_ANALOG_FILTER_DELAY_MAX	260	/* ns */
>  
> @@ -919,7 +918,7 @@ static int stm32_of_to_plat(struct udevice *dev)
>  					 STM32_I2C_FALL_TIME_DEFAULT);
>  
>  	i2c_priv->setup.dnf = STM32_I2C_DNF_DEFAULT;
> -	i2c_priv->setup.analog_filter = STM32_I2C_ANALOG_FILTER_ENABLE;
> +	i2c_priv->setup.analog_filter = dev_read_bool(dev, "i2c-analog-filter");
>  
>  	/* Optional */
>  	i2c_priv->regmap = syscon_regmap_lookup_by_phandle(dev,
> 
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice