From: 王贇 <yun.wang@linux.alibaba.com> To: Guo Ren <guoren@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>, Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com>, Colin Ian King <colin.king@canonical.com>, Masami Hiramatsu <mhiramat@kernel.org>, "Peter Zijlstra (Intel)" <peterz@infradead.org>, Nicholas Piggin <npiggin@gmail.com>, Jisheng Zhang <jszhang@kernel.org>, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, live-patching@vger.kernel.org Subject: [PATCH v2 0/2] fix & prevent the missing preemption disabling Date: Wed, 13 Oct 2021 11:16:56 +0800 [thread overview] Message-ID: <1a8e8d73-b508-f90b-0d82-eb2da45a720e@linux.alibaba.com> (raw) In-Reply-To: <8c7de46d-9869-aa5e-2bb9-5dbc2eda395e@linux.alibaba.com> The testing show that perf_ftrace_function_call() are using smp_processor_id() with preemption enabled, all the checking on CPU could be wrong after preemption. As Peter point out, the section between ftrace_test_recursion_trylock/unlock() pair require the preemption to be disabled as 'Documentation/trace/ftrace-uses.rst' explained, but currently the work is done outside of the helpers. Patch 1/2 will make sure preemption disabled after trylock() succeed, patch 2/2 will do smp_processor_id() checking after trylock to address the issue. Michael Wang (2): ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() ftrace: do CPU checking after preemption disabled arch/csky/kernel/probes/ftrace.c | 2 -- arch/parisc/kernel/ftrace.c | 2 -- arch/powerpc/kernel/kprobes-ftrace.c | 2 -- arch/riscv/kernel/probes/ftrace.c | 2 -- arch/x86/kernel/kprobes/ftrace.c | 2 -- include/linux/trace_recursion.h | 22 +++++++++++++++++++++- kernel/livepatch/patch.c | 6 ------ kernel/trace/trace_event_perf.c | 6 +++--- kernel/trace/trace_functions.c | 5 ----- 9 files changed, 24 insertions(+), 25 deletions(-) -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: 王贇 <yun.wang@linux.alibaba.com> To: Guo Ren <guoren@kernel.org>, Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>, "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>, Helge Deller <deller@gmx.de>, Michael Ellerman <mpe@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>, Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>, Petr Mladek <pmladek@suse.com>, Joe Lawrence <joe.lawrence@redhat.com>, Colin Ian King <colin.king@canonical.com>, Masami Hiramatsu <mhiramat@kernel.org>, "Peter Zijlstra (Intel)" <peterz@infradead.org>, Nicholas Piggin <npiggin@gmail.com>, Jisheng Zhang <jszhang@kernel.org>, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, live-patching@vger.kernel.org Subject: [PATCH v2 0/2] fix & prevent the missing preemption disabling Date: Wed, 13 Oct 2021 11:16:56 +0800 [thread overview] Message-ID: <1a8e8d73-b508-f90b-0d82-eb2da45a720e@linux.alibaba.com> (raw) In-Reply-To: <8c7de46d-9869-aa5e-2bb9-5dbc2eda395e@linux.alibaba.com> The testing show that perf_ftrace_function_call() are using smp_processor_id() with preemption enabled, all the checking on CPU could be wrong after preemption. As Peter point out, the section between ftrace_test_recursion_trylock/unlock() pair require the preemption to be disabled as 'Documentation/trace/ftrace-uses.rst' explained, but currently the work is done outside of the helpers. Patch 1/2 will make sure preemption disabled after trylock() succeed, patch 2/2 will do smp_processor_id() checking after trylock to address the issue. Michael Wang (2): ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() ftrace: do CPU checking after preemption disabled arch/csky/kernel/probes/ftrace.c | 2 -- arch/parisc/kernel/ftrace.c | 2 -- arch/powerpc/kernel/kprobes-ftrace.c | 2 -- arch/riscv/kernel/probes/ftrace.c | 2 -- arch/x86/kernel/kprobes/ftrace.c | 2 -- include/linux/trace_recursion.h | 22 +++++++++++++++++++++- kernel/livepatch/patch.c | 6 ------ kernel/trace/trace_event_perf.c | 6 +++--- kernel/trace/trace_functions.c | 5 ----- 9 files changed, 24 insertions(+), 25 deletions(-) -- 1.8.3.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-10-13 3:17 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-12 5:39 [PATCH 0/2] ftrace: make sure preemption disabled on recursion testing 王贇 2021-10-12 5:39 ` 王贇 2021-10-12 5:40 ` [PATCH 1/2] ftrace: disable preemption on the testing of recursion 王贇 2021-10-12 5:40 ` 王贇 2021-10-12 12:17 ` Steven Rostedt 2021-10-12 12:17 ` Steven Rostedt 2021-10-12 12:17 ` Steven Rostedt 2021-10-13 1:46 ` 王贇 2021-10-13 1:46 ` 王贇 2021-10-13 1:46 ` 王贇 2021-10-12 12:24 ` Miroslav Benes 2021-10-12 12:24 ` Miroslav Benes 2021-10-12 12:24 ` Miroslav Benes 2021-10-12 12:29 ` Steven Rostedt 2021-10-12 12:29 ` Steven Rostedt 2021-10-12 12:29 ` Steven Rostedt 2021-10-13 1:52 ` 王贇 2021-10-13 1:52 ` 王贇 2021-10-13 1:52 ` 王贇 2021-10-13 1:50 ` 王贇 2021-10-13 1:50 ` 王贇 2021-10-13 1:50 ` 王贇 2021-10-13 2:27 ` Steven Rostedt 2021-10-13 2:27 ` Steven Rostedt 2021-10-13 2:27 ` Steven Rostedt 2021-10-13 2:36 ` 王贇 2021-10-13 2:36 ` 王贇 2021-10-13 2:36 ` 王贇 2021-10-12 12:43 ` Steven Rostedt 2021-10-12 12:43 ` Steven Rostedt 2021-10-12 12:43 ` Steven Rostedt 2021-10-13 2:04 ` 王贇 2021-10-13 2:04 ` 王贇 2021-10-13 2:04 ` 王贇 2021-10-13 2:30 ` Steven Rostedt 2021-10-13 2:30 ` Steven Rostedt 2021-10-13 2:30 ` Steven Rostedt 2021-10-13 2:38 ` 王贇 2021-10-13 2:38 ` 王贇 2021-10-13 2:38 ` 王贇 2021-10-12 5:40 ` [PATCH 2/2] ftrace: prevent preemption in perf_ftrace_function_call() 王贇 2021-10-12 5:40 ` 王贇 2021-10-12 11:20 ` Peter Zijlstra 2021-10-12 11:20 ` Peter Zijlstra 2021-10-12 11:20 ` Peter Zijlstra 2021-10-13 1:45 ` 王贇 2021-10-13 1:45 ` 王贇 2021-10-13 1:45 ` 王贇 2021-10-12 5:41 ` [PATCH 0/2] ftrace: make sure preemption disabled on recursion testing 王贇 2021-10-12 5:41 ` 王贇 2021-10-13 3:16 ` 王贇 [this message] 2021-10-13 3:16 ` [PATCH v2 0/2] fix & prevent the missing preemption disabling 王贇 2021-10-13 3:17 ` [PATCH v2 1/2] ftrace: disable preemption between ftrace_test_recursion_trylock/unlock() 王贇 2021-10-13 3:17 ` 王贇 2021-10-13 3:18 ` [PATCH v2 2/2] ftrace: do CPU checking after preemption disabled 王贇 2021-10-13 3:18 ` 王贇 2021-10-13 3:26 ` [PATCH v2 0/2] fix & prevent the missing preemption disabling Steven Rostedt 2021-10-13 3:26 ` Steven Rostedt 2021-10-13 3:26 ` Steven Rostedt 2021-10-13 3:33 ` 王贇 2021-10-13 3:33 ` 王贇 2021-10-13 3:33 ` 王贇 2021-10-26 23:48 ` [PATCH 0/2] ftrace: make sure preemption disabled on recursion testing Palmer Dabbelt 2021-10-26 23:48 ` Palmer Dabbelt 2021-10-26 23:48 ` Palmer Dabbelt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1a8e8d73-b508-f90b-0d82-eb2da45a720e@linux.alibaba.com \ --to=yun.wang@linux.alibaba.com \ --cc=James.Bottomley@HansenPartnership.com \ --cc=aou@eecs.berkeley.edu \ --cc=benh@kernel.crashing.org \ --cc=bp@alien8.de \ --cc=colin.king@canonical.com \ --cc=deller@gmx.de \ --cc=guoren@kernel.org \ --cc=hpa@zytor.com \ --cc=jikos@kernel.org \ --cc=joe.lawrence@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=jszhang@kernel.org \ --cc=linux-csky@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=live-patching@vger.kernel.org \ --cc=mbenes@suse.cz \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.