From: shuah <shuah@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Christian Brauner <christian@brauner.io>,
Tycho Andersen <tycho@tycho.ws>, Serge Hallyn <serge@hallyn.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, shuah <shuah@kernel.org>
Subject: Re: [PATCH v2 0/8] selftests: Move test output to diagnostic lines
Date: Thu, 25 Apr 2019 14:39:37 -0600 [thread overview]
Message-ID: <1afe0a17-c539-6ef2-ecff-f4ade4a865e7@kernel.org> (raw)
In-Reply-To: <CAGXu5jJChvx-_E8RMTi3ioUZGuQGViy6gcAMpmvYZzms=zc6dQ@mail.gmail.com>
On 4/25/19 11:05 AM, Kees Cook wrote:
> On Thu, Apr 25, 2019 at 9:52 AM shuah <shuah@kernel.org> wrote:
>>
>> On 4/24/19 5:12 PM, wrote:
>>> This refactors the selftest Makefiles to extract the test running logic
>>> to be reused between "run_tests" and "emit_tests", while also fixing
>>> up the test output to be TAP version 13 compliant:
>>> - added "plan" line
>>> - fixed result line syntax
>>> - moved all test output to be "# "-prefixed as TAP "diagnostic" lines
>>>
>>> The prefixing code includes a fallback mode for limited execution
>>> environments.
>>>
>>> Additionally, the plan lines are fixed for all callers of kselftest.h.
>>>
>>> -Kees
>>>
>>
>> Kees,
>>
>> Just about to apply these to a topic branch to do testing and ran into
>> checkpatch errors:
>>
>>
>> WARNING: line over 80 characters - a few
>
> I only saw one, which is on a string which kernel coding style says to
> leave unsplit:
>
> WARNING: line over 80 characters
> #55: FILE: tools/testing/selftests/kselftest/runner.sh:19:
> + echo "$TEST_HDR_MSG: Warning: file $TEST is not
> executable, correct this."
>
>> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
>> #141: FILE: tools/testing/selftests/kselftest/runner.sh:2:
>
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #37: FILE: tools/testing/selftests/kselftest/runner.sh:2:
> # SPDX-License-Identifier: GPL-2.0
>
> This is a shell script. It can't be on line 1:
>
> $ head -n3 tools/testing/selftests/kselftest/runner.sh
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> #
>
> That looks like a bug in checkpatch not resetting the expected line or
> something.
>
>> Can fix them and resend - SPDX one is my main concern.
>
> These appear to be false positives; I don't think I need to fix them?
> Let me know what you think.
>
>> The plan is to apply these to linux-kselftest ksft-tap-refactor topic
>> first. I don't want to rush these until we do some testing.
>
> Absolutely. :)
>
> Thanks!
>
Kees,
Pushed all 8 patches to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
ksft-tap-refactor topic branch
I will have time to test tomorrow.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (shuah)
Subject: [PATCH v2 0/8] selftests: Move test output to diagnostic lines
Date: Thu, 25 Apr 2019 14:39:37 -0600 [thread overview]
Message-ID: <1afe0a17-c539-6ef2-ecff-f4ade4a865e7@kernel.org> (raw)
In-Reply-To: <CAGXu5jJChvx-_E8RMTi3ioUZGuQGViy6gcAMpmvYZzms=zc6dQ@mail.gmail.com>
On 4/25/19 11:05 AM, Kees Cook wrote:
> On Thu, Apr 25, 2019 at 9:52 AM shuah <shuah at kernel.org> wrote:
>>
>> On 4/24/19 5:12 PM, wrote:
>>> This refactors the selftest Makefiles to extract the test running logic
>>> to be reused between "run_tests" and "emit_tests", while also fixing
>>> up the test output to be TAP version 13 compliant:
>>> - added "plan" line
>>> - fixed result line syntax
>>> - moved all test output to be "# "-prefixed as TAP "diagnostic" lines
>>>
>>> The prefixing code includes a fallback mode for limited execution
>>> environments.
>>>
>>> Additionally, the plan lines are fixed for all callers of kselftest.h.
>>>
>>> -Kees
>>>
>>
>> Kees,
>>
>> Just about to apply these to a topic branch to do testing and ran into
>> checkpatch errors:
>>
>>
>> WARNING: line over 80 characters - a few
>
> I only saw one, which is on a string which kernel coding style says to
> leave unsplit:
>
> WARNING: line over 80 characters
> #55: FILE: tools/testing/selftests/kselftest/runner.sh:19:
> + echo "$TEST_HDR_MSG: Warning: file $TEST is not
> executable, correct this."
>
>> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
>> #141: FILE: tools/testing/selftests/kselftest/runner.sh:2:
>
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #37: FILE: tools/testing/selftests/kselftest/runner.sh:2:
> # SPDX-License-Identifier: GPL-2.0
>
> This is a shell script. It can't be on line 1:
>
> $ head -n3 tools/testing/selftests/kselftest/runner.sh
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> #
>
> That looks like a bug in checkpatch not resetting the expected line or
> something.
>
>> Can fix them and resend - SPDX one is my main concern.
>
> These appear to be false positives; I don't think I need to fix them?
> Let me know what you think.
>
>> The plan is to apply these to linux-kselftest ksft-tap-refactor topic
>> first. I don't want to rush these until we do some testing.
>
> Absolutely. :)
>
> Thanks!
>
Kees,
Pushed all 8 patches to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
ksft-tap-refactor topic branch
I will have time to test tomorrow.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (shuah)
Subject: [PATCH v2 0/8] selftests: Move test output to diagnostic lines
Date: Thu, 25 Apr 2019 14:39:37 -0600 [thread overview]
Message-ID: <1afe0a17-c539-6ef2-ecff-f4ade4a865e7@kernel.org> (raw)
Message-ID: <20190425203937.J8WohR_sEOqQe6bPI5n2H0yPZlanACGi0LuFUbougwI@z> (raw)
In-Reply-To: <CAGXu5jJChvx-_E8RMTi3ioUZGuQGViy6gcAMpmvYZzms=zc6dQ@mail.gmail.com>
On 4/25/19 11:05 AM, Kees Cook wrote:
> On Thu, Apr 25, 2019@9:52 AM shuah <shuah@kernel.org> wrote:
>>
>> On 4/24/19 5:12 PM, wrote:
>>> This refactors the selftest Makefiles to extract the test running logic
>>> to be reused between "run_tests" and "emit_tests", while also fixing
>>> up the test output to be TAP version 13 compliant:
>>> - added "plan" line
>>> - fixed result line syntax
>>> - moved all test output to be "# "-prefixed as TAP "diagnostic" lines
>>>
>>> The prefixing code includes a fallback mode for limited execution
>>> environments.
>>>
>>> Additionally, the plan lines are fixed for all callers of kselftest.h.
>>>
>>> -Kees
>>>
>>
>> Kees,
>>
>> Just about to apply these to a topic branch to do testing and ran into
>> checkpatch errors:
>>
>>
>> WARNING: line over 80 characters - a few
>
> I only saw one, which is on a string which kernel coding style says to
> leave unsplit:
>
> WARNING: line over 80 characters
> #55: FILE: tools/testing/selftests/kselftest/runner.sh:19:
> + echo "$TEST_HDR_MSG: Warning: file $TEST is not
> executable, correct this."
>
>> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
>> #141: FILE: tools/testing/selftests/kselftest/runner.sh:2:
>
> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
> #37: FILE: tools/testing/selftests/kselftest/runner.sh:2:
> # SPDX-License-Identifier: GPL-2.0
>
> This is a shell script. It can't be on line 1:
>
> $ head -n3 tools/testing/selftests/kselftest/runner.sh
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> #
>
> That looks like a bug in checkpatch not resetting the expected line or
> something.
>
>> Can fix them and resend - SPDX one is my main concern.
>
> These appear to be false positives; I don't think I need to fix them?
> Let me know what you think.
>
>> The plan is to apply these to linux-kselftest ksft-tap-refactor topic
>> first. I don't want to rush these until we do some testing.
>
> Absolutely. :)
>
> Thanks!
>
Kees,
Pushed all 8 patches to
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
ksft-tap-refactor topic branch
I will have time to test tomorrow.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-04-25 20:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 23:12 [PATCH v2 0/8] selftests: Move test output to diagnostic lines Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 1/8] selftests: Extract single-test shell logic from lib.mk Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 2/8] selftests: Use runner.sh for emit targets Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 3/8] selftests: Extract logic for multiple test runs Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 4/8] selftests: Add plan line and fix result line syntax Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 5/8] selftests: Distinguish between missing and non-executable Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 6/8] selftests: Move test output to diagnostic lines Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 7/8] selftests: Remove KSFT_TAP_LEVEL Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-25 16:36 ` shuah
2019-04-25 16:36 ` shuah
2019-04-25 16:36 ` shuah
2019-04-25 16:56 ` Kees Cook
2019-04-25 16:56 ` Kees Cook
2019-04-25 16:56 ` keescook
2019-04-25 17:06 ` shuah
2019-04-25 17:06 ` shuah
2019-04-25 17:06 ` shuah
2019-04-24 23:12 ` [PATCH v2 8/8] selftests: Add test plan API to kselftest.h and adjust callers Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-25 16:52 ` [PATCH v2 0/8] selftests: Move test output to diagnostic lines shuah
2019-04-25 16:52 ` shuah
2019-04-25 16:52 ` shuah
2019-04-25 17:05 ` Kees Cook
2019-04-25 17:05 ` Kees Cook
2019-04-25 17:05 ` keescook
2019-04-25 17:11 ` Kees Cook
2019-04-25 17:11 ` Kees Cook
2019-04-25 17:11 ` keescook
2019-04-25 20:39 ` shuah [this message]
2019-04-25 20:39 ` shuah
2019-04-25 20:39 ` shuah
2019-04-25 21:19 ` Kees Cook
2019-04-25 21:19 ` Kees Cook
2019-04-25 21:19 ` keescook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1afe0a17-c539-6ef2-ecff-f4ade4a865e7@kernel.org \
--to=shuah@kernel.org \
--cc=christian@brauner.io \
--cc=dvhart@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.