From: shuah <shuah@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Christian Brauner <christian@brauner.io>,
Tycho Andersen <tycho@tycho.ws>, Serge Hallyn <serge@hallyn.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v2 7/8] selftests: Remove KSFT_TAP_LEVEL
Date: Thu, 25 Apr 2019 10:36:24 -0600 [thread overview]
Message-ID: <1ca5ee52-ab07-9142-2e45-44df1e94276e@kernel.org> (raw)
In-Reply-To: <20190424231237.14776-8-keescook@chromium.org>
On 4/24/19 5:12 PM, Kees Cook wrote:
> Since sub-testing can now be detected by indentation level, this removes
> KSFT_TAP_LEVEL so that subtests report their TAP header for later parsing.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> tools/testing/selftests/Makefile | 6 ------
> tools/testing/selftests/kselftest/runner.sh | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 64699f59b95f..9f05448e5e4b 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -86,12 +86,6 @@ else
> endif
> endif
>
> -# KSFT_TAP_LEVEL is used from KSFT framework to prevent nested TAP header
> -# printing from tests. Applicable to run_tests case where run_tests adds
> -# TAP header prior running tests and when a test program invokes another
> -# with system() call. Export it here to cover override RUN_TESTS defines.
> -export KSFT_TAP_LEVEL=`echo 1`
> -
> # Prepare for headers install
> top_srcdir ?= ../../..
> include $(top_srcdir)/scripts/subarch.include
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index b9f74e5a2ee5..eff3ee303d0d 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -2,7 +2,6 @@
> # SPDX-License-Identifier: GPL-2.0
> #
> # Runs a set of tests in a given subdirectory.
> -export KSFT_TAP_LEVEL=1
> export skip_rc=4
> export logfile=/dev/stdout
> export per_test_logging=
>
Does this take into ksft_print_header() getenv logic to avoid printing
TAP headers from tests when they fork? e.g timers tests do that a lot.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah at kernel.org (shuah)
Subject: [PATCH v2 7/8] selftests: Remove KSFT_TAP_LEVEL
Date: Thu, 25 Apr 2019 10:36:24 -0600 [thread overview]
Message-ID: <1ca5ee52-ab07-9142-2e45-44df1e94276e@kernel.org> (raw)
In-Reply-To: <20190424231237.14776-8-keescook@chromium.org>
On 4/24/19 5:12 PM, Kees Cook wrote:
> Since sub-testing can now be detected by indentation level, this removes
> KSFT_TAP_LEVEL so that subtests report their TAP header for later parsing.
>
> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
> tools/testing/selftests/Makefile | 6 ------
> tools/testing/selftests/kselftest/runner.sh | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 64699f59b95f..9f05448e5e4b 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -86,12 +86,6 @@ else
> endif
> endif
>
> -# KSFT_TAP_LEVEL is used from KSFT framework to prevent nested TAP header
> -# printing from tests. Applicable to run_tests case where run_tests adds
> -# TAP header prior running tests and when a test program invokes another
> -# with system() call. Export it here to cover override RUN_TESTS defines.
> -export KSFT_TAP_LEVEL=`echo 1`
> -
> # Prepare for headers install
> top_srcdir ?= ../../..
> include $(top_srcdir)/scripts/subarch.include
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index b9f74e5a2ee5..eff3ee303d0d 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -2,7 +2,6 @@
> # SPDX-License-Identifier: GPL-2.0
> #
> # Runs a set of tests in a given subdirectory.
> -export KSFT_TAP_LEVEL=1
> export skip_rc=4
> export logfile=/dev/stdout
> export per_test_logging=
>
Does this take into ksft_print_header() getenv logic to avoid printing
TAP headers from tests when they fork? e.g timers tests do that a lot.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: shuah@kernel.org (shuah)
Subject: [PATCH v2 7/8] selftests: Remove KSFT_TAP_LEVEL
Date: Thu, 25 Apr 2019 10:36:24 -0600 [thread overview]
Message-ID: <1ca5ee52-ab07-9142-2e45-44df1e94276e@kernel.org> (raw)
Message-ID: <20190425163624.DXZ8Vw1g4kawrR8-AltxI-c0YvvhDKYAmfGcFTSOJI8@z> (raw)
In-Reply-To: <20190424231237.14776-8-keescook@chromium.org>
On 4/24/19 5:12 PM, Kees Cook wrote:
> Since sub-testing can now be detected by indentation level, this removes
> KSFT_TAP_LEVEL so that subtests report their TAP header for later parsing.
>
> Signed-off-by: Kees Cook <keescook at chromium.org>
> ---
> tools/testing/selftests/Makefile | 6 ------
> tools/testing/selftests/kselftest/runner.sh | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 64699f59b95f..9f05448e5e4b 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -86,12 +86,6 @@ else
> endif
> endif
>
> -# KSFT_TAP_LEVEL is used from KSFT framework to prevent nested TAP header
> -# printing from tests. Applicable to run_tests case where run_tests adds
> -# TAP header prior running tests and when a test program invokes another
> -# with system() call. Export it here to cover override RUN_TESTS defines.
> -export KSFT_TAP_LEVEL=`echo 1`
> -
> # Prepare for headers install
> top_srcdir ?= ../../..
> include $(top_srcdir)/scripts/subarch.include
> diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh
> index b9f74e5a2ee5..eff3ee303d0d 100644
> --- a/tools/testing/selftests/kselftest/runner.sh
> +++ b/tools/testing/selftests/kselftest/runner.sh
> @@ -2,7 +2,6 @@
> # SPDX-License-Identifier: GPL-2.0
> #
> # Runs a set of tests in a given subdirectory.
> -export KSFT_TAP_LEVEL=1
> export skip_rc=4
> export logfile=/dev/stdout
> export per_test_logging=
>
Does this take into ksft_print_header() getenv logic to avoid printing
TAP headers from tests when they fork? e.g timers tests do that a lot.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-04-25 16:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 23:12 [PATCH v2 0/8] selftests: Move test output to diagnostic lines Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 1/8] selftests: Extract single-test shell logic from lib.mk Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 2/8] selftests: Use runner.sh for emit targets Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 3/8] selftests: Extract logic for multiple test runs Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 4/8] selftests: Add plan line and fix result line syntax Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 5/8] selftests: Distinguish between missing and non-executable Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 6/8] selftests: Move test output to diagnostic lines Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-24 23:12 ` [PATCH v2 7/8] selftests: Remove KSFT_TAP_LEVEL Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-25 16:36 ` shuah [this message]
2019-04-25 16:36 ` shuah
2019-04-25 16:36 ` shuah
2019-04-25 16:56 ` Kees Cook
2019-04-25 16:56 ` Kees Cook
2019-04-25 16:56 ` keescook
2019-04-25 17:06 ` shuah
2019-04-25 17:06 ` shuah
2019-04-25 17:06 ` shuah
2019-04-24 23:12 ` [PATCH v2 8/8] selftests: Add test plan API to kselftest.h and adjust callers Kees Cook
2019-04-24 23:12 ` Kees Cook
2019-04-24 23:12 ` keescook
2019-04-25 16:52 ` [PATCH v2 0/8] selftests: Move test output to diagnostic lines shuah
2019-04-25 16:52 ` shuah
2019-04-25 16:52 ` shuah
2019-04-25 17:05 ` Kees Cook
2019-04-25 17:05 ` Kees Cook
2019-04-25 17:05 ` keescook
2019-04-25 17:11 ` Kees Cook
2019-04-25 17:11 ` Kees Cook
2019-04-25 17:11 ` keescook
2019-04-25 20:39 ` shuah
2019-04-25 20:39 ` shuah
2019-04-25 20:39 ` shuah
2019-04-25 21:19 ` Kees Cook
2019-04-25 21:19 ` Kees Cook
2019-04-25 21:19 ` keescook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ca5ee52-ab07-9142-2e45-44df1e94276e@kernel.org \
--to=shuah@kernel.org \
--cc=christian@brauner.io \
--cc=dvhart@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.